fix(faultfs): crash files in path order so power loss is reproducible per seed

commit: 60f7034381d3325d5f09f4a999efc3a5bfff3359
author: brice · 12d ago · 2026-10-10 02:10 UTC
parent: aeec46d
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +5 -1

M internal/fsys/faultfs/faultfs.go +5 -1


@@ -15,9 +15,11 @@ import (
15	15		"errors"
16	16		"io"
17	17		"io/fs"
	18	+	"maps"
18	19		"math/rand/v2"
19	20		"os"
20	21		"path/filepath"
	22	+	"slices"
21	23		"sort"
22	24		"sync"
23	25		"time"

@@ -175,8 +177,10 @@ func (f *FS) PowerLoss(o PowerLossOptions) {
175	177		delete(f.files, p)
176	178		}
177	179		}
	180	+	// Crash files in path order so a seeded Rand gives reproducible results.
178	181		seen := map[*node]bool{}
179		-	for _, n := range f.files {
	182	+	for _, p := range slices.Sorted(maps.Keys(f.files)) {
	183	+	n := f.files[p]
180	184		if !seen[n] {
181	185		seen[n] = true
182	186		n.crash(o)

 	"errors"
 	"io"
 	"io/fs"
+	"maps"
 	"math/rand/v2"
 	"os"
 	"path/filepath"
+	"slices"
 	"sort"
 	"sync"
 	"time"
 			delete(f.files, p)
 		}
 	}
+	// Crash files in path order so a seeded Rand gives reproducible results.
 	seen := map[*node]bool{}
-	for _, n := range f.files {
+	for _, p := range slices.Sorted(maps.Keys(f.files)) {
+		n := f.files[p]
 		if !seen[n] {
 			seen[n] = true
 			n.crash(o)