detached 0ee31e3

test(guest): resolver round trip with the host handler

commit
0ee31e3b6e653e7fdba409eb52ddbf4097c92bd7
author
brice · · 2026-10-13 16:40 UTC
parent
92205ff
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +82 -0
A internal/guest/resolver_test.go +82 -0
@@ -0,0 +1,82 @@
1+// SPDX-License-Identifier: MIT
2+
3+package guest
4+
5+import (
6+ "context"
7+ "net"
8+ "testing"
9+
10+ "bnema.dev/ermite-runner/internal/execstream"
11+ "bnema.dev/ermite-runner/internal/execstream/execpb"
12+)
13+
14+// The resolver of the executor and the Resolve handler of the host meet on the
15+// stream: requests are answered by id, in any order, and an error of the host
16+// reaches the caller.
17+func TestResolverRoundTrip(t *testing.T) {
18+ ln, err := net.Listen("tcp", "127.0.0.1:0")
19+ if err != nil {
20+ t.Skip(err)
21+ }
22+ defer func() { _ = ln.Close() }()
23+ guestSide, err := net.Dial("tcp", ln.Addr().String())
24+ if err != nil {
25+ t.Fatal(err)
26+ }
27+ hostSide, err := ln.Accept()
28+ if err != nil {
29+ t.Fatal(err)
30+ }
31+ defer func() { _ = hostSide.Close() }()
32+ defer func() { _ = guestSide.Close() }()
33+
34+ gconn := execstream.NewConn(guestSide)
35+ res := newResolver(gconn)
36+ go func() { // the guest's frame reader
37+ for {
38+ f, err := gconn.Recv()
39+ if err != nil {
40+ return
41+ }
42+ if r := f.GetResolveResponse(); r != nil {
43+ res.deliver(r)
44+ }
45+ }
46+ }()
47+ // The executor says Hello first, as it does at startup.
48+ if err := gconn.Send(&execpb.Frame{Body: &execpb.Frame_Hello{Hello: &execpb.Hello{}}}); err != nil {
49+ t.Fatal(err)
50+ }
51+ done := make(chan struct{})
52+ go func() {
53+ defer close(done)
54+ _, _, _ = execstream.DriveJob(hostSide, &execpb.Run{}, nil, execstream.JobHandler{
55+ Resolve: func(r *execpb.ResolveRequest) *execpb.ResolveResponse {
56+ if len(r.Uses) == 1 && r.Uses[0] == "bad@v1" {
57+ return &execpb.ResolveResponse{Error: "no"}
58+ }
59+ out := &execpb.ResolveResponse{}
60+ for _, u := range r.Uses {
61+ out.Actions = append(out.Actions, &execpb.ResolvedAction{Ref: u, Token: "t-" + u, ResolvedSha: "sha"})
62+ }
63+ return out
64+ },
65+ })
66+ }()
67+ // DriveJob sends Run after Hello; the guest ignores it.
68+ got, err := res.resolve(context.Background(), []string{"a/b@v1", "c/d@v2"})
69+ if err != nil || len(got) != 2 || got[1].Ref != "c/d@v2" || got[1].Token != "t-c/d@v2" || got[0].ResolvedSHA != "sha" {
70+ t.Fatalf("%+v %v", got, err)
71+ }
72+ if _, err := res.resolve(context.Background(), []string{"bad@v1"}); err == nil || err.Error() != "no" {
73+ t.Fatalf("error not passed: %v", err)
74+ }
75+ ctx, cancel := context.WithCancel(context.Background())
76+ cancel()
77+ _ = guestSide.Close()
78+ if _, err := res.resolve(ctx, []string{"x/y@z"}); err == nil {
79+ t.Error("a closed stream must fail")
80+ }
81+ <-done
82+}
@@ -0,0 +1,82 @@
1+// SPDX-License-Identifier: MIT
2+
3+package guest
4+
5+import (
6+ "context"
7+ "net"
8+ "testing"
9+
10+ "bnema.dev/ermite-runner/internal/execstream"
11+ "bnema.dev/ermite-runner/internal/execstream/execpb"
12+)
13+
14+// The resolver of the executor and the Resolve handler of the host meet on the
15+// stream: requests are answered by id, in any order, and an error of the host
16+// reaches the caller.
17+func TestResolverRoundTrip(t *testing.T) {
18+ ln, err := net.Listen("tcp", "127.0.0.1:0")
19+ if err != nil {
20+ t.Skip(err)
21+ }
22+ defer func() { _ = ln.Close() }()
23+ guestSide, err := net.Dial("tcp", ln.Addr().String())
24+ if err != nil {
25+ t.Fatal(err)
26+ }
27+ hostSide, err := ln.Accept()
28+ if err != nil {
29+ t.Fatal(err)
30+ }
31+ defer func() { _ = hostSide.Close() }()
32+ defer func() { _ = guestSide.Close() }()
33+
34+ gconn := execstream.NewConn(guestSide)
35+ res := newResolver(gconn)
36+ go func() { // the guest's frame reader
37+ for {
38+ f, err := gconn.Recv()
39+ if err != nil {
40+ return
41+ }
42+ if r := f.GetResolveResponse(); r != nil {
43+ res.deliver(r)
44+ }
45+ }
46+ }()
47+ // The executor says Hello first, as it does at startup.
48+ if err := gconn.Send(&execpb.Frame{Body: &execpb.Frame_Hello{Hello: &execpb.Hello{}}}); err != nil {
49+ t.Fatal(err)
50+ }
51+ done := make(chan struct{})
52+ go func() {
53+ defer close(done)
54+ _, _, _ = execstream.DriveJob(hostSide, &execpb.Run{}, nil, execstream.JobHandler{
55+ Resolve: func(r *execpb.ResolveRequest) *execpb.ResolveResponse {
56+ if len(r.Uses) == 1 && r.Uses[0] == "bad@v1" {
57+ return &execpb.ResolveResponse{Error: "no"}
58+ }
59+ out := &execpb.ResolveResponse{}
60+ for _, u := range r.Uses {
61+ out.Actions = append(out.Actions, &execpb.ResolvedAction{Ref: u, Token: "t-" + u, ResolvedSha: "sha"})
62+ }
63+ return out
64+ },
65+ })
66+ }()
67+ // DriveJob sends Run after Hello; the guest ignores it.
68+ got, err := res.resolve(context.Background(), []string{"a/b@v1", "c/d@v2"})
69+ if err != nil || len(got) != 2 || got[1].Ref != "c/d@v2" || got[1].Token != "t-c/d@v2" || got[0].ResolvedSHA != "sha" {
70+ t.Fatalf("%+v %v", got, err)
71+ }
72+ if _, err := res.resolve(context.Background(), []string{"bad@v1"}); err == nil || err.Error() != "no" {
73+ t.Fatalf("error not passed: %v", err)
74+ }
75+ ctx, cancel := context.WithCancel(context.Background())
76+ cancel()
77+ _ = guestSide.Close()
78+ if _, err := res.resolve(ctx, []string{"x/y@z"}); err == nil {
79+ t.Error("a closed stream must fail")
80+ }
81+ <-done
82+}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 4

Tags 11

↑↓ moveenter openesc close