detached 9783786

docs(executor): say that archive links are validated at install time

commit
978378657d0e9253c67988518d5a850dffeef345
author
brice · · 2026-10-14 03:14 UTC
parent
e509bea
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +3 -0
M internal/executor/actions_extract.go +3 -0
@@ -60,6 +60,9 @@ func (c *capReader) Read(p []byte) (int, error) {
6060 // no link whose target leaves dir, and everything is written through an
6161 // os.Root, so that a link planted by an earlier entry cannot redirect a later
6262 // one. The decompressed stream is capped, and ctx is checked between entries.
63+// Links are validated at install time: a running step can change the action
64+// tree like any file of its own sandbox, so this is not a confinement guarantee
65+// for what happens later.
6366 // owner, when set, is the uid and gid of the files.
6467 func extractTarball(ctx context.Context, r io.Reader, dir string, owner *[2]int) error {
6568 zr, err := gzip.NewReader(r)
@@ -60,6 +60,9 @@ func (c *capReader) Read(p []byte) (int, error) {
60 // no link whose target leaves dir, and everything is written through an60 // no link whose target leaves dir, and everything is written through an
61 // os.Root, so that a link planted by an earlier entry cannot redirect a later61 // os.Root, so that a link planted by an earlier entry cannot redirect a later
62 // one. The decompressed stream is capped, and ctx is checked between entries.62 // one. The decompressed stream is capped, and ctx is checked between entries.
63+// Links are validated at install time: a running step can change the action
64+// tree like any file of its own sandbox, so this is not a confinement guarantee
65+// for what happens later.
63 // owner, when set, is the uid and gid of the files.66 // owner, when set, is the uid and gid of the files.
64 func extractTarball(ctx context.Context, r io.Reader, dir string, owner *[2]int) error {67 func extractTarball(ctx context.Context, r io.Reader, dir string, owner *[2]int) error {
65 zr, err := gzip.NewReader(r)68 zr, err := gzip.NewReader(r)

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 4

Tags 11

↑↓ moveenter openesc close