detached ea0a5ee

test(integration): an empty jail/<exec name> directory is not a leftover

The jailer creates <chroot base>/<exec file name> and never removes it; only
the per-VM directories below it belong to a job.
commit
ea0a5ee25d1ad5ce644640e79da5799362aedae8
author
brice · · 2026-10-12 21:28 UTC
parent
2bb0741
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +5 -0
M internal/sandbox/integration/integration_test.go +5 -0
@@ -202,6 +202,11 @@ func leftovers(stateDir string) []string {
202202 _ = filepath.WalkDir(filepath.Join(stateDir, d), func(p string, e os.DirEntry, err error) error {
203203 if err == nil && p != filepath.Join(stateDir, d) {
204204 rel, _ := filepath.Rel(stateDir, p)
205+ // <state>/jail/<exec file name> is the jailer's static parent of the
206+ // per-job chroots (like jail/ itself): not a leftover when empty.
207+ if e.IsDir() && d == "jail" && filepath.Dir(rel) == "jail" {
208+ return nil
209+ }
205210 left = append(left, "file "+rel)
206211 }
207212 return nil
@@ -202,6 +202,11 @@ func leftovers(stateDir string) []string {
202 _ = filepath.WalkDir(filepath.Join(stateDir, d), func(p string, e os.DirEntry, err error) error {202 _ = filepath.WalkDir(filepath.Join(stateDir, d), func(p string, e os.DirEntry, err error) error {
203 if err == nil && p != filepath.Join(stateDir, d) {203 if err == nil && p != filepath.Join(stateDir, d) {
204 rel, _ := filepath.Rel(stateDir, p)204 rel, _ := filepath.Rel(stateDir, p)
205+ // <state>/jail/<exec file name> is the jailer's static parent of the
206+ // per-job chroots (like jail/ itself): not a leftover when empty.
207+ if e.IsDir() && d == "jail" && filepath.Dir(rel) == "jail" {
208+ return nil
209+ }
205 left = append(left, "file "+rel)210 left = append(left, "file "+rel)
206 }211 }
207 return nil212 return nil

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 4

Tags 11

↑↓ moveenter openesc close