main 80d5067

Lint failure 1m 23s

Annotations 10

  1. Current runner version: 'v0.5.1'
  2. GITHUB_TOKEN Permissions
  3. Contents: read
  4. Metadata: read
  5. Packages: read
  7. Secret source: Actions
  8. Cache mode: write
  9. Prepare workflow directory
  10. Prepare all required actions
  11. Getting action download info
  12. Download action repository 'actions/checkout@v6' (SHA:d23441a48e516b6c34aea4fa41551a30e30af803)
  13. Download action repository 'actions/setup-go@v7' (SHA:b7ad1dad31e06c5925ef5d2fc7ad053ef454303e)
  14. Download action repository 'golangci/golangci-lint-action@v9' (SHA:ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a)
  15. Complete job name: Lint
  16. Run actions/checkout@v6
  17. with:
  18. repository: bnema/ermite
  19. token: ***
  20. ssh-strict: true
  21. ssh-user: git
  22. persist-credentials: true
  23. clean: true
  24. sparse-checkout-cone-mode: true
  25. fetch-depth: 1
  26. fetch-tags: false
  27. show-progress: true
  28. lfs: false
  29. submodules: false
  30. set-safe-directory: true
  31. allow-unsafe-pr-checkout: false
  32. env:
  33. GOWORK: off
  35. Syncing repository: bnema/ermite
  36. Getting Git version info
  37. Working directory is '/home/runner/work/ermite/ermite'
  38. [command]/usr/bin/git version
  39. git version 2.53.0
  41. Temporarily overriding HOME='/home/runner/work/_temp/8c52fe9d-f0a8-4fdf-8e84-e904e58d31a6' before making global git config changes
  42. Adding repository directory to the temporary git global config as a safe directory
  43. [command]/usr/bin/git config --global --add safe.directory /home/runner/work/ermite/ermite
  44. Deleting the contents of '/home/runner/work/ermite/ermite'
  45. Determining repository object format
  47. Initializing the repository
  48. [command]/usr/bin/git init /home/runner/work/ermite/ermite
  49. hint: Using 'master' as the name for the initial branch. This default branch name
  50. hint: will change to "main" in Git 3.0. To configure the initial branch name
  51. hint: to use in all of your new repositories, which will suppress this warning,
  52. hint: call:
  53. hint:
  54. hint: git config --global init.defaultBranch <name>
  55. hint:
  56. hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and
  57. hint: 'development'. The just-created branch can be renamed via this command:
  58. hint:
  59. hint: git branch -m <name>
  60. hint:
  61. hint: Disable this message with "git config set advice.defaultBranchName false"
  62. Initialized empty Git repository in /home/runner/work/ermite/ermite/.git/
  63. [command]/usr/bin/git remote add origin http://ermite:7341/bnema/ermite
  65. Disabling automatic garbage collection
  66. [command]/usr/bin/git config --local gc.auto 0
  68. Setting up auth
  69. Removing SSH command configuration
  70. [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
  71. [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
  72. Removing HTTP extra header
  73. [command]/usr/bin/git config --local --name-only --get-regexp http\.http\:\/\/ermite\:7341\/\.extraheader
  74. [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.http\:\/\/ermite\:7341\/\.extraheader' && git config --local --unset-all 'http.http://ermite:7341/.extraheader' || :"
  75. Removing includeIf entries pointing to credentials config files
  76. [command]/usr/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
  77. [command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
  78. [command]/usr/bin/git config --file /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config http.http://ermite:7341/.extraheader AUTHORIZATION: basic ***
  79. [command]/usr/bin/git config --local includeIf.gitdir:/home/runner/work/ermite/ermite/.git.path /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  80. [command]/usr/bin/git config --local includeIf.gitdir:/home/runner/work/ermite/ermite/.git/worktrees/*.path /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  81. [command]/usr/bin/git config --local includeIf.gitdir:/github/workspace/.git.path /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  82. [command]/usr/bin/git config --local includeIf.gitdir:/github/workspace/.git/worktrees/*.path /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  84. Fetching the repository
  85. [command]/usr/bin/git -c protocol.version=2 fetch --no-tags --prune --no-recurse-submodules --depth=1 origin +fda3c2b1c2def2d9d59f9847c67fb31bc63626a7:refs/remotes/pull/24/merge
  86. From http://ermite:7341/bnema/ermite
  87. * [new ref] fda3c2b1c2def2d9d59f9847c67fb31bc63626a7 -> pull/24/merge
  89. Determining the checkout info
  91. [command]/usr/bin/git sparse-checkout disable
  92. [command]/usr/bin/git config --local --unset-all extensions.worktreeConfig
  93. Checking out the ref
  94. [command]/usr/bin/git checkout --progress --force refs/remotes/pull/24/merge
  95. Note: switching to 'refs/remotes/pull/24/merge'.
  97. You are in 'detached HEAD' state. You can look around, make experimental
  98. changes and commit them, and you can discard any commits you make in this
  99. state without impacting any branches by switching back to a branch.
  101. If you want to create a new branch to retain commits you create, you may
  102. do so (now or later) by using -c with the switch command. Example:
  104. git switch -c <new-branch-name>
  106. Or undo this operation with:
  108. git switch -
  110. Turn off this advice by setting config variable advice.detachedHead to false
  112. HEAD is now at fda3c2b Merge b869944009400099e6fe8932fecbdf470c52dcef into f61e6a68e9c866c042a8c5e4f64cae2b1290a363
  114. [command]/usr/bin/git log -1 --format=%H
  115. fda3c2b1c2def2d9d59f9847c67fb31bc63626a7
  116. Run actions/setup-go@v7
  117. with:
  118. go-version-file: go.mod
  119. cache: true
  120. check-latest: false
  121. env:
  122. GOWORK: off
  124. Setup go version spec 1.27.1
  125. Attempting to download 1.27.1...
  126. matching 1.27.1...
  127. Acquiring 1.27.1 from https://github.com/actions/go-versions/releases/download/1.27.1-33583469715/go-1.27.1-linux-x64.tar.gz
  128. Extracting Go...
  129. [command]/usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/4114f767-c4da-4a51-80dc-7297873c0fec -f /home/runner/work/_temp/db822e22-0232-4337-828f-24231d8c42e7
  130. Successfully extracted go to /home/runner/work/_temp/4114f767-c4da-4a51-80dc-7297873c0fec
  131. Adding to the cache ...
  132. Successfully cached go to /opt/hostedtoolcache/go/1.27.1/x64
  133. Added go to the path
  134. Successfully set up Go version 1.27.1
  135. [command]/opt/hostedtoolcache/go/1.27.1/x64/bin/go env GOCACHE
  136. [command]/opt/hostedtoolcache/go/1.27.1/x64/bin/go env GOMODCACHE
  137. /home/runner/.cache/go-build
  138. /home/runner/go/pkg/mod
  139. Cache is not found
  140. go version go1.27.1 linux/amd64
  142. go env
  143. AR='ar'
  144. CC='gcc'
  145. CGO_CFLAGS='-O2 -g'
  146. CGO_CPPFLAGS=''
  147. CGO_CXXFLAGS='-O2 -g'
  148. CGO_ENABLED='1'
  149. CGO_FFLAGS='-O2 -g'
  150. CGO_LDFLAGS='-O2 -g'
  151. CXX='g++'
  152. GCCGO='gccgo'
  153. GO111MODULE=''
  154. GOAMD64='v1'
  155. GOARCH='amd64'
  156. GOAUTH='netrc'
  157. GOBIN='/home/runner/go/bin'
  158. GOCACHE='/home/runner/.cache/go-build'
  159. GOCACHEPROG=''
  160. GODEBUG=''
  161. GOENV='/home/runner/.config/go/env'
  162. GOEXE=''
  163. GOEXPERIMENT=''
  164. GOFIPS140='off'
  165. GOFLAGS=''
  166. GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2417831428=/tmp/go-build -gno-record-gcc-switches'
  167. GOHOSTARCH='amd64'
  168. GOHOSTOS='linux'
  169. GOINSECURE=''
  170. GOMOD='/home/runner/work/ermite/ermite/go.mod'
  171. GOMODCACHE='/home/runner/go/pkg/mod'
  172. GONOPROXY=''
  173. GONOSUMDB=''
  174. GOOS='linux'
  175. GOPACKAGESDRIVER=''
  176. GOPATH='/home/runner/go'
  177. GOPRIVATE=''
  178. GOPROXY='https://proxy.golang.org,direct'
  179. GOROOT='/opt/hostedtoolcache/go/1.27.1/x64'
  180. GOSUMDB='sum.golang.org'
  181. GOTELEMETRY='local'
  182. GOTELEMETRYDIR='/home/runner/.config/go/telemetry'
  183. GOTMPDIR=''
  184. GOTOOLCHAIN='local'
  185. GOTOOLDIR='/opt/hostedtoolcache/go/1.27.1/x64/pkg/tool/linux_amd64'
  186. GOVCS=''
  187. GOVERSION='go1.27.1'
  188. GOWORK='off'
  189. PKG_CONFIG='pkg-config'
  192. Run golangci/golangci-lint-action@v9
  193. with:
  194. version: v2.14.0
  195. install-mode: binary
  196. install-only: false
  197. github-token: ***
  198. verify: true
  199. only-new-issues: false
  200. skip-cache: false
  201. skip-save-cache: false
  202. cache-invalidation-interval: 7
  203. problem-matchers: false
  204. env:
  205. GOWORK: off
  206. GOTOOLCHAIN: local
  208. Restore cache
  209. Checking for go.mod: go.mod
  210. Cache Size: ~5 MB (5215174 B)
  211. [command]/usr/bin/tar -xf /home/runner/work/_temp/ed253528-ee60-477d-a89c-983b1f7d63ac/cache.tgz -P -C /home/runner/work/ermite/ermite -z
  212. Cache restored successfully
  213. Restored cache for golangci-lint from key 'golangci-lint.cache-Linux-2963-de5d483f7308b615097bba2af98208fcba532e2a' in 1619ms
  215. Install
  216. Finding needed golangci-lint version...
  217. Installation mode: binary
  218. Installing golangci-lint binary v2.14.0...
  219. Downloading binary https://github.com/golangci/golangci-lint/releases/download/v2.14.0/golangci-lint-2.14.0-linux-amd64.tar.gz ...
  220. [command]/usr/bin/tar xz --overwrite --warning=no-unknown-keyword --overwrite -C /home/runner -f /home/runner/work/_temp/e615d815-40f7-43a5-bfe1-07a5c60ecc31
  221. Installed golangci-lint into /home/runner/golangci-lint-2.14.0-linux-amd64/golangci-lint in 562ms
  223. run golangci-lint
  224. Running [/home/runner/golangci-lint-2.14.0-linux-amd64/golangci-lint config path] in [/home/runner/work/ermite/ermite] ...
  225. Running [/home/runner/golangci-lint-2.14.0-linux-amd64/golangci-lint config verify] in [/home/runner/work/ermite/ermite] ...
  226. Running [/home/runner/golangci-lint-2.14.0-linux-amd64/golangci-lint run] in [/home/runner/work/ermite/ermite] ...
  227. internal/adapters/blobdisk/blobdisk.go:186:17: Error return value of `os.Remove` is not checked (errcheck)
  228. defer os.Remove(f.Name())
  229. ^
  230. internal/adapters/blobdisk/blobdisk.go:259:10: Error return value of `f.Close` is not checked (errcheck)
  231. f.Close()
  232. ^
  233. internal/adapters/blobdisk/blobdisk.go:367:15: Error return value of `os.RemoveAll` is not checked (errcheck)
  234. os.RemoveAll(stage)
  235. ^
  236. internal/adapters/blobdisk/blobdisk.go:371:15: Error return value of `os.RemoveAll` is not checked (errcheck)
  237. os.RemoveAll(stage)
  238. ^
  239. internal/adapters/blobdisk/blobdisk.go:375:15: Error return value of `os.RemoveAll` is not checked (errcheck)
  240. os.RemoveAll(u.dir())
  241. ^
  242. internal/adapters/blobdisk/blobdisk.go:399:12: Error return value of `os.Remove` is not checked (errcheck)
  243. os.Remove(f.Name())
  244. ^
  245. internal/adapters/blobdisk/blobdisk.go:415:17: Error return value of `os.Remove` is not checked (errcheck)
  246. defer os.Remove(f.Name())
  247. ^
  248. internal/adapters/blobdisk/blobdisk.go:456:11: Error return value of `f.Close` is not checked (errcheck)
  249. f.Close()
  250. ^
  251. internal/adapters/blobs3/blobs3_test.go:78:10: Error return value of `w.Write` is not checked (errcheck)
  252. w.Write([]byte(`<ListBucketResult xmlns="http://s3.amazonaws.com/doc/2006-03-01/"><Name>b</Name><IsTruncated>false</IsTruncated></ListBucketResult>`))
  253. ^
  254. internal/adapters/blobtest/suite.go:80:11: Error return value of `rc.Close` is not checked (errcheck)
  255. rc.Close()
  256. ^
  257. internal/adapters/blobtest/suite.go:98:11: Error return value of `r.Close` is not checked (errcheck)
  258. r.Close()
  259. ^
  260. internal/adapters/blobtest/suite.go:150:10: Error return value of `r.Close` is not checked (errcheck)
  261. r.Close()
  262. ^
  263. internal/adapters/kvstore/releases_test.go:109:16: Error return value of `db.Close` is not checked (errcheck)
  264. defer db.Close(ctx)
  265. ^
  266. internal/adapters/kvstore/store_test.go:408:18: Error return value of `db.Close` is not checked (errcheck)
  267. defer db.Close(ctx)
  268. ^
  269. internal/adapters/rpc/release_test.go:259:22: Error return value of `stream.Close` is not checked (errcheck)
  270. defer stream.Close()
  271. ^
  272. internal/adapters/rpc/release_test.go:288:23: Error return value of `stream.Close` is not checked (errcheck)
  273. defer stream.Close()
  274. ^
  275. internal/adapters/rpc/release_test.go:398:20: Error return value of `stream.Close` is not checked (errcheck)
  276. defer stream.Close()
  277. ^
  278. internal/app/release_e2e_test.go:79:18: Error return value of `res.Body.Close` is not checked (errcheck)
  279. res.Body.Close()
  280. ^
  281. internal/app/release_e2e_test.go:87:18: Error return value of `res.Body.Close` is not checked (errcheck)
  282. res.Body.Close()
  283. ^
  284. internal/app/web_release_test.go:47:23: Error return value of `res.Body.Close` is not checked (errcheck)
  285. defer res.Body.Close()
  286. ^
  287. internal/usecase/releases_assets.go:410:18: Error return value of `body.Close` is not checked (errcheck)
  288. defer body.Close()
  289. ^
  290. internal/usecase/releases_github_test.go:310:24: Error return value of `resp.Body.Close` is not checked (errcheck)
  291. defer resp.Body.Close()
  292. ^
  293. internal/app/cli_release.go:592:22: QF1001: could apply De Morgan's law (staticcheck)
  294. if attempt == 1 || !(code == connect.CodeUnavailable || code == connect.CodeInternal || errors.Is(err, io.ErrUnexpectedEOF)) {
  295. ^
  296. internal/usecase/releases_assets.go:69:7: QF1001: could apply De Morgan's law (staticcheck)
  297. if !(old.State == domain.ReleaseAssetUploading && r.clock.Now().Sub(old.UpdatedAt) > 60*time.Second) && !(old.State == domain.ReleaseAssetUploaded && params.Replace) {
  298. ^
  299. internal/usecase/releases_assets.go:202:6: QF1001: could apply De Morgan's law (staticcheck)
  300. if !(c >= '0' && c <= '9' || c >= 'a' && c <= 'f') {
  301. ^
  302. internal/usecase/releases_sweep.go:32:3: QF1003: could use tagged switch on a.State (staticcheck)
  303. if a.State == domain.ReleaseAssetUploading {
  304. ^
  305. 26 issues:
  306. * errcheck: 22
  307. * staticcheck: 4
  309. issues found
  310. Ran golangci-lint in 67098ms
  312. Post job cleanup.
  313. [command]/usr/bin/tar --posix -cf cache.tgz --exclude cache.tgz -P -C /home/runner/work/ermite/ermite --files-from manifest.txt -z
  314. Cache Size: ~6 MB (5833664 B)
  315. Cache saved successfully
  316. Saved cache for golangci-lint from paths '/home/runner/.cache/golangci-lint' in 1171ms
  317. Post job cleanup.
  318. [command]/usr/bin/git version
  319. git version 2.53.0
  320. Temporarily overriding HOME='/home/runner/work/_temp/769c06f2-6bf2-4706-87d8-eb5696d2961d' before making global git config changes
  321. Adding repository directory to the temporary git global config as a safe directory
  322. [command]/usr/bin/git config --global --add safe.directory /home/runner/work/ermite/ermite
  323. Removing SSH command configuration
  324. [command]/usr/bin/git config --local --name-only --get-regexp core\.sshCommand
  325. [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
  326. Removing HTTP extra header
  327. [command]/usr/bin/git config --local --name-only --get-regexp http\.http\:\/\/ermite\:7341\/\.extraheader
  328. [command]/usr/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'http\.http\:\/\/ermite\:7341\/\.extraheader' && git config --local --unset-all 'http.http://ermite:7341/.extraheader' || :"
  329. Removing includeIf entries pointing to credentials config files
  330. [command]/usr/bin/git config --local --name-only --get-regexp ^includeIf\.gitdir:
  331. includeif.gitdir:/home/runner/work/ermite/ermite/.git.path
  332. includeif.gitdir:/home/runner/work/ermite/ermite/.git/worktrees/*.path
  333. includeif.gitdir:/github/workspace/.git.path
  334. includeif.gitdir:/github/workspace/.git/worktrees/*.path
  335. [command]/usr/bin/git config --local --get-all includeif.gitdir:/home/runner/work/ermite/ermite/.git.path
  336. /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  337. [command]/usr/bin/git config --local --unset includeif.gitdir:/home/runner/work/ermite/ermite/.git.path /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  338. [command]/usr/bin/git config --local --get-all includeif.gitdir:/home/runner/work/ermite/ermite/.git/worktrees/*.path
  339. /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  340. [command]/usr/bin/git config --local --unset includeif.gitdir:/home/runner/work/ermite/ermite/.git/worktrees/*.path /home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  341. [command]/usr/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git.path
  342. /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  343. [command]/usr/bin/git config --local --unset includeif.gitdir:/github/workspace/.git.path /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  344. [command]/usr/bin/git config --local --get-all includeif.gitdir:/github/workspace/.git/worktrees/*.path
  345. /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  346. [command]/usr/bin/git config --local --unset includeif.gitdir:/github/workspace/.git/worktrees/*.path /github/runner_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config
  347. [command]/usr/bin/git submodule foreach --recursive git config --local --show-origin --name-only --get-regexp remote.origin.url
  348. Removing credentials config '/home/runner/work/_temp/git-credentials-56e1270c-4321-4d7d-b578-7bbee9085f91.config'
  349. Cleaning up orphan processes

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 2

Tags 44

↑↓ moveenter openesc close