1// SPDX-License-Identifier: AGPL-3.0-or-later
2
3package usecase
4
5import (
6 "context"
7 "errors"
8 "fmt"
9 "strconv"
10 "strings"
11 "sync"
12 "time"
13
14 "github.com/bnema/zerowrap"
15
16 "bnema.dev/ermite/internal/domain"
17 "bnema.dev/ermite/internal/ports"
18)
19
20// DefaultEventBuffer is the number of events the Events use case remembers.
21const DefaultEventBuffer = 1024
22
23// Limits of the watchers.
24const (
25 // MaxWatchTopics is the most topics one watch may follow.
26 MaxWatchTopics = 64
27 // MaxWatchers is the most watches in progress at once.
28 MaxWatchers = 256
29 // MaxWatchersPerClient is the most watches in progress for one client
30 // address (see ports.WatchParams.Client).
31 MaxWatchersPerClient = 16
32 // DefaultRevalidateEvery is how long a watcher with a stored token goes
33 // without asking the token store whether the token still exists.
34 DefaultRevalidateEvery = 5 * time.Second
35)
36
37// Topics a watcher may follow.
38const (
39 // TopicHome follows every repository the caller may see.
40 TopicHome = "home"
41 // TopicOwner follows the merge requests and issues of every repository,
42 // for the owner only (the inbox). Anyone else is told it is an unknown
43 // topic.
44 TopicOwner = "owner"
45 // topicRepoPrefix starts the topic of one repository: "repo:<name>".
46 topicRepoPrefix = "repo:"
47)
48
49// bufferedEvent is an event with its sequence number in the buffer, and what
50// was true of its repository when it was buffered. Access to an event is
51// decided from that, and from the repository as it is when the event is
52// delivered: a repository made public later does not reveal what happened
53// while it was private, and a repository deleted and created again under the
54// same name does not inherit the events of the old one.
55type bufferedEvent struct {
56 seq uint64
57 ev domain.Event
58
59 // known is false when the repository did not exist any more when the
60 // event was buffered: nobody is told about it.
61 known bool
62 // vis is the visibility of the repository at that time.
63 vis domain.Visibility
64 // created is the creation time of that repository.
65 created time.Time
66}
67
68// Events keeps the last events of the bus in a ring buffer, numbers them, and
69// lets callers watch them: live, or replayed from the id of the last event
70// they saw. Events of a private repository only reach callers that may read
71// it, checked again for every event.
72//
73// Event ids are opaque to clients: "<boot>-<seq>", where boot identifies this
74// run of the server, so that an id from before a restart is unknown rather
75// than taken for a newer event.
76//
77// The goroutine that feeds the buffer uses the logger of the context given to
78// NewEvents and lives until Close.
79type Events struct {
80 repos *Repos
81 auth ports.Revalidator
82 clock ports.Clock
83 boot string
84 size int
85 every time.Duration // see EventsConfig.RevalidateEvery
86
87 stop context.CancelFunc
88 done chan struct{}
89
90 mu sync.Mutex
91 ring []bufferedEvent // capacity size, oldest first
92 nextSeq uint64 // sequence number of the next event, from 1
93 changed chan struct{} // closed and replaced on every append and on close
94 closed bool
95 watches int
96 clients map[string]int // watches in progress by client
97}
98
99var _ ports.EventService = (*Events)(nil)
100
101// EventsConfig configures Events.
102type EventsConfig struct {
103 // Size is the number of events remembered; DefaultEventBuffer when not
104 // positive.
105 Size int
106 // Auth confirms that the token of a watcher still exists. Required.
107 Auth ports.Revalidator
108 // RevalidateEvery is how long the answer of Auth is kept for a watcher;
109 // DefaultRevalidateEvery when zero, and negative to ask for every event.
110 RevalidateEvery time.Duration
111}
112
113// NewEvents subscribes to the bus and starts remembering its events. ctx
114// carries the logger; its cancellation is not followed, call Close.
115func NewEvents(ctx context.Context, repos *Repos, bus ports.EventBus, clock ports.Clock, cfg EventsConfig) *Events {
116 size := cfg.Size
117 if size <= 0 {
118 size = DefaultEventBuffer
119 }
120 every := cfg.RevalidateEvery
121 if every == 0 {
122 every = DefaultRevalidateEvery
123 }
124 run, stop := context.WithCancel(context.WithoutCancel(ctx))
125 e := &Events{
126 repos: repos,
127 auth: cfg.Auth,
128 clock: clock,
129 every: every,
130 clients: make(map[string]int),
131 boot: strconv.FormatInt(clock.Now().UnixMilli(), 36),
132 size: size,
133 stop: stop,
134 done: make(chan struct{}),
135 nextSeq: 1,
136 changed: make(chan struct{}),
137 }
138 sub := bus.Subscribe(run) // before returning: nothing published after is missed
139 go e.feed(run, sub)
140 return e
141}
142
143// feed appends the events of the bus until it stops.
144func (e *Events) feed(ctx context.Context, sub <-chan domain.Event) {
145 defer close(e.done)
146 defer e.shutdown()
147 for {
148 select {
149 case ev, ok := <-sub:
150 if !ok {
151 return
152 }
153 e.append(ctx, ev)
154 case <-ctx.Done():
155 return
156 }
157 }
158}
159
160// snapshot records the visibility and the generation of the repository an
161// event is about. Every event of the repository carries them.
162func (e *Events) snapshot(ctx context.Context, ev domain.Event) bufferedEvent {
163 switch ev := ev.(type) {
164 case domain.RepoCreated:
165 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.At}
166 case domain.RepoUpdated:
167 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
168 case domain.RepoDeleted:
169 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
170 case domain.PushEvent:
171 if ev.CreatedAt.IsZero() {
172 return bufferedEvent{} // repository unknown at publish time: nobody is told
173 }
174 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
175 case domain.MergeRequestOpened:
176 return repoSnapshot(ev.Visibility, ev.CreatedAt)
177 case domain.MergeRequestMerged:
178 return repoSnapshot(ev.Visibility, ev.CreatedAt)
179 case domain.MergeRequestClosed:
180 return repoSnapshot(ev.Visibility, ev.CreatedAt)
181 case domain.MergeRequestReady:
182 return repoSnapshot(ev.Visibility, ev.CreatedAt)
183 case domain.CommentAdded:
184 return repoSnapshot(ev.Visibility, ev.CreatedAt)
185 case domain.IssueOpened:
186 return repoSnapshot(ev.Visibility, ev.CreatedAt)
187 case domain.IssueClosed:
188 return repoSnapshot(ev.Visibility, ev.CreatedAt)
189 case domain.IssueReopened:
190 return repoSnapshot(ev.Visibility, ev.CreatedAt)
191 case domain.IssueCommented:
192 return repoSnapshot(ev.Visibility, ev.CreatedAt)
193 case domain.IssueSubmitted, domain.IssuePendingRemoved:
194 return bufferedEvent{known: true} // owner topic only: no repository snapshot
195 case domain.CommentEdited:
196 return repoSnapshot(ev.Visibility, ev.CreatedAt)
197 case domain.CommentDeleted:
198 return repoSnapshot(ev.Visibility, ev.CreatedAt)
199 case domain.CommentResolved:
200 return repoSnapshot(ev.Visibility, ev.CreatedAt)
201 case domain.RunUpdated:
202 return repoSnapshot(ev.Visibility, ev.CreatedAt)
203 case domain.JobUpdated:
204 return repoSnapshot(ev.Visibility, ev.CreatedAt)
205 }
206 return bufferedEvent{known: true}
207}
208
209// repoSnapshot is the snapshot of an event that carries the visibility and the
210// creation time of its repository; a zero creation time means the repository
211// was unknown when it was published, and nobody is told.
212func repoSnapshot(vis domain.Visibility, created time.Time) bufferedEvent {
213 if created.IsZero() {
214 return bufferedEvent{}
215 }
216 return bufferedEvent{known: true, vis: vis, created: created}
217}
218
219func (e *Events) append(ctx context.Context, ev domain.Event) {
220 be := e.snapshot(ctx, ev) // outside the lock: it reads the store
221 e.mu.Lock()
222 defer e.mu.Unlock()
223 if len(e.ring) == e.size {
224 copy(e.ring, e.ring[1:])
225 e.ring = e.ring[:e.size-1]
226 }
227 be.seq, be.ev = e.nextSeq, ev
228 e.ring = append(e.ring, be)
229 e.nextSeq++
230 e.wake()
231}
232
233// wake releases the watchers waiting for news. The caller holds mu.
234func (e *Events) wake() {
235 close(e.changed)
236 e.changed = make(chan struct{})
237}
238
239func (e *Events) shutdown() {
240 e.mu.Lock()
241 defer e.mu.Unlock()
242 if !e.closed {
243 e.closed = true
244 e.wake()
245 }
246}
247
248// Close ends every watch cleanly, stops feeding and waits for the feeder,
249// until ctx ends. It is safe to call more than once.
250func (e *Events) Close(ctx context.Context) {
251 e.stop()
252 select {
253 case <-e.done:
254 case <-ctx.Done():
255 }
256}
257
258// Watchers returns the number of watches in progress.
259func (e *Events) Watchers() int {
260 e.mu.Lock()
261 defer e.mu.Unlock()
262 return e.watches
263}
264
265func (e *Events) id(seq uint64) string { return e.boot + "-" + strconv.FormatUint(seq, 10) }
266
267// parseID returns the sequence number of an id of this run.
268func (e *Events) parseID(id string) (uint64, bool) {
269 boot, seq, ok := strings.Cut(id, "-")
270 if !ok || boot != e.boot {
271 return 0, false
272 }
273 n, err := strconv.ParseUint(seq, 10, 64)
274 return n, err == nil && n > 0
275}
276
277// watch is the state of one Watch call.
278type watch struct {
279 p domain.Principal
280 home bool
281 owner bool // the owner topic: merge request, issue, repo update and deletion events of every repository
282 repos map[domain.RepoName]bool
283
284 checked time.Time // when the token store last confirmed the principal
285}
286
287func (w *watch) wants(name domain.RepoName) bool { return w.home || w.repos[name] }
288
289// wantsEvent is wants for an event: the owner topic also follows the events
290// about merge requests and issues of every repository.
291func (w *watch) wantsEvent(name domain.RepoName, ev domain.Event) bool {
292 return w.wants(name) || (w.owner && (isItemEvent(ev) || isRepoLifecycleEvent(ev)))
293}
294
295// parseTopics validates the topics of a watch. A repository topic needs a
296// repository the principal may read (else domain.ErrNotFound); an unknown
297// topic, or more than MaxWatchTopics, is domain.ErrInvalid.
298func (e *Events) parseTopics(ctx context.Context, p domain.Principal, topics []string) (*watch, error) {
299 if len(topics) > MaxWatchTopics {
300 return nil, fmt.Errorf("%w: %d topics, at most %d", domain.ErrInvalid, len(topics), MaxWatchTopics)
301 }
302 w := &watch{p: p, repos: make(map[domain.RepoName]bool), checked: time.Now()}
303 if len(topics) == 0 {
304 w.home = true
305 }
306 for _, t := range topics {
307 if t == TopicHome {
308 w.home = true
309 continue
310 }
311 if t == TopicOwner && p.HasOwnerRights() {
312 w.owner = true
313 continue
314 }
315 raw, ok := strings.CutPrefix(t, topicRepoPrefix)
316 if !ok {
317 // Includes "owner" for anyone but the owner: the same error as
318 // any unknown topic.
319 return nil, fmt.Errorf("%w: unknown topic %q (want %q or \"repo:<name>\")", domain.ErrInvalid, t, TopicHome)
320 }
321 name, err := domain.ParseRepoName(raw)
322 if err != nil {
323 return nil, err
324 }
325 if _, err := e.repos.Get(ctx, p, name); err != nil {
326 return nil, err
327 }
328 w.repos[name] = true
329 }
330 return w, nil
331}
332
333// Watch calls send for the events the principal may see until ctx ends, the
334// buffer closes (both return nil) or send fails (its error is returned).
335//
336// A principal with a stored token is checked again for every event, and every
337// few seconds when idle: when the token expired or was revoked the watch ends
338// with domain.ErrUnauthenticated and nothing more is sent. More watches than
339// MaxWatchers, or than MaxWatchersPerClient for one Client, give
340// domain.ErrResourceExhausted.
341//
342// Without ResumeAfter only new events are sent. With it, the buffered events
343// after that id are sent first, then new ones. When the id is no longer
344// buffered, or was not issued by this run, a gap comes first and the oldest
345// buffered event follows. A watcher that falls more than the buffer behind
346// gets a gap too, and carries on with the oldest buffered event.
347func (e *Events) Watch(ctx context.Context, p domain.Principal, params ports.WatchParams, send func(ports.WatchEvent) error) error {
348 w, err := e.parseTopics(ctx, p, params.Topics)
349 if err != nil {
350 return err
351 }
352
353 e.mu.Lock()
354 next := e.nextSeq // only new events
355 gap := false
356 if params.ResumeAfter != "" {
357 seq, ok := e.parseID(params.ResumeAfter)
358 oldest := e.nextSeq - uint64(len(e.ring)) // first buffered sequence, nextSeq when empty
359 switch {
360 case ok && seq >= oldest-1 && seq < e.nextSeq:
361 next = seq + 1
362 default:
363 next, gap = oldest, true
364 }
365 }
366 if e.watches >= MaxWatchers || (params.Client != "" && e.clients[params.Client] >= MaxWatchersPerClient) {
367 e.mu.Unlock()
368 return fmt.Errorf("%w: too many watchers", domain.ErrResourceExhausted)
369 }
370 e.watches++
371 if params.Client != "" {
372 e.clients[params.Client]++
373 }
374 e.mu.Unlock()
375 defer func() {
376 e.mu.Lock()
377 e.watches--
378 if params.Client != "" {
379 if e.clients[params.Client]--; e.clients[params.Client] == 0 {
380 delete(e.clients, params.Client)
381 }
382 }
383 e.mu.Unlock()
384 }()
385
386 if params.Ready != nil {
387 params.Ready()
388 }
389 log := zerowrap.FromCtx(ctx)
390 log.Debug().Strs("topics", params.Topics).Bool("resume", params.ResumeAfter != "").Bool("gap", gap).Msg("watch started")
391 if gap {
392 if err := send(ports.WatchEvent{Gap: true}); err != nil {
393 return err
394 }
395 }
396 for {
397 if err := e.stillAllowed(ctx, w); err != nil {
398 return err
399 }
400 batch, changed, oldest, lost, closed := e.since(next)
401 if lost {
402 if err := send(ports.WatchEvent{Gap: true}); err != nil {
403 return err
404 }
405 next = oldest
406 continue
407 }
408 for _, be := range batch {
409 if err := e.deliver(ctx, w, be, send); err != nil {
410 return err
411 }
412 next = be.seq + 1
413 }
414 if len(batch) > 0 {
415 continue
416 }
417 if closed {
418 return nil
419 }
420 e.wait(ctx, w, changed)
421 if ctx.Err() != nil {
422 return nil
423 }
424 }
425}
426
427// wait blocks until more events arrive or ctx ends. A watcher with a stored
428// token also wakes up every few seconds, so that a revocation ends the watch
429// of a quiet forge too (the caller checks the token on the next turn).
430func (e *Events) wait(ctx context.Context, w *watch, changed <-chan struct{}) {
431 var idle <-chan time.Time
432 if w.p.TokenID() != "" {
433 t := time.NewTimer(e.idleCheck())
434 defer t.Stop()
435 idle = t.C
436 }
437 select {
438 case <-changed:
439 case <-idle:
440 case <-ctx.Done():
441 }
442}
443
444// idleCheck is how long a watcher with a stored token waits for news before
445// checking its token anyway.
446func (e *Events) idleCheck() time.Duration {
447 if e.every <= 0 {
448 return DefaultRevalidateEvery
449 }
450 return min(e.every, DefaultRevalidateEvery)
451}
452
453// stillAllowed checks that the holder of a stored token may still watch: the
454// token has not expired and, at most every few seconds, still exists. Root and
455// anonymous callers have nothing to lose. The owner topic needs nothing more:
456// a stored token with owner rights loses them only by ceasing to exist, which
457// is checked here, and the owner's web session, which this use case cannot see,
458// is checked by the web adapter before it sends anything.
459func (e *Events) stillAllowed(ctx context.Context, w *watch) error {
460 if w.p.TokenID() == "" {
461 return nil
462 }
463 if exp := w.p.ExpiresAt(); !exp.IsZero() && !e.clock.Now().Before(exp) {
464 return domain.ErrUnauthenticated
465 }
466 if e.every > 0 && time.Since(w.checked) < e.every {
467 return nil
468 }
469 if err := e.auth.Revalidate(ctx, w.p); err != nil {
470 if ctx.Err() != nil {
471 return nil
472 }
473 return err
474 }
475 w.checked = time.Now()
476 return nil
477}
478
479// since returns the buffered events from sequence next on, and the channel
480// that closes when more arrive. lost is true when next fell out of the buffer;
481// the caller then restarts from oldest, the first buffered sequence. The
482// returned slice is a copy.
483func (e *Events) since(next uint64) (batch []bufferedEvent, changed <-chan struct{}, oldest uint64, lost, closed bool) {
484 e.mu.Lock()
485 defer e.mu.Unlock()
486 oldest = e.nextSeq - uint64(len(e.ring))
487 if next < oldest {
488 return nil, e.changed, oldest, true, e.closed
489 }
490 batch = append(batch, e.ring[next-oldest:]...)
491 return batch, e.changed, oldest, false, e.closed
492}
493
494// deliver sends the event if the watcher follows its topic and may see it.
495func (e *Events) deliver(ctx context.Context, w *watch, be bufferedEvent, send func(ports.WatchEvent) error) error {
496 if err := e.stillAllowed(ctx, w); err != nil {
497 return err
498 }
499 out := ports.WatchEvent{ID: e.id(be.seq), Event: be.ev}
500 switch ev := be.ev.(type) {
501 case domain.EventGap:
502 // The feeder lost events: tell every watcher.
503 return send(ports.WatchEvent{Gap: true})
504 case domain.RepoDeleted:
505 // The repository is gone: use the visibility it had.
506 if !w.wantsEvent(ev.Repo, ev) || !canReadAs(w.p, ev.Repo, ev.Visibility) {
507 return nil
508 }
509 return send(out)
510 case domain.IssueSubmitted:
511 return e.deliverOwnerOnly(ctx, w, ev.Repo, out, send)
512 case domain.IssuePendingRemoved:
513 return e.deliverOwnerOnly(ctx, w, ev.Repo, out, send)
514 case domain.RepoCreated:
515 return e.deliverRepo(ctx, w, ev.Repo, true, be, out, send)
516 case domain.RepoUpdated:
517 return e.deliverRepo(ctx, w, ev.Repo, true, be, out, send)
518 case domain.PushEvent:
519 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
520 case domain.MergeRequestOpened:
521 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
522 case domain.MergeRequestMerged:
523 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
524 case domain.MergeRequestClosed:
525 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
526 case domain.MergeRequestReady:
527 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
528 case domain.CommentAdded:
529 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
530 case domain.IssueOpened:
531 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
532 case domain.IssueClosed:
533 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
534 case domain.IssueReopened:
535 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
536 case domain.IssueCommented:
537 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
538 case domain.CommentEdited:
539 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
540 case domain.CommentDeleted:
541 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
542 case domain.CommentResolved:
543 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
544 case domain.RunUpdated:
545 // Home shows the CI state of each repository.
546 return e.deliverRepo(ctx, w, ev.Run.Repo, false, be, out, send)
547 case domain.JobUpdated:
548 // Home gets a job when it ends only: a failed job turns the state to
549 // failing before its run ends. Its progress stays on the topic of its
550 // repository.
551 if !w.repos[ev.Job.Repo] && ev.Job.Phase != domain.CIPhaseEnded {
552 return nil
553 }
554 return e.deliverRepo(ctx, w, ev.Job.Repo, false, be, out, send)
555 }
556 return nil // an event this version does not stream
557}
558
559// deliverOwnerOnly sends an owner-topic event: never home, never a repository
560// topic, not even to an owner who watches the repository. No content travels.
561func (e *Events) deliverOwnerOnly(ctx context.Context, w *watch, name domain.RepoName, out ports.WatchEvent, send func(ports.WatchEvent) error) error {
562 if !w.owner {
563 return nil
564 }
565 repo, err := lookupRepo(ctx, e.repos.meta, name)
566 switch {
567 case errors.Is(err, domain.ErrNotFound), ctx.Err() != nil:
568 return nil
569 case err != nil:
570 return fmt.Errorf("check access to %q: %w", name, err)
571 }
572 if repo.Settings.Issues.OrDefault() == domain.IssuesOff {
573 return nil
574 }
575 return send(out)
576}
577
578// deliverRepo sends an event about a repository if the watcher could read the
579// repository when the event happened and can read it now, and the repository
580// is still the one the event is about. A repository that no longer exists is
581// skipped: its RepoDeleted follows or came before.
582//
583// The exception is a repository that became private: the watchers who could
584// read it before are told once, with its name and its new visibility only,
585// so that what they show can be removed.
586func (e *Events) deliverRepo(ctx context.Context, w *watch, name domain.RepoName, withRepo bool, be bufferedEvent, out ports.WatchEvent, send func(ports.WatchEvent) error) error {
587 if !w.wantsEvent(name, be.ev) || !be.known {
588 return nil
589 }
590 repo, err := lookupRepo(ctx, e.repos.meta, name)
591 switch {
592 case errors.Is(err, domain.ErrNotFound):
593 return nil
594 case ctx.Err() != nil:
595 return nil
596 case err != nil:
597 return fmt.Errorf("check access to %q: %w", name, err)
598 }
599 if repo.CreatedAt.After(be.created) {
600 return nil // the event is about a repository of this name that was deleted
601 }
602 if !canReadAs(w.p, name, be.vis) {
603 if up, ok := be.ev.(domain.RepoUpdated); ok && canReadAs(w.p, name, up.Previous) {
604 out.Repo = &ports.RepoView{Repo: domain.Repo{Name: name, Visibility: up.Visibility}}
605 return send(out)
606 }
607 return nil
608 }
609 if !canRead(w.p, repo) {
610 return nil
611 }
612 if isIssueEvent(be.ev) && repo.Settings.Issues.OrDefault() == domain.IssuesOff {
613 return nil // issues were turned off since: a replay must not show them
614 }
615 if withRepo {
616 view, err := e.repos.View(ctx, repo)
617 if err != nil {
618 return err
619 }
620 out.Repo = &view
621 }
622 return send(out)
623}
624
625// isIssueEvent reports whether ev is about an issue.
626func isIssueEvent(ev domain.Event) bool {
627 switch ev.(type) {
628 case domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented:
629 return true
630 }
631 return false
632}
633
634// isRepoLifecycleEvent reports whether ev is a repository update or deletion:
635// the owner topic follows them, for they change what the inbox lists.
636func isRepoLifecycleEvent(ev domain.Event) bool {
637 switch ev.(type) {
638 case domain.RepoUpdated, domain.RepoDeleted:
639 return true
640 }
641 return false
642}
643
644// isItemEvent reports whether ev is about a merge request or an issue.
645func isItemEvent(ev domain.Event) bool {
646 switch ev.(type) {
647 case domain.MergeRequestOpened, domain.MergeRequestMerged, domain.MergeRequestClosed,
648 domain.MergeRequestReady, domain.CommentAdded,
649 domain.CommentEdited, domain.CommentDeleted, domain.CommentResolved:
650 return true
651 }
652 return isIssueEvent(ev)
653}