1// SPDX-License-Identifier: AGPL-3.0-or-later
2
3package usecase
4
5import (
6 "context"
7 "errors"
8 "fmt"
9 "strconv"
10 "strings"
11 "sync"
12 "time"
13
14 "github.com/bnema/zerowrap"
15
16 "bnema.dev/ermite/internal/domain"
17 "bnema.dev/ermite/internal/ports"
18)
19
20// DefaultEventBuffer is the number of events the Events use case remembers.
21const DefaultEventBuffer = 1024
22
23// Limits of the watchers.
24const (
25 // MaxWatchTopics is the most topics one watch may follow.
26 MaxWatchTopics = 64
27 // MaxWatchers is the most watches in progress at once.
28 MaxWatchers = 256
29 // MaxWatchersPerClient is the most watches in progress for one client
30 // address (see ports.WatchParams.Client).
31 MaxWatchersPerClient = 16
32 // DefaultRevalidateEvery is how long a watcher with a stored token goes
33 // without asking the token store whether the token still exists.
34 DefaultRevalidateEvery = 5 * time.Second
35)
36
37// Topics a watcher may follow.
38const (
39 // TopicHome follows every repository the caller may see.
40 TopicHome = "home"
41 // TopicOwner follows the merge requests and issues of every repository,
42 // for the owner only (the inbox). Anyone else is told it is an unknown
43 // topic.
44 TopicOwner = "owner"
45 // topicRepoPrefix starts the topic of one repository: "repo:<name>".
46 topicRepoPrefix = "repo:"
47)
48
49// bufferedEvent is an event with its sequence number in the buffer, and what
50// was true of its repository when it was buffered. Access to an event is
51// decided from that, and from the repository as it is when the event is
52// delivered: a repository made public later does not reveal what happened
53// while it was private, and a repository deleted and created again under the
54// same name does not inherit the events of the old one.
55type bufferedEvent struct {
56 seq uint64
57 ev domain.Event
58
59 // known is false when the repository did not exist any more when the
60 // event was buffered: nobody is told about it.
61 known bool
62 // vis is the visibility of the repository at that time.
63 vis domain.Visibility
64 // created is the creation time of that repository.
65 created time.Time
66}
67
68// Events keeps the last events of the bus in a ring buffer, numbers them, and
69// lets callers watch them: live, or replayed from the id of the last event
70// they saw. Events of a private repository only reach callers that may read
71// it, checked again for every event.
72//
73// Event ids are opaque to clients: "<boot>-<seq>", where boot identifies this
74// run of the server, so that an id from before a restart is unknown rather
75// than taken for a newer event.
76//
77// The goroutine that feeds the buffer uses the logger of the context given to
78// NewEvents and lives until Close.
79type Events struct {
80 repos *Repos
81 auth ports.Revalidator
82 clock ports.Clock
83 boot string
84 size int
85 every time.Duration // see EventsConfig.RevalidateEvery
86
87 stop context.CancelFunc
88 done chan struct{}
89
90 mu sync.Mutex
91 ring []bufferedEvent // capacity size, oldest first
92 nextSeq uint64 // sequence number of the next event, from 1
93 changed chan struct{} // closed and replaced on every append and on close
94 closed bool
95 watches int
96 clients map[string]int // watches in progress by client
97}
98
99var _ ports.EventService = (*Events)(nil)
100
101// EventsConfig configures Events.
102type EventsConfig struct {
103 // Size is the number of events remembered; DefaultEventBuffer when not
104 // positive.
105 Size int
106 // Auth confirms that the token of a watcher still exists. Required.
107 Auth ports.Revalidator
108 // RevalidateEvery is how long the answer of Auth is kept for a watcher;
109 // DefaultRevalidateEvery when zero, and negative to ask for every event.
110 RevalidateEvery time.Duration
111}
112
113// NewEvents subscribes to the bus and starts remembering its events. ctx
114// carries the logger; its cancellation is not followed, call Close.
115func NewEvents(ctx context.Context, repos *Repos, bus ports.EventBus, clock ports.Clock, cfg EventsConfig) *Events {
116 size := cfg.Size
117 if size <= 0 {
118 size = DefaultEventBuffer
119 }
120 every := cfg.RevalidateEvery
121 if every == 0 {
122 every = DefaultRevalidateEvery
123 }
124 run, stop := context.WithCancel(context.WithoutCancel(ctx))
125 e := &Events{
126 repos: repos,
127 auth: cfg.Auth,
128 clock: clock,
129 every: every,
130 clients: make(map[string]int),
131 boot: strconv.FormatInt(clock.Now().UnixMilli(), 36),
132 size: size,
133 stop: stop,
134 done: make(chan struct{}),
135 nextSeq: 1,
136 changed: make(chan struct{}),
137 }
138 sub := bus.Subscribe(run) // before returning: nothing published after is missed
139 go e.feed(run, sub)
140 return e
141}
142
143// feed appends the events of the bus until it stops.
144func (e *Events) feed(ctx context.Context, sub <-chan domain.Event) {
145 defer close(e.done)
146 defer e.shutdown()
147 for {
148 select {
149 case ev, ok := <-sub:
150 if !ok {
151 return
152 }
153 e.append(ctx, ev)
154 case <-ctx.Done():
155 return
156 }
157 }
158}
159
160// snapshot records the visibility and the generation of the repository an
161// event is about. Every event of the repository carries them.
162func (e *Events) snapshot(ctx context.Context, ev domain.Event) bufferedEvent {
163 switch ev := ev.(type) {
164 case domain.RepoCreated:
165 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.At}
166 case domain.RepoUpdated:
167 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
168 case domain.RepoDeleted:
169 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
170 case domain.PushEvent:
171 if ev.CreatedAt.IsZero() {
172 return bufferedEvent{} // repository unknown at publish time: nobody is told
173 }
174 return bufferedEvent{known: true, vis: ev.Visibility, created: ev.CreatedAt}
175 case domain.MergeRequestOpened:
176 return repoSnapshot(ev.Visibility, ev.CreatedAt)
177 case domain.MergeRequestMerged:
178 return repoSnapshot(ev.Visibility, ev.CreatedAt)
179 case domain.MergeRequestClosed:
180 return repoSnapshot(ev.Visibility, ev.CreatedAt)
181 case domain.MergeRequestReady:
182 return repoSnapshot(ev.Visibility, ev.CreatedAt)
183 case domain.CommentAdded:
184 return repoSnapshot(ev.Visibility, ev.CreatedAt)
185 case domain.IssueOpened:
186 return repoSnapshot(ev.Visibility, ev.CreatedAt)
187 case domain.IssueClosed:
188 return repoSnapshot(ev.Visibility, ev.CreatedAt)
189 case domain.IssueReopened:
190 return repoSnapshot(ev.Visibility, ev.CreatedAt)
191 case domain.IssueCommented:
192 return repoSnapshot(ev.Visibility, ev.CreatedAt)
193 case domain.IssueSubmitted, domain.IssuePendingRemoved:
194 return bufferedEvent{known: true} // owner topic only: no repository snapshot
195 case domain.CommentEdited:
196 return repoSnapshot(ev.Visibility, ev.CreatedAt)
197 case domain.CommentDeleted:
198 return repoSnapshot(ev.Visibility, ev.CreatedAt)
199 case domain.CommentResolved:
200 return repoSnapshot(ev.Visibility, ev.CreatedAt)
201 case domain.MergeRequestMergeability:
202 return repoSnapshot(ev.Visibility, ev.CreatedAt)
203 case domain.RunUpdated:
204 return repoSnapshot(ev.Visibility, ev.CreatedAt)
205 case domain.JobUpdated:
206 return repoSnapshot(ev.Visibility, ev.CreatedAt)
207 }
208 return bufferedEvent{known: true}
209}
210
211// repoSnapshot is the snapshot of an event that carries the visibility and the
212// creation time of its repository; a zero creation time means the repository
213// was unknown when it was published, and nobody is told.
214func repoSnapshot(vis domain.Visibility, created time.Time) bufferedEvent {
215 if created.IsZero() {
216 return bufferedEvent{}
217 }
218 return bufferedEvent{known: true, vis: vis, created: created}
219}
220
221func (e *Events) append(ctx context.Context, ev domain.Event) {
222 be := e.snapshot(ctx, ev) // outside the lock: it reads the store
223 e.mu.Lock()
224 defer e.mu.Unlock()
225 if len(e.ring) == e.size {
226 copy(e.ring, e.ring[1:])
227 e.ring = e.ring[:e.size-1]
228 }
229 be.seq, be.ev = e.nextSeq, ev
230 e.ring = append(e.ring, be)
231 e.nextSeq++
232 e.wake()
233}
234
235// wake releases the watchers waiting for news. The caller holds mu.
236func (e *Events) wake() {
237 close(e.changed)
238 e.changed = make(chan struct{})
239}
240
241func (e *Events) shutdown() {
242 e.mu.Lock()
243 defer e.mu.Unlock()
244 if !e.closed {
245 e.closed = true
246 e.wake()
247 }
248}
249
250// Close ends every watch cleanly, stops feeding and waits for the feeder,
251// until ctx ends. It is safe to call more than once.
252func (e *Events) Close(ctx context.Context) {
253 e.stop()
254 select {
255 case <-e.done:
256 case <-ctx.Done():
257 }
258}
259
260// Watchers returns the number of watches in progress.
261func (e *Events) Watchers() int {
262 e.mu.Lock()
263 defer e.mu.Unlock()
264 return e.watches
265}
266
267func (e *Events) id(seq uint64) string { return e.boot + "-" + strconv.FormatUint(seq, 10) }
268
269// parseID returns the sequence number of an id of this run.
270func (e *Events) parseID(id string) (uint64, bool) {
271 boot, seq, ok := strings.Cut(id, "-")
272 if !ok || boot != e.boot {
273 return 0, false
274 }
275 n, err := strconv.ParseUint(seq, 10, 64)
276 return n, err == nil && n > 0
277}
278
279// watch is the state of one Watch call.
280type watch struct {
281 p domain.Principal
282 home bool
283 owner bool // the owner topic: merge request, issue, repo update and deletion events of every repository
284 repos map[domain.RepoName]bool
285
286 checked time.Time // when the token store last confirmed the principal
287}
288
289func (w *watch) wants(name domain.RepoName) bool { return w.home || w.repos[name] }
290
291// wantsEvent is wants for an event: the owner topic also follows the events
292// about merge requests and issues of every repository.
293func (w *watch) wantsEvent(name domain.RepoName, ev domain.Event) bool {
294 return w.wants(name) || (w.owner && (isItemEvent(ev) || isRepoLifecycleEvent(ev)))
295}
296
297// parseTopics validates the topics of a watch. A repository topic needs a
298// repository the principal may read (else domain.ErrNotFound); an unknown
299// topic, or more than MaxWatchTopics, is domain.ErrInvalid.
300func (e *Events) parseTopics(ctx context.Context, p domain.Principal, topics []string) (*watch, error) {
301 if len(topics) > MaxWatchTopics {
302 return nil, fmt.Errorf("%w: %d topics, at most %d", domain.ErrInvalid, len(topics), MaxWatchTopics)
303 }
304 w := &watch{p: p, repos: make(map[domain.RepoName]bool), checked: time.Now()}
305 if len(topics) == 0 {
306 w.home = true
307 }
308 for _, t := range topics {
309 if t == TopicHome {
310 w.home = true
311 continue
312 }
313 if t == TopicOwner && p.HasOwnerRights() {
314 w.owner = true
315 continue
316 }
317 raw, ok := strings.CutPrefix(t, topicRepoPrefix)
318 if !ok {
319 // Includes "owner" for anyone but the owner: the same error as
320 // any unknown topic.
321 return nil, fmt.Errorf("%w: unknown topic %q (want %q or \"repo:<name>\")", domain.ErrInvalid, t, TopicHome)
322 }
323 name, err := domain.ParseRepoName(raw)
324 if err != nil {
325 return nil, err
326 }
327 if _, err := e.repos.Get(ctx, p, name); err != nil {
328 return nil, err
329 }
330 w.repos[name] = true
331 }
332 return w, nil
333}
334
335// Watch calls send for the events the principal may see until ctx ends, the
336// buffer closes (both return nil) or send fails (its error is returned).
337//
338// A principal with a stored token is checked again for every event, and every
339// few seconds when idle: when the token expired or was revoked the watch ends
340// with domain.ErrUnauthenticated and nothing more is sent. More watches than
341// MaxWatchers, or than MaxWatchersPerClient for one Client, give
342// domain.ErrResourceExhausted.
343//
344// Without ResumeAfter only new events are sent. With it, the buffered events
345// after that id are sent first, then new ones. When the id is no longer
346// buffered, or was not issued by this run, a gap comes first and the oldest
347// buffered event follows. A watcher that falls more than the buffer behind
348// gets a gap too, and carries on with the oldest buffered event.
349func (e *Events) Watch(ctx context.Context, p domain.Principal, params ports.WatchParams, send func(ports.WatchEvent) error) error {
350 w, err := e.parseTopics(ctx, p, params.Topics)
351 if err != nil {
352 return err
353 }
354
355 e.mu.Lock()
356 next := e.nextSeq // only new events
357 gap := false
358 if params.ResumeAfter != "" {
359 seq, ok := e.parseID(params.ResumeAfter)
360 oldest := e.nextSeq - uint64(len(e.ring)) // first buffered sequence, nextSeq when empty
361 switch {
362 case ok && seq >= oldest-1 && seq < e.nextSeq:
363 next = seq + 1
364 default:
365 next, gap = oldest, true
366 }
367 }
368 if e.watches >= MaxWatchers || (params.Client != "" && e.clients[params.Client] >= MaxWatchersPerClient) {
369 e.mu.Unlock()
370 return fmt.Errorf("%w: too many watchers", domain.ErrResourceExhausted)
371 }
372 e.watches++
373 if params.Client != "" {
374 e.clients[params.Client]++
375 }
376 e.mu.Unlock()
377 defer func() {
378 e.mu.Lock()
379 e.watches--
380 if params.Client != "" {
381 if e.clients[params.Client]--; e.clients[params.Client] == 0 {
382 delete(e.clients, params.Client)
383 }
384 }
385 e.mu.Unlock()
386 }()
387
388 if params.Ready != nil {
389 params.Ready()
390 }
391 log := zerowrap.FromCtx(ctx)
392 log.Debug().Strs("topics", params.Topics).Bool("resume", params.ResumeAfter != "").Bool("gap", gap).Msg("watch started")
393 if gap {
394 if err := send(ports.WatchEvent{Gap: true}); err != nil {
395 return err
396 }
397 }
398 for {
399 if err := e.stillAllowed(ctx, w); err != nil {
400 return err
401 }
402 batch, changed, oldest, lost, closed := e.since(next)
403 if lost {
404 if err := send(ports.WatchEvent{Gap: true}); err != nil {
405 return err
406 }
407 next = oldest
408 continue
409 }
410 for _, be := range batch {
411 if err := e.deliver(ctx, w, be, send); err != nil {
412 return err
413 }
414 next = be.seq + 1
415 }
416 if len(batch) > 0 {
417 continue
418 }
419 if closed {
420 return nil
421 }
422 e.wait(ctx, w, changed)
423 if ctx.Err() != nil {
424 return nil
425 }
426 }
427}
428
429// wait blocks until more events arrive or ctx ends. A watcher with a stored
430// token also wakes up every few seconds, so that a revocation ends the watch
431// of a quiet forge too (the caller checks the token on the next turn).
432func (e *Events) wait(ctx context.Context, w *watch, changed <-chan struct{}) {
433 var idle <-chan time.Time
434 if w.p.TokenID() != "" {
435 t := time.NewTimer(e.idleCheck())
436 defer t.Stop()
437 idle = t.C
438 }
439 select {
440 case <-changed:
441 case <-idle:
442 case <-ctx.Done():
443 }
444}
445
446// idleCheck is how long a watcher with a stored token waits for news before
447// checking its token anyway.
448func (e *Events) idleCheck() time.Duration {
449 if e.every <= 0 {
450 return DefaultRevalidateEvery
451 }
452 return min(e.every, DefaultRevalidateEvery)
453}
454
455// stillAllowed checks that the holder of a stored token may still watch: the
456// token has not expired and, at most every few seconds, still exists. Root and
457// anonymous callers have nothing to lose. The owner topic needs nothing more:
458// a stored token with owner rights loses them only by ceasing to exist, which
459// is checked here, and the owner's web session, which this use case cannot see,
460// is checked by the web adapter before it sends anything.
461func (e *Events) stillAllowed(ctx context.Context, w *watch) error {
462 if w.p.TokenID() == "" {
463 return nil
464 }
465 if exp := w.p.ExpiresAt(); !exp.IsZero() && !e.clock.Now().Before(exp) {
466 return domain.ErrUnauthenticated
467 }
468 if e.every > 0 && time.Since(w.checked) < e.every {
469 return nil
470 }
471 if err := e.auth.Revalidate(ctx, w.p); err != nil {
472 if ctx.Err() != nil {
473 return nil
474 }
475 return err
476 }
477 w.checked = time.Now()
478 return nil
479}
480
481// since returns the buffered events from sequence next on, and the channel
482// that closes when more arrive. lost is true when next fell out of the buffer;
483// the caller then restarts from oldest, the first buffered sequence. The
484// returned slice is a copy.
485func (e *Events) since(next uint64) (batch []bufferedEvent, changed <-chan struct{}, oldest uint64, lost, closed bool) {
486 e.mu.Lock()
487 defer e.mu.Unlock()
488 oldest = e.nextSeq - uint64(len(e.ring))
489 if next < oldest {
490 return nil, e.changed, oldest, true, e.closed
491 }
492 batch = append(batch, e.ring[next-oldest:]...)
493 return batch, e.changed, oldest, false, e.closed
494}
495
496// deliver sends the event if the watcher follows its topic and may see it.
497func (e *Events) deliver(ctx context.Context, w *watch, be bufferedEvent, send func(ports.WatchEvent) error) error {
498 if err := e.stillAllowed(ctx, w); err != nil {
499 return err
500 }
501 out := ports.WatchEvent{ID: e.id(be.seq), Event: be.ev}
502 switch ev := be.ev.(type) {
503 case domain.EventGap:
504 // The feeder lost events: tell every watcher.
505 return send(ports.WatchEvent{Gap: true})
506 case domain.RepoDeleted:
507 // The repository is gone: use the visibility it had.
508 if !w.wantsEvent(ev.Repo, ev) || !canReadAs(w.p, ev.Repo, ev.Visibility) {
509 return nil
510 }
511 return send(out)
512 case domain.IssueSubmitted:
513 return e.deliverOwnerOnly(ctx, w, ev.Repo, out, send)
514 case domain.IssuePendingRemoved:
515 return e.deliverOwnerOnly(ctx, w, ev.Repo, out, send)
516 case domain.RepoCreated:
517 return e.deliverRepo(ctx, w, ev.Repo, true, be, out, send)
518 case domain.RepoUpdated:
519 return e.deliverRepo(ctx, w, ev.Repo, true, be, out, send)
520 case domain.PushEvent:
521 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
522 case domain.MergeRequestOpened:
523 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
524 case domain.MergeRequestMerged:
525 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
526 case domain.MergeRequestClosed:
527 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
528 case domain.MergeRequestReady:
529 return e.deliverRepo(ctx, w, ev.MergeRequest.Repo, false, be, out, send)
530 case domain.CommentAdded:
531 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
532 case domain.IssueOpened:
533 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
534 case domain.IssueClosed:
535 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
536 case domain.IssueReopened:
537 return e.deliverRepo(ctx, w, ev.Issue.Repo, false, be, out, send)
538 case domain.IssueCommented:
539 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
540 case domain.CommentEdited:
541 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
542 case domain.CommentDeleted:
543 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
544 case domain.CommentResolved:
545 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
546 case domain.MergeRequestMergeability:
547 return e.deliverRepo(ctx, w, ev.Repo, false, be, out, send)
548 case domain.RunUpdated:
549 // Home shows the CI state of each repository.
550 return e.deliverRepo(ctx, w, ev.Run.Repo, false, be, out, send)
551 case domain.JobUpdated:
552 // Home gets a job when it ends only: a failed job turns the state to
553 // failing before its run ends. Its progress stays on the topic of its
554 // repository.
555 if !w.repos[ev.Job.Repo] && ev.Job.Phase != domain.CIPhaseEnded {
556 return nil
557 }
558 return e.deliverRepo(ctx, w, ev.Job.Repo, false, be, out, send)
559 }
560 return nil // an event this version does not stream
561}
562
563// deliverOwnerOnly sends an owner-topic event: never home, never a repository
564// topic, not even to an owner who watches the repository. No content travels.
565func (e *Events) deliverOwnerOnly(ctx context.Context, w *watch, name domain.RepoName, out ports.WatchEvent, send func(ports.WatchEvent) error) error {
566 if !w.owner {
567 return nil
568 }
569 repo, err := lookupRepo(ctx, e.repos.meta, name)
570 switch {
571 case errors.Is(err, domain.ErrNotFound), ctx.Err() != nil:
572 return nil
573 case err != nil:
574 return fmt.Errorf("check access to %q: %w", name, err)
575 }
576 if !repo.Settings.IssuesEnabled() {
577 return nil
578 }
579 return send(out)
580}
581
582// deliverRepo sends an event about a repository if the watcher could read the
583// repository when the event happened and can read it now, and the repository
584// is still the one the event is about. A repository that no longer exists is
585// skipped: its RepoDeleted follows or came before.
586//
587// The exception is a repository that became private: the watchers who could
588// read it before are told once, with its name and its new visibility only,
589// so that what they show can be removed.
590func (e *Events) deliverRepo(ctx context.Context, w *watch, name domain.RepoName, withRepo bool, be bufferedEvent, out ports.WatchEvent, send func(ports.WatchEvent) error) error {
591 if !w.wantsEvent(name, be.ev) || !be.known {
592 return nil
593 }
594 repo, err := lookupRepo(ctx, e.repos.meta, name)
595 switch {
596 case errors.Is(err, domain.ErrNotFound):
597 return nil
598 case ctx.Err() != nil:
599 return nil
600 case err != nil:
601 return fmt.Errorf("check access to %q: %w", name, err)
602 }
603 if repo.CreatedAt.After(be.created) {
604 return nil // the event is about a repository of this name that was deleted
605 }
606 if !canReadAs(w.p, name, be.vis) {
607 if up, ok := be.ev.(domain.RepoUpdated); ok && canReadAs(w.p, name, up.Previous) {
608 out.Repo = &ports.RepoView{Repo: domain.Repo{Name: name, Visibility: up.Visibility}}
609 return send(out)
610 }
611 return nil
612 }
613 if !canRead(w.p, repo) {
614 return nil
615 }
616 if isIssueEvent(be.ev) && !repo.Settings.IssuesEnabled() {
617 return nil // issues were turned off since: a replay must not show them
618 }
619 if withRepo {
620 view, err := e.repos.View(ctx, repo)
621 if err != nil {
622 return err
623 }
624 out.Repo = &view
625 }
626 return send(out)
627}
628
629// isIssueEvent reports whether ev is about an issue.
630func isIssueEvent(ev domain.Event) bool {
631 switch ev.(type) {
632 case domain.IssueOpened, domain.IssueClosed, domain.IssueReopened, domain.IssueCommented:
633 return true
634 }
635 return false
636}
637
638// isRepoLifecycleEvent reports whether ev is a repository update or deletion:
639// the owner topic follows them, for they change what the inbox lists.
640func isRepoLifecycleEvent(ev domain.Event) bool {
641 switch ev.(type) {
642 case domain.RepoUpdated, domain.RepoDeleted:
643 return true
644 }
645 return false
646}
647
648// isItemEvent reports whether ev is about a merge request or an issue.
649func isItemEvent(ev domain.Event) bool {
650 switch ev.(type) {
651 case domain.MergeRequestOpened, domain.MergeRequestMerged, domain.MergeRequestClosed,
652 domain.MergeRequestReady, domain.MergeRequestMergeability, domain.CommentAdded,
653 domain.CommentEdited, domain.CommentDeleted, domain.CommentResolved:
654 return true
655 }
656 return isIssueEvent(ev)
657}