v0.31.0 d5e0505

mr.test.mjs RawHistoryFolder

1// Tests of the pure core of the merge request page (static/js/mr.js). Run with
2//   node --test 'internal/adapters/web/jstest/*.test.mjs'
3import assert from 'node:assert/strict';
4import { test } from 'node:test';
5
6globalThis.window = globalThis;
7globalThis.document = { readyState: 'complete', querySelector: () => null, querySelectorAll: () => [] };
8await import('../static/js/lazy.js');
9await import('../static/js/mr.js');
10const C = window.ermiteMR.core;
11
12test('windowOf: the start of the window of a file', () => {
13  assert.equal(C.windowOf('f1', 25), 0);
14  assert.equal(C.windowOf('f25', 25), 0);
15  assert.equal(C.windowOf('f26', 25), 25);
16  assert.equal(C.windowOf('f84', 25), 75);
17  assert.equal(C.windowOf('c3', 25), -1, 'not a file');
18  assert.equal(C.windowOf('f0', 25), -1);
19});
20
21test('menuKey: modes by number, D toggles the deletion, nothing else', () => {
22  assert.deepEqual(C.menuKey('1', 2), { mode: 0 });
23  assert.deepEqual(C.menuKey('2', 2), { mode: 1 });
24  assert.equal(C.menuKey('3', 2), null, 'no third mode');
25  assert.equal(C.menuKey('0', 2), null);
26  assert.deepEqual(C.menuKey('D', 2), { toggle: true });
27  assert.equal(C.menuKey('d', 2), null, 'd is the split layout');
28  assert.equal(C.menuKey('Enter', 2), null, 'the browser submits: the focus is on the button');
29  assert.equal(C.menuKey('M', 2), null);
30});
31
32test('step: stays in the list', () => {
33  assert.equal(C.step(0, 1, 3), 1);
34  assert.equal(C.step(2, 1, 3), 2);
35  assert.equal(C.step(0, -1, 3), 0);
36  assert.equal(C.step(-1, 1, 3), 0);
37  assert.equal(C.step(-1, -1, 3), 2);
38  assert.equal(C.step(0, 1, 0), -1);
39});
40
41test('rangeURL requires the same file, side and MR and sorts endpoints', () => {
42 const base = 'https://forge.test/demo/merge-requests/1';
43 const a = base+'?on=new:24:dir%2Fa.go#f1';
44 const b = base+'?from=25&on=new:10:dir%2Fa.go#f1';
45 const u = new URL(C.rangeURL(a,b,base));
46 assert.equal(u.searchParams.get('on'),'new:10-24:dir/a.go');
47 assert.equal(u.searchParams.get('from'),'25');
48 assert.equal(u.hash,'#f1');
49 assert.equal(C.rangeURL(a,a,base),null);
50 assert.equal(C.rangeURL(a,b.replace('new:','old:'),base),null);
51 assert.equal(C.rangeURL(a,b.replace('a.go','b.go'),base),null);
52 assert.equal(C.rangeURL(a,b.replace('/1?','/2?'),base),null);
53});
54
55test('quote opens the thread reply and prefills and focuses its textarea', () => {
56 let focused=false;
57 const field={value:'',focus(){focused=true;}};
58 const details={open:false,querySelector(){return field;}};
59 const thread={querySelector(){return details;}};
60 const button={dataset:{quote:'> source\n\n^2 '},closest(){return {closest(){return thread;}};}};
61 assert.equal(C.quote(button),true);
62 assert.equal(details.open,true);
63 assert.equal(field.value,'> source\n\n^2 ');
64 assert.equal(focused,true);
65});
66
67for (const dataset of [{diff:'split'}, {view:'split'}]) test(`reveal selects the split note (${JSON.stringify(dataset)}), including after lazy loading`, async () => {
68 const saved = globalThis.document;
69 const savedRAF = globalThis.requestAnimationFrame;
70 let scrolled = '';
71 const details = {open:false};
72 const node = id => ({id, querySelector(){return null;}, closest(){return details;}, scrollIntoView(){scrolled=id;}});
73 const nodes = new Map([['c12',node('c12')],['c12-s',node('c12-s')]]);
74 const ph = {dataset:{notes:'c12'}};
75 globalThis.document = {
76   querySelector: sel => sel === '#diffs' ? {dataset} : null,
77   querySelectorAll: () => [ph],
78   getElementById: id => nodes.get(id),
79 };
80 globalThis.requestAnimationFrame = fn => fn();
81 try {
82   assert.equal(window.ermiteMR.reveal('c12'),false);
83   assert.equal(scrolled,'c12-s');
84   assert.equal(details.open,true);
85   nodes.clear(); scrolled=''; details.open=false;
86   assert.equal(window.ermiteMR.reveal('c12'),true);
87   nodes.set('c12',node('c12')); nodes.set('c12-s',node('c12-s'));
88   await Promise.resolve();
89   assert.equal(scrolled,'c12-s');
90   assert.equal(details.open,true);
91 } finally {
92   globalThis.document=saved;
93   globalThis.requestAnimationFrame=savedRAF;
94 }
95});
96
97function footerHarness(extra = {}) {
98  const saved = Object.fromEntries(['document', 'location', 'addEventListener', 'history', 'MutationObserver'].map((k) => [k, globalThis[k]]));
99  const node = (id) => ({ id, attrs: {}, events: {}, hidden: false,
100    setAttribute(k, v) { this.attrs[k] = v; }, getAttribute(k) { return this.attrs[k] ?? null; },
101    addEventListener(k, v) { this.events[k] = v; }, focus() { this.focused = true; },
102    scrollIntoView() { this.scrolled = (this.scrolled ?? 0) + 1; } });
103  const tabs = [node('mr-tab-commits'), node('mr-tab-checks')];
104  const panels = [node('mr-commits'), node('mr-checks-panel')];
105  const footer = node('footer'); footer.querySelectorAll = () => panels;
106  const nav = node('tabs'); nav.querySelectorAll = () => tabs;
107  const listeners = {}, replaced = [];
108  globalThis.document = { querySelector: (s) => s === '.mr-footer' ? footer : s === '[data-mr-tabs]' ? nav : s === '#mr-ck' ? extra.summary ?? null : null,
109    querySelectorAll: (s) => s === '[data-mr-tabs] a' ? tabs : [], addEventListener(k, v) { listeners[k] = v; } };
110  globalThis.location = { hash: '', pathname: '/demo/merge-requests/1', search: '?x=1' };
111  globalThis.addEventListener = (k, v) => { listeners[k] = v; };
112  globalThis.history = { replaceState: (...args) => replaced.push(args) };
113  const restore = () => { for (const [k, v] of Object.entries(saved)) { if (v === undefined) delete globalThis[k]; else globalThis[k] = v; } };
114  const state = () => panels.map((p) => !p.hidden);
115  return { tabs, panels, footer, listeners, replaced, restore, state };
116}
117
118test('footer tabs: closed by default, toggle, switch, arrows, hash', () => {
119  const h = footerHarness();
120  try {
121    window.ermiteMR.panels();
122    assert.deepEqual(h.state(), [false, false], 'initially closed');
123    assert.equal(h.tabs[0].attrs['aria-expanded'], 'false');
124    assert.deepEqual(h.replaced, [], 'initial state leaves the URL alone');
125    h.tabs[1].events.click({ preventDefault() {} });
126    assert.deepEqual(h.state(), [false, true]);
127    assert.equal(h.tabs[1].attrs['aria-expanded'], 'true');
128    assert.deepEqual(h.replaced, [[null, '', '#mr-checks-panel']]);
129    location.hash = '#mr-checks-panel';
130    h.tabs[1].events.click({ preventDefault() {} });
131    assert.deepEqual(h.state(), [false, false], 'a second click closes');
132    assert.deepEqual(h.replaced.at(-1), [null, '', '/demo/merge-requests/1?x=1'], 'closing clears the fragment');
133    location.hash = '';
134    h.tabs[1].events.click({ preventDefault() {} });
135    h.tabs[0].events.click({ preventDefault() {} });
136    assert.deepEqual(h.state(), [true, false], 'the other tab switches');
137    h.tabs[0].events.keydown({ key: 'ArrowRight', preventDefault() {} });
138    assert.equal(h.tabs[1].focused, true, 'arrows move focus only');
139    assert.deepEqual(h.state(), [true, false]);
140    location.hash = '#mr-checks'; h.replaced.length = 0; h.listeners.hashchange();
141    assert.deepEqual(h.state(), [false, true], 'hash opens checks');
142    assert.deepEqual(h.replaced, [], 'hash navigation does not rewrite the URL');
143    location.hash = '#mr-commits'; h.listeners.hashchange();
144    assert.deepEqual(h.state(), [true, false]);
145    assert.equal(C.tabIndex('Home', 1, 2), 0);
146    assert.equal(C.tabIndex('End', 0, 2), 1);
147    assert.equal(C.tabIndex('ArrowLeft', 0, 2), 1);
148    assert.equal(C.tabIndex('Escape', 0, 2), null);
149  } finally { h.restore(); }
150});
151
152test('footer: #mr-ck syncs the checks label; its click opens Checks without toggling', () => {
153  const text0 = { v: '' }; let writes = 0;
154  const label = { get textContent() { return text0.v; }, set textContent(v) { writes++; text0.v = v; } };
155  const summary = { title: '1/2 failed', textContent: ' 1/2 ', parentElement: {} };
156  const h = footerHarness({ summary });
157  let observed = null, callback = null;
158  globalThis.MutationObserver = class { constructor(fn) { callback = fn; } observe(target, opts) { observed = [target, opts]; } };
159  const nav = document.querySelector('[data-mr-tabs]');
160  nav.querySelector = (s) => s === '[data-checks-label]' ? label : null;
161  try {
162    window.ermiteMR.panels();
163    assert.equal(label.textContent, '1/2 failed', 'initial label sync');
164    assert.equal(observed[0], summary.parentElement);
165    assert.deepEqual(observed[1], { childList: true }, 'only #mr-ck replacements wake the observer');
166    const before = writes; callback(); callback();
167    assert.equal(writes, before, 'an unchanged label is not written');
168    summary.title = ''; callback();
169    assert.equal(label.textContent, '1/2');
170    summary.textContent = ' '; callback();
171    assert.equal(label.textContent, 'no checks');
172    const click = { target: { closest: (s) => s === '#mr-ck' ? summary : null } };
173    h.listeners.click(click);
174    assert.deepEqual(h.state(), [false, true]);
175    h.listeners.click(click);
176    assert.deepEqual(h.state(), [false, true], 'a second badge click keeps it open');
177  } finally { h.restore(); }
178});
179
180test('footer: panels(index) restores the open panel without touching the URL', () => {
181  const h = footerHarness();
182  try {
183    location.hash = '#mr-commits';
184    window.ermiteMR.panels(1);
185    assert.deepEqual(h.state(), [false, true], 'a restore ignores the fragment');
186    assert.equal(h.tabs[1].attrs['aria-expanded'], 'true');
187    assert.deepEqual(h.replaced, []);
188    assert.equal(h.panels[0].scrolled, undefined, 'a restore does not scroll');
189    assert.equal(h.panels[1].scrolled, undefined);
190    location.hash = '';
191    window.ermiteMR.panels(-1);
192    assert.deepEqual(h.state(), [false, false]);
193  } finally { h.restore(); }
194});
195
196test('footer: scripts take over the panels; a fragment opens and scrolls to its panel', () => {
197  const h = footerHarness();
198  try {
199    location.hash = '#mr-checks';
200    window.ermiteMR.panels();
201    assert.equal(h.footer.attrs['data-panels'], '', 'the CSS fallback of the fragment stops');
202    assert.deepEqual(h.state(), [false, true]);
203    assert.equal(h.panels[1].scrolled, 1, 'the panel of the fragment is brought in');
204    location.hash = '#mr-commits'; h.listeners.hashchange();
205    assert.deepEqual(h.state(), [true, false]);
206    assert.equal(h.panels[0].scrolled, 1);
207  } finally { h.restore(); }
208});
209
210test('touch range: first tap anchors, second tap opens the sorted range', () => {
211  const base = 'https://forge.test/demo/merge-requests/1';
212  const first = base + '?on=new:24:a.go#f1';
213  const last = base + '?on=new:10:a.go#f1';
214  assert.deepEqual(C.touchRange(null, first, base), { start: first, url: null });
215  const result = C.touchRange(first, last, base);
216  assert.equal(result.start, null);
217  assert.equal(new URL(result.url).searchParams.get('on'), 'new:10-24:a.go');
218  assert.deepEqual(C.touchRange(first, first, base), { start: null, url: first });
219});
220
221test('touch range: a different file, side or request becomes a new anchor', () => {
222  const base = 'https://forge.test/demo/merge-requests/1';
223  const first = base + '?on=new:24:a.go#f1';
224  for (const next of [first.replace('new:', 'old:'), first.replace('a.go', 'b.go'), first.replace('/1?', '/2?')]) {
225    assert.deepEqual(C.touchRange(first, next, base), { start: next, url: null });
226  }
227});
228
229test('mobile unified fallback only redirects single-layout split pages and preserves query/hash', () => {
230  const href = 'https://forge.test/demo/merge-requests/1?view=split&from=25&on=new:3:a.go#f26';
231  assert.equal(C.mobileURL(href, 'split', false), null);
232  assert.equal(C.mobileURL(href, undefined, true), null, 'both layouts are switched by CSS');
233  assert.equal(C.mobileURL(href, 'unified', true), null, 'no redirect loop');
234  const url = new URL(C.mobileURL(href, 'split', true));
235  assert.equal(url.searchParams.get('view'), 'unified');
236  assert.equal(url.searchParams.get('from'), '25');
237  assert.equal(url.searchParams.get('on'), 'new:3:a.go');
238  assert.equal(url.hash, '#f26');
239});
240
241test('touch control: lazy links enable toolbar; ordinary taps pass through; ranges navigate and cancel', async () => {
242  const saved = Object.fromEntries(['document', 'location', 'addEventListener', 'localStorage', 'sessionStorage', 'fetch', 'matchMedia'].map((k) => [k, globalThis[k]]));
243  const make = () => ({
244    attrs: {}, events: {}, children: [], textContent: '',
245    setAttribute(k, v) { this.attrs[k] = v; },
246    removeAttribute(k) { delete this.attrs[k]; },
247    addEventListener(k, fn) { this.events[k] = fn; },
248    append(...nodes) { this.children.push(...nodes); },
249    prepend(node) { this.children.unshift(node); },
250    querySelector() { return null; }, querySelectorAll() { return []; },
251  });
252  const diffs = make();
253  diffs.dataset = { diff: 'split' };
254  const base = 'https://forge.test/demo/merge-requests/1';
255  const line = (n) => Object.assign(make(), { href: `${base}?on=new:${n}:a.go#f1`, textContent: String(n) });
256  const a = line(20), b = line(10);
257  let loaded = false;
258  diffs.querySelector = () => loaded ? a : null;
259  let assigned = null;
260  globalThis.document = {
261    querySelector: (sel) => sel === '#diffs[data-mr]' || sel === '#diffs' ? diffs : null,
262    querySelectorAll: () => [], createElement: (tag) => tag === 'template' ? { content: { querySelectorAll: () => [] } } : make(),
263  };
264  globalThis.location = { href: base, pathname: '/demo/merge-requests/1', hash: '', assign(url) { assigned = url; } };
265  globalThis.addEventListener = () => {};
266  const changes = {};
267  const medias = {};
268  globalThis.matchMedia = (q) => medias[q] ??= { matches: true, addEventListener(type, fn) { changes[q] = fn; } };
269  const media = globalThis.matchMedia('(max-width: 720px)');
270  const touchQuery = '(pointer: coarse), (hover: none)';
271  const resize = () => changes['(max-width: 720px)']();
272  globalThis.fetch = async () => { loaded = true; return { ok: true, status: 200, text: async () => '' }; };
273  globalThis.localStorage = globalThis.sessionStorage = { getItem: () => null };
274  const click = (link, modifiers = {}) => {
275    const e = { target: { closest: () => link }, prevented: false, stopped: false,
276      preventDefault() { this.prevented = true; }, stopPropagation() { this.stopped = true; }, ...modifiers };
277    diffs.events.click(e);
278    return e;
279  };
280  try {
281    window.ermiteMR.start();
282    const bar = diffs.children[0];
283    const [button, status] = bar.children;
284    assert.equal(bar.hidden, true, 'no commentable links in the initial window');
285    assert.equal(typeof diffs.events.click, 'function', 'delegation installed before lazy load');
286    await window.ermiteMR.load({ dataset: { src: '/files?from=25' } });
287    assert.equal(bar.hidden, false, 'lazy window refresh reveals range control');
288    assert.equal(diffs.dataset.mobile, 'true');
289    assert.equal(diffs.dataset.diff, 'split', 'preferred layout is retained');
290    media.matches = false;
291    resize();
292    assert.equal(diffs.dataset.mobile, 'false', 'desktop menu returns to preferred layout');
293    assert.equal(diffs.dataset.diff, 'split');
294    assert.equal(click(a).prevented, false, 'normal single-line navigation is untouched');
295    button.events.click();
296    assert.equal(button.attrs['aria-pressed'], 'true');
297    assert.equal(click(a, { shiftKey: true }).prevented, false, 'desktop range selection is untouched');
298    const event = click(a);
299    assert.equal(event.prevented, true);
300    assert.equal(event.stopped, true);
301    assert.ok('data-range-start' in a.attrs);
302    assert.match(status.textContent, /20/);
303    click(b);
304    assert.equal(new URL(assigned).searchParams.get('on'), 'new:10-20:a.go');
305    assert.equal('data-range-start' in a.attrs, false);
306    click(a);
307    button.events.click();
308    assert.equal(button.attrs['aria-pressed'], 'false');
309    assert.equal(status.textContent, '');
310    assert.equal('data-range-start' in a.attrs, false);
311    assert.equal(click(b).prevented, false);
312    // The touch media query stops matching: range mode is switched off.
313    button.events.click();
314    click(a);
315    assert.equal(button.attrs['aria-pressed'], 'true');
316    assert.ok('data-range-start' in a.attrs);
317    medias[touchQuery].matches = false;
318    changes[touchQuery]();
319    assert.equal(button.attrs['aria-pressed'], 'false');
320    assert.equal(status.textContent, '');
321    assert.equal('data-range-start' in a.attrs, false);
322    assert.equal(click(b).prevented, false, 'clicks pass through once touch stops matching');
323  } finally {
324    for (const [k, v] of Object.entries(saved)) {
325      if (v === undefined) delete globalThis[k]; else globalThis[k] = v;
326    }
327  }
328});
329
330// Deterministic timers: no sleeps, and each test restores every mocked global.
331function clock() {
332  const saved = { setTimeout: globalThis.setTimeout, clearTimeout: globalThis.clearTimeout };
333  const tasks = new Map(); let n = 0, now = 0;
334  globalThis.setTimeout = (fn, delay = 0) => { tasks.set(++n, { fn, at: now + delay }); return n; };
335  globalThis.clearTimeout = (id) => tasks.delete(id);
336  return { async tick(ms = 300) { now += ms; const batch = [...tasks].filter(([, t]) => t.at <= now); for (const [id] of batch) tasks.delete(id); for (const [, t] of batch) await t.fn(); },
337    size: () => tasks.size, restore() { Object.assign(globalThis, saved); } };
338}
339
340test('head refresh defers a real textarea draft, resumes after emptying and blurring', async () => {
341  const saved = globalThis.document, c = clock();
342  const text = { value: 'unsent', defaultValue: '' };
343  let fetched = 0, applied = 0; const notices = [];
344  globalThis.document = { activeElement: text, querySelectorAll: () => [text] };
345  const r = window.ermiteMR.refresher({ blocked: window.ermiteMR.hasDraft,
346    fetchPage: async () => { fetched++; return 'page'; }, apply: () => applied++,
347    notice: (v) => notices.push(v), failed: () => assert.fail('unexpected fallback') });
348  try {
349    r.request(); await c.tick();
350    assert.equal(fetched, 0); assert.deepEqual(notices, [true]);
351    text.value = ''; r.resume(); await c.tick();
352    assert.equal(fetched, 0, 'focus still protects an empty draft');
353    document.activeElement = null; r.resume(); await c.tick();
354    assert.equal(fetched, 1); assert.equal(applied, 1); assert.equal(r.pending(), false);
355  } finally { globalThis.document = saved; c.restore(); }
356});
357
358test('head refresh debounces bursts, serializes requests, and reruns after an in-flight push', async () => {
359  const c = clock(); let fetched = 0, applied = 0, resolve;
360  const r = window.ermiteMR.refresher({ blocked: () => false,
361    fetchPage: () => { fetched++; return new Promise((r) => { resolve = r; }); },
362    apply: () => applied++, notice() {}, failed: () => assert.fail('unexpected failure') });
363  try {
364    r.request(); r.request(); r.request(); assert.equal(c.size(), 1);
365    await c.tick(299); assert.equal(fetched, 0);
366    await c.tick(0); assert.equal(fetched, 0);
367    const first = c.tick(1); assert.equal(fetched, 1);
368    r.request(); await c.tick(); assert.equal(fetched, 1, 'one fetch in flight');
369    resolve('one'); await first; assert.equal(applied, 1); assert.equal(c.size(), 1);
370    const second = c.tick(); assert.equal(fetched, 2); resolve('two'); await second;
371    assert.equal(applied, 2); assert.equal(c.size(), 0);
372  } finally { c.restore(); }
373});
374
375test('typing during fetch defers even manual refresh until the draft ends', { timeout: 2000 }, async () => {
376  const c = clock(); let blocked = false, applied = 0, resolve, fetched = 0; const notices = [];
377  const r = window.ermiteMR.refresher({ blocked: () => blocked,
378    fetchPage: () => { fetched++; return new Promise((r) => { resolve = r; }); }, apply: () => { applied++; },
379    notice: (v) => notices.push(v), failed: () => assert.fail('unexpected failure') });
380  try {
381    r.request(); const first = c.tick(); blocked = true; resolve('page'); await first;
382    assert.equal(applied, 0); assert.deepEqual(notices, [true]);
383    r.request(true); const manual = c.tick();
384    assert.equal(fetched, 1, 'manual refresh must not start a fetch during a draft');
385    await manual; assert.equal(applied, 0);
386    blocked = false; r.resume(); const second = c.tick(); resolve('new page'); await second;
387    assert.equal(applied, 1); assert.equal(notices.at(-1), false);
388  } finally { c.restore(); }
389});
390
391test('fetch failures and non-MR responses take the fallback, never apply', async () => {
392  const saved = { fetch: globalThis.fetch, location: globalThis.location, DOMParser: globalThis.DOMParser };
393  const c = clock(); let fallback = 0;
394  globalThis.location = { href: 'https://forge.test/demo/merge-requests/1?view=split&from=25' };
395  const r = window.ermiteMR.refresher({ blocked: () => false, fetchPage: window.ermiteMR.fetchPage,
396    apply: () => assert.fail('must not swap'), notice() {}, failed: () => fallback++ });
397  try {
398    for (const result of ['network', { ok: false }, { ok: true, redirected: true }, { ok: true, text: async () => '<html>login</html>' }]) {
399      globalThis.fetch = async (url, opts) => {
400        assert.equal(url, location.href); assert.equal(opts.credentials, 'same-origin');
401        if (result === 'network') throw new Error('offline'); return result;
402      };
403      globalThis.DOMParser = class { parseFromString() { return { querySelector: () => null }; } };
404      r.request(); await c.tick();
405    }
406    assert.equal(fallback, 4);
407  } finally {
408    for (const [k,v] of Object.entries(saved)) { if (v === undefined) delete globalThis[k]; else globalThis[k] = v; }
409    c.restore();
410  }
411});
412
413test('viewport probe finds a stable path/side/line and restores its offset without line scans', () => {
414  const names = ['document', 'location', 'innerHeight', 'innerWidth', 'scrollY', 'scrollBy', 'scrollTo', 'CSS', 'matchMedia'];
415  const saved = Object.fromEntries(names.map((k) => [k, globalThis[k]]));
416  const rect = (top, bottom = top + 20) => ({ top, bottom, left: 0, width: 900 });
417  let lineTop = 160, headerTop = -200, found = true; const calls = [];
418  const header = { getBoundingClientRect: () => rect(headerTop) };
419  const row = { getBoundingClientRect: () => rect(lineTop), querySelector: () => link };
420  const link = { href: 'https://forge.test/demo/merge-requests/1?on=new:42:a.go#f2', closest: () => row, getAttribute: () => link.href };
421  const file = { getBoundingClientRect: () => rect(headerTop), id: 'f2', dataset: { file: 'a.go' }, querySelector: (s) => s.includes('summary') ? header : s.includes('href$') ? (assert.ok(s.includes('on=new:42:a.go#f3')), found ? link : null) : null };
422  const hit = { closest: (s) => s === 'tr' ? row : file };
423  const diffs = { dataset: { diff: 'unified' }, getBoundingClientRect: () => rect(120), contains: () => true };
424  globalThis.document = {
425    querySelector: (s) => s === '#diffs' ? diffs : s === '.hdr' ? { getBoundingClientRect: () => rect(0, 100) } : null,
426    querySelectorAll: (s) => { assert.equal(s, '#diffs details.dfile', 'only files, never every line'); return found === 'gone' ? [] : [file]; },
427    elementFromPoint: () => hit, documentElement: { scrollHeight: 10000 },
428  };
429  Object.assign(globalThis, { location: { href: link.href }, innerHeight: 800, innerWidth: 1200, scrollY: 2500,
430    scrollBy: (arg) => calls.push(['by', arg]), scrollTo: (arg) => calls.push(['to', arg]), CSS: { escape: (s) => s }, matchMedia: () => ({ matches: false }) });
431  try {
432    const a = window.ermiteMR.scrollAnchor();
433    assert.equal(a.file, 'a.go'); assert.equal(a.on, 'new:42:a.go'); assert.equal(a.offset, 160);
434    file.id = 'f3'; lineTop = 260; window.ermiteMR.restoreAnchor(a);
435    assert.deepEqual(calls.pop(), ['by', { top: 100, behavior: 'instant' }]);
436    found = false; headerTop = -100; window.ermiteMR.restoreAnchor(a);
437    assert.deepEqual(calls.pop(), ['by', { top: 100, behavior: 'instant' }]);
438    found = 'gone'; window.ermiteMR.restoreAnchor({ ...a, y: 20000 });
439    assert.deepEqual(calls.pop(), ['to', { top: 9200, behavior: 'instant' }]);
440  } finally { for (const [k,v] of Object.entries(saved)) { if (v === undefined) delete globalThis[k]; else globalThis[k] = v; } }
441});
442
443test('empty edited default and focused cform controls protect drafts', () => {
444  const saved = document;
445  try {
446    globalThis.document = { querySelectorAll: () => [{ value: '', defaultValue: 'existing' }], activeElement: null };
447    assert.equal(window.ermiteMR.hasDraft(), true);
448    document.querySelectorAll = () => [];
449    document.activeElement = { closest: (s) => s === '.cform' ? {} : null };
450    assert.equal(window.ermiteMR.hasDraft(), true);
451  } finally { globalThis.document = saved; }
452});
453
454test('failure during a draft keeps pending and resumes after the draft ends', async () => {
455  const c = clock(); let blocked = false, reject, applied = 0, count = 0;
456  const r = window.ermiteMR.refresher({ blocked: () => blocked,
457    fetchPage: () => ++count === 1 ? new Promise((_, no) => { reject = no; }) : Promise.resolve('page'),
458    apply: () => applied++, notice() {}, failed: () => assert.fail('draft must defer fallback') });
459  try {
460    r.request(); const first = c.tick(); blocked = true; reject(new Error('offline')); await first;
461    assert.equal(r.pending(), true); assert.equal(applied, 0);
462    blocked = false; r.resume(); await c.tick(); assert.equal(applied, 1);
463  } finally { c.restore(); }
464});
465
466test('anchor restoration retains the server encoding of tilde and star paths', () => {
467  const saved = { document, CSS: globalThis.CSS, scrollBy: globalThis.scrollBy };
468  try {
469    globalThis.CSS = { escape: (s) => s };
470    globalThis.scrollBy = () => {};
471    for (const path of ['a~.go', 'a*.go']) {
472      const encoded = path.replace('*', '%2A');
473      const row = { getBoundingClientRect: () => ({ top: 5 }) };
474      const file = { id: 'f9', dataset: { file: path }, querySelector: (s) => {
475        if (s === '.dt.uni') return file;
476        assert.equal(s, 'a[href$="on=new:12:' + encoded + '#f9"]');
477        return { closest: () => row };
478      } };
479      globalThis.document = { querySelectorAll: () => [file], querySelector: () => ({ dataset: { diff: 'unified' } }) };
480      window.ermiteMR.restoreAnchor({ file: path, suffix: 'new:12:' + encoded, on: 'new:12:' + path, offset: 5 });
481    }
482  } finally { Object.assign(globalThis, saved); }
483});
484
485for (const control of [
486  { type: 'radio', checked: true, defaultChecked: false },
487  { type: 'checkbox', checked: false, defaultChecked: true },
488  { type: 'number', name: 'start_line', value: '10', defaultValue: '12' },
489  { tagName: 'SELECT', options: [{ selected: true, defaultSelected: false }] },
490]) test(`changed ${control.name || control.type || control.tagName} remains a draft after blur`, () => {
491  const saved = document;
492  try {
493    globalThis.document = { activeElement: null, querySelectorAll(sel) {
494      assert.equal(sel, ':is(form.cform, .cmt form, form.d-acts) :is(textarea, input, select)');
495      return [control];
496    } };
497    assert.equal(window.ermiteMR.hasDraft(), true);
498  } finally { globalThis.document = saved; }
499});
500
501test('intercepted Cancel resets the entire comment form', () => {
502  const saved = Object.fromEntries(['document', 'location', 'addEventListener', 'matchMedia'].map(k => [k, globalThis[k]]));
503  const c = clock(), handlers = {};
504  const diffs = { dataset: { view: 'split' }, querySelector() { return null; }, querySelectorAll() { return []; } };
505  const radio = { type: 'radio', checked: true, defaultChecked: false };
506  const line = { type: 'number', value: '2', defaultValue: '4' };
507  let reset = 0, prevented = false;
508  const form = { reset() { reset++; radio.checked = radio.defaultChecked; line.value = line.defaultValue; }, contains() { return false; } };
509  const cancel = { closest: () => form };
510  globalThis.document = { activeElement: null,
511    querySelector: s => ['#diffs', '#diffs[data-mr]'].includes(s) ? diffs : null,
512    querySelectorAll: s => s.includes('form.cform') ? [radio, line] : [],
513    addEventListener: (type, fn) => { handlers[type] = fn; } };
514  globalThis.location = { pathname: '/demo/merge-requests/1', hash: '', href: 'https://forge.test/demo/merge-requests/1', replace() {} };
515  globalThis.addEventListener = () => {};
516  globalThis.matchMedia = () => ({ matches: true, addEventListener() {} });
517  try {
518    window.ermiteMR.start();
519    window.ermiteMR.headChanged();
520    handlers.click({ target: { closest: () => cancel }, preventDefault() { prevented = true; } });
521    assert.equal(prevented, true);
522    assert.equal(reset, 1);
523    assert.equal(window.ermiteMR.hasDraft(), false);
524  } finally { Object.assign(globalThis, saved); c.restore(); }
525});

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 4

Tags 45

↑↓ moveenter openesc close