perf(ermitegit): look up candidate refs without allocating on a miss

commit: 127d960f9fb38519d90caefaae16b623aff62b8c
author: brice · 11d ago · 2026-10-11 01:22 UTC
parent: 778461a
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +4 -5

M internal/adapters/ermitegit/convert.go +4 -5


@@ -100,11 +100,10 @@ func (r resolved) domain() (domain.ResolvedRevision, error) {
100	100		// peelRef reads a ref and peels it to a commit. ok is false when the ref does
101	101		// not exist or does not lead to a commit.
102	102		func peelRef(r *git.Repo, name string) (_ git.ObjectID, ok bool, _ error) {
103		-	id, err := r.ResolveRef(name)
104		-	if errors.Is(err, git.ErrNotFound) {
105		-	return git.ObjectID{}, false, nil
106		-	}
107		-	if err != nil {
	103	+	// LookupRefID allocates nothing on a miss, which is the common case of the
	104	+	// candidates of resolveRevision (heads/x, then tags/x, then refs/...).
	105	+	id, found, err := r.LookupRefID(name)
	106	+	if err != nil \|\| !found {
108	107		return git.ObjectID{}, false, err
109	108		}
110	109		return peelID(r, id)

 // peelRef reads a ref and peels it to a commit. ok is false when the ref does
 // not exist or does not lead to a commit.
 func peelRef(r *git.Repo, name string) (_ git.ObjectID, ok bool, _ error) {
-	id, err := r.ResolveRef(name)
+	// LookupRefID allocates nothing on a miss, which is the common case of the
-	if errors.Is(err, git.ErrNotFound) {
+	// candidates of resolveRevision (heads/x, then tags/x, then refs/...).
-		return git.ObjectID{}, false, nil
+	id, found, err := r.LookupRefID(name)
-	}
+	if err != nil || !found {
-	if err != nil {
 		return git.ObjectID{}, false, err
 	}
 	return peelID(r, id)