fix(mediapolicy): apply De Morgan's law in host checks

commit: 2c6a32b9c950cb87d2f3cc54c7d8775d67c465ed
author: brice · 2h ago · 2026-10-22 14:34 UTC
committer: brice · 2h ago · 2026-10-22 14:34 UTC
parent: 1094a08
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
checks: 4/4

1 file · +2 -2

M internal/mediapolicy/hosts.go +2 -2


@@ -28,7 +28,7 @@ func Parse(value string) ([]string, error) {
28	28		return nil, fmt.Errorf("must contain exact DNS hostnames")
29	29		}
30	30		for _, c := range label {
31		-	if !(c >= 'a' && c <= 'z' \|\| c >= '0' && c <= '9' \|\| c == '-') {
	31	+	if (c < 'a' \|\| c > 'z') && (c < '0' \|\| c > '9') && c != '-' {
32	32		return nil, fmt.Errorf("must contain exact DNS hostnames")
33	33		}
34	34		}

@@ -52,7 +52,7 @@ func Allows(u *url.URL, hosts []string) bool {
52	52		if u == nil \|\| u.User != nil \|\| (u.Scheme != "https" && u.Scheme != "http") {
53	53		return false
54	54		}
55		-	if port := u.Port(); port != "" && !(u.Scheme == "https" && port == "443" \|\| u.Scheme == "http" && port == "80") {
	55	+	if port := u.Port(); port != "" && (u.Scheme != "https" \|\| port != "443") && (u.Scheme != "http" \|\| port != "80") {
56	56		return false
57	57		}
58	58		for _, host := range Hosts(hosts) {


@@ -28,7 +28,7 @@ func Parse(value string) ([]string, error) {
28		return nil, fmt.Errorf("must contain exact DNS hostnames")	28		return nil, fmt.Errorf("must contain exact DNS hostnames")
29		}	29		}
30		for _, c := range label {	30		for _, c := range label {
31	-	if !(c >= 'a' && c <= 'z' \|\| c >= '0' && c <= '9' \|\| c == '-') {	31	+	if (c < 'a' \|\| c > 'z') && (c < '0' \|\| c > '9') && c != '-' {
32		return nil, fmt.Errorf("must contain exact DNS hostnames")	32		return nil, fmt.Errorf("must contain exact DNS hostnames")
33		}	33		}
34		}	34		}

@@ -52,7 +52,7 @@ func Allows(u *url.URL, hosts []string) bool {
52		if u == nil \|\| u.User != nil \|\| (u.Scheme != "https" && u.Scheme != "http") {	52		if u == nil \|\| u.User != nil \|\| (u.Scheme != "https" && u.Scheme != "http") {
53		return false	53		return false
54		}	54		}
55	-	if port := u.Port(); port != "" && !(u.Scheme == "https" && port == "443" \|\| u.Scheme == "http" && port == "80") {	55	+	if port := u.Port(); port != "" && (u.Scheme != "https" \|\| port != "443") && (u.Scheme != "http" \|\| port != "80") {
56		return false	56		return false
57		}	57		}
58		for _, host := range Hosts(hosts) {	58		for _, host := range Hosts(hosts) {