skip to content

detached 66b7417

test(client): end handler on context instead of a fixed wait

commit: 66b7417fcbc47f3aed5972f6189a9c806999795b
author: brice · 12d ago · 2026-10-10 10:21 UTC
committer: brice · 12d ago · 2026-10-10 11:17 UTC
parent: 77dd5e4
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +2 -2

M internal/adapters/client/watch_test.go +2 -2


@@ -152,9 +152,9 @@ func TestWatchStopsOnPermanentErrors(t *testing.T) {
152	152
153	153		func TestWatchReturnsHandlerError(t *testing.T) {
154	154		f := &fake{}
155		-	f.watch = func(_ context.Context, _ connect.Request[ermite.WatchRequest], st connect.ServerStream[ermite.WatchResponse]) error {
	155	+	f.watch = func(ctx context.Context, _ connect.Request[ermite.WatchRequest], st connect.ServerStream[ermite.WatchResponse]) error {
156	156		_ = st.Send(pushed("e1"))
157		-	<-time.After(time.Second)
	157	+	<-ctx.Done()
158	158		return nil
159	159		}
160	160		c := start(t, f, client.Config{})


@@ -152,9 +152,9 @@ func TestWatchStopsOnPermanentErrors(t *testing.T) {
152			152
153		func TestWatchReturnsHandlerError(t *testing.T) {	153		func TestWatchReturnsHandlerError(t *testing.T) {
154		f := &fake{}	154		f := &fake{}
155	-	f.watch = func(_ context.Context, _ connect.Request[ermite.WatchRequest], st connect.ServerStream[ermite.WatchResponse]) error {	155	+	f.watch = func(ctx context.Context, _ connect.Request[ermite.WatchRequest], st connect.ServerStream[ermite.WatchResponse]) error {
156		_ = st.Send(pushed("e1"))	156		_ = st.Send(pushed("e1"))
157	-	<-time.After(time.Second)	157	+	<-ctx.Done()
158		return nil	158		return nil
159		}	159		}
160		c := start(t, f, client.Config{})	160		c := start(t, f, client.Config{})