test(app): merge the declaration with the assignment in the issue e2e test (staticcheck S1021)

commit: b2212f2e01db047a39fc5dae4a7cf3d69d063f43
author: brice · 3d ago · 2026-10-19 06:10 UTC
parent: 2794dd4
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +2 -5

M internal/app/cli_issue_e2e_test.go +2 -5


@@ -101,14 +101,11 @@ func TestIssuesCLIEndToEnd(t *testing.T) {
101	101		res = c.cli(t, adminToken, "issue", "comment", "proj", "#2", "-m", "Thanks.").ok(t)
102	102		assert.Regexp(t, `^comment \S+ added to proj#2\n$`, res.stdout)
103	103		res = c.cli(t, adminToken, "issue", "show", "proj", "2", "--json").ok(t)
104		-	var show struct {
	104	+	type showOut struct {
105	105		issueOut
106	106		Comments []issueCommentOut `json:"comments"`
107	107		}
108		-	show = decode[struct {
109		-	issueOut
110		-	Comments []issueCommentOut `json:"comments"`
111		-	}](t, res.stdout)
	108	+	show := decode[showOut](t, res.stdout)
112	109		assert.Equal(t, 2, show.CommentCount)
113	110		require.Len(t, show.Comments, 2)
114	111		assert.Equal(t, "Reproduced.", show.Comments[0].Text, "oldest first")

 	res = c.cli(t, adminToken, "issue", "comment", "proj", "#2", "-m", "Thanks.").ok(t)
 	assert.Regexp(t, `^comment \S+ added to proj#2\n$`, res.stdout)
 	res = c.cli(t, adminToken, "issue", "show", "proj", "2", "--json").ok(t)
-	var show struct {
+	type showOut struct {
 		issueOut
 		Comments []issueCommentOut `json:"comments"`
 	}
-	show = decode[struct {
+	show := decode[showOut](t, res.stdout)
-		issueOut
-		Comments []issueCommentOut `json:"comments"`
-	}](t, res.stdout)
 	assert.Equal(t, 2, show.CommentCount)
 	require.Len(t, show.Comments, 2)
 	assert.Equal(t, "Reproduced.", show.Comments[0].Text, "oldest first")