detached e53302b

refactor(kvstore): keep the hexcheck waiver on issue approval

commit
e53302bf7e20bcc57a125c818aa5160bf023cff0
author
brice · · 2026-10-19 09:01 UTC
parent
ddab9a2
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -0
Unified
UnifiedSplit
M internal/adapters/kvstore/issues_pending.go +2 -0
@@ -216,6 +216,8 @@ func (s *PendingIssues) Count(ctx context.Context) (int, error) {
216216 // Approve numbers the pending issue from mrseq/<repo> (see createNumbered),
217217 // writes the open issue and its index key and deletes the pending record, in
218218 // one batch that requires the pending record to be unchanged.
219+//
220+//hexcheck:ignore suspicious-business-logic-in-adapter only sets the number under a version precondition; the issue itself is built by domain.ApprovedIssue
219221 func (s *PendingIssues) Approve(ctx context.Context, repo domain.RepoName, id domain.PendingIssueID, now time.Time) (domain.Issue, error) {
220222 var number int64
221223 err := createNumbered(ctx, s.db, s.locks, repo, func(b *kv.Batch, n int64) error {
@@ -216,6 +216,8 @@ func (s *PendingIssues) Count(ctx context.Context) (int, error) {
216 // Approve numbers the pending issue from mrseq/<repo> (see createNumbered),216 // Approve numbers the pending issue from mrseq/<repo> (see createNumbered),
217 // writes the open issue and its index key and deletes the pending record, in217 // writes the open issue and its index key and deletes the pending record, in
218 // one batch that requires the pending record to be unchanged.218 // one batch that requires the pending record to be unchanged.
219+//
220+//hexcheck:ignore suspicious-business-logic-in-adapter only sets the number under a version precondition; the issue itself is built by domain.ApprovedIssue
219 func (s *PendingIssues) Approve(ctx context.Context, repo domain.RepoName, id domain.PendingIssueID, now time.Time) (domain.Issue, error) {221 func (s *PendingIssues) Approve(ctx context.Context, repo domain.RepoName, id domain.PendingIssueID, now time.Time) (domain.Issue, error) {
220 var number int64222 var number int64
221 err := createNumbered(ctx, s.db, s.locks, repo, func(b *kv.Batch, n int64) error {223 err := createNumbered(ctx, s.db, s.locks, repo, func(b *kv.Batch, n int64) error {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 2

Tags 43

↑↓ moveenter openesc close