test(diff): drop the duplicate changed-line limit test
- commit
- e9b7a51bf1490aa1e199da006e099b79e35da8fa
- author
- brice · · 2026-10-20 05:46 UTC
- committer
- brice · · 2026-10-20 09:12 UTC
- parent
- 03ad5a8
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
2 files · +3 -9
M internal/adapters/gitcli/diff_test.go +0 -8
| @@ -13,7 +13,6 @@ import ( | |||
| 13 | 13 | "github.com/stretchr/testify/require" | |
| 14 | 14 | ||
| 15 | 15 | "bnema.dev/ermite/internal/domain" | |
| 16 | - | "bnema.dev/ermite/internal/ports" | |
| 17 | 16 | "bnema.dev/ermite/internal/readertest" | |
| 18 | 17 | ) | |
| 19 | 18 | ||
| @@ -663,10 +662,3 @@ func TestDiffLimitsWindow(t *testing.T) { | |||
| 663 | 662 | assert.True(t, d.Diff.Truncated) | |
| 664 | 663 | }) | |
| 665 | 664 | } | |
| 666 | - | ||
| 667 | - | func TestDiffChangedLineLimits(t *testing.T) { | |
| 668 | - | readertest.DiffChangedLineLimits(t, func(t *testing.T) (ports.RepoReader, string) { | |
| 669 | - | g, data := newReader(t, nil) | |
| 670 | - | return g, data | |
| 671 | - | }) | |
| 672 | - | } | |
| @@ -13,7 +13,6 @@ import ( | |||||
| 13 | "github.com/stretchr/testify/require" | 13 | "github.com/stretchr/testify/require" | ||
| 14 | 14 | ||||
| 15 | "bnema.dev/ermite/internal/domain" | 15 | "bnema.dev/ermite/internal/domain" | ||
| 16 | - | "bnema.dev/ermite/internal/ports" | |||
| 17 | "bnema.dev/ermite/internal/readertest" | 16 | "bnema.dev/ermite/internal/readertest" | ||
| 18 | ) | 17 | ) | ||
| 19 | 18 | ||||
| @@ -663,10 +662,3 @@ func TestDiffLimitsWindow(t *testing.T) { | |||||
| 663 | assert.True(t, d.Diff.Truncated) | 662 | assert.True(t, d.Diff.Truncated) | ||
| 664 | }) | 663 | }) | ||
| 665 | } | 664 | } | ||
| 666 | - | ||||
| 667 | - | func TestDiffChangedLineLimits(t *testing.T) { | |||
| 668 | - | readertest.DiffChangedLineLimits(t, func(t *testing.T) (ports.RepoReader, string) { | |||
| 669 | - | g, data := newReader(t, nil) | |||
| 670 | - | return g, data | |||
| 671 | - | }) | |||
| 672 | - | } | |||
M internal/domain/budget_test.go +3 -1
| @@ -145,7 +145,9 @@ func TestDiffBudgetContext(t *testing.T) { | |||
| 145 | 145 | if !b.ChargeLine(2, false) || b.FileLines() != 2 { | |
| 146 | 146 | t.Fatal("context consumed changed-line budget") | |
| 147 | 147 | } | |
| 148 | - | if !b.ChargeLine(1, true) || !b.ChargeLine(1, true) || b.FileLines() != 0 { | |
| 148 | + | first := b.ChargeLine(1, true) | |
| 149 | + | second := b.ChargeLine(1, true) | |
| 150 | + | if !first || !second || b.FileLines() != 0 { | |
| 149 | 151 | t.Fatal("additions and deletions must consume changed-line budget") | |
| 150 | 152 | } | |
| 151 | 153 | if !b.ChargeLine(2, false) { | |
| @@ -145,7 +145,9 @@ func TestDiffBudgetContext(t *testing.T) { | |||||
| 145 | if !b.ChargeLine(2, false) || b.FileLines() != 2 { | 145 | if !b.ChargeLine(2, false) || b.FileLines() != 2 { | ||
| 146 | t.Fatal("context consumed changed-line budget") | 146 | t.Fatal("context consumed changed-line budget") | ||
| 147 | } | 147 | } | ||
| 148 | - | if !b.ChargeLine(1, true) || !b.ChargeLine(1, true) || b.FileLines() != 0 { | 148 | + | first := b.ChargeLine(1, true) |
| 149 | + | second := b.ChargeLine(1, true) | |||
| 150 | + | if !first || !second || b.FileLines() != 0 { | |||
| 149 | t.Fatal("additions and deletions must consume changed-line budget") | 151 | t.Fatal("additions and deletions must consume changed-line budget") | ||
| 150 | } | 152 | } | ||
| 151 | if !b.ChargeLine(2, false) { | 153 | if !b.ChargeLine(2, false) { | ||