app_visibility_diff_test.go RawHistoryFolder

1package domain_test
2
3import (
4	"testing"
5
6	"github.com/stretchr/testify/assert"
7
8	"github.com/bnema/gordon/internal/domain"
9)
10
11// TestDiffAppSpec_VisibilityChangeIsDetected proves flipping an interface
12// between public and internal is a meaningful change: it must force a
13// redeploy instead of being silently ignored.
14func TestDiffAppSpec_VisibilityChangeIsDetected(t *testing.T) {
15	desired := visibilitySpec(domain.AppHTTPInterface{Port: 8080, Visibility: domain.AppVisibilityInternal})
16	effective := visibilitySpec(domain.AppHTTPInterface{
17		Host: "blog.example.com", Port: 8080, TLS: "auto", Visibility: domain.AppVisibilityPublic,
18	})
19
20	diff := domain.DiffAppSpec(desired, effective)
21	assert.Contains(t, diff.Changed, "service/web/interfaces")
22}
23
24// TestDiffAppSpec_ZeroVisibilityEqualsPublic proves state written before
25// the visibility field existed (zero value) is not a phantom change
26// against an explicit public interface, so applying an unchanged manifest
27// stays a no-op after upgrade.
28func TestDiffAppSpec_ZeroVisibilityEqualsPublic(t *testing.T) {
29	// Legacy stored state: same interface, visibility never serialized.
30	legacy := visibilitySpec(domain.AppHTTPInterface{
31		Host: "blog.example.com", Port: 8080, TLS: "auto",
32	})
33	desired := visibilitySpec(domain.AppHTTPInterface{
34		Host: "blog.example.com", Port: 8080, TLS: "auto", Visibility: domain.AppVisibilityPublic,
35	})
36
37	diff := domain.DiffAppSpec(desired, legacy)
38	assert.NotContains(t, diff.Changed, "service/web/interfaces")
39}