detached 093ac5a

fix: propagate attachmentEnvDrifted error instead of masking as skip

Previously, env-drift probe failures returned (true, nil), silently
treating errors as 'up to date' and skipping attachment updates.
commit
093ac5a930fcb840ac131887e3b7f31f2c1a0acd
author
brice · · 2026-03-14 20:42 UTC
parent
9ef2c23
signature
unsigned
1 file · +1 -2
M internal/usecase/container/service.go +1 -2
@@ -2172,8 +2172,7 @@ func (s *Service) handleRunningAttachment(ctx context.Context, existing *domain.
21722172 // Check env drift
21732173 envDrifted, err := s.attachmentEnvDrifted(ctx, existing, containerName, serviceImage)
21742174 if err != nil {
2175- log.WrapErr(err, "failed to check attachment env drift")
2176- return true, nil
2175+ return false, log.WrapErr(err, "failed to check attachment env drift")
21772176 }
21782177
21792178 if !envDrifted && !imageDrifted {
@@ -2172,8 +2172,7 @@ func (s *Service) handleRunningAttachment(ctx context.Context, existing *domain.
2172 // Check env drift2172 // Check env drift
2173 envDrifted, err := s.attachmentEnvDrifted(ctx, existing, containerName, serviceImage)2173 envDrifted, err := s.attachmentEnvDrifted(ctx, existing, containerName, serviceImage)
2174 if err != nil {2174 if err != nil {
2175- log.WrapErr(err, "failed to check attachment env drift")2175+ return false, log.WrapErr(err, "failed to check attachment env drift")
2176- return true, nil
2177 }2176 }
2178 2177
2179 if !envDrifted && !imageDrifted {2178 if !envDrifted && !imageDrifted {

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close