detached 2c5325e

fix(container): skip old cleanup on canceled deploy context

commit
2c5325e14b65304c0100328a6bd7659bd8e8bc88
author
brice · · 2026-02-07 20:22 UTC
parent
462b7e2
signature
unsigned
1 file · +6 -0
M internal/usecase/container/service.go +6 -0
@@ -365,6 +365,7 @@ func (s *Service) finalizePreviousContainer(ctx context.Context, domainName stri
365365 if !hasExisting {
366366 return
367367 }
368+ log := zerowrap.FromCtx(ctx)
368369
369370 drainDelay := s.config.DrainDelay
370371 if drainDelay == 0 {
@@ -375,6 +376,11 @@ func (s *Service) finalizePreviousContainer(ctx context.Context, domainName stri
375376 case <-ctx.Done():
376377 }
377378
379+ if err := ctx.Err(); err != nil {
380+ log.Debug().Err(err).Str("domain", domainName).Str("new_container_id", newContainerID).Msg("skipping old container cleanup due to canceled context")
381+ return
382+ }
383+
378384 s.cleanupOldContainer(ctx, existing, newContainerID, domainName)
379385 }
380386
@@ -365,6 +365,7 @@ func (s *Service) finalizePreviousContainer(ctx context.Context, domainName stri
365 if !hasExisting {365 if !hasExisting {
366 return366 return
367 }367 }
368+ log := zerowrap.FromCtx(ctx)
368 369
369 drainDelay := s.config.DrainDelay370 drainDelay := s.config.DrainDelay
370 if drainDelay == 0 {371 if drainDelay == 0 {
@@ -375,6 +376,11 @@ func (s *Service) finalizePreviousContainer(ctx context.Context, domainName stri
375 case <-ctx.Done():376 case <-ctx.Done():
376 }377 }
377 378
379+ if err := ctx.Err(); err != nil {
380+ log.Debug().Err(err).Str("domain", domainName).Str("new_container_id", newContainerID).Msg("skipping old container cleanup due to canceled context")
381+ return
382+ }
383+
378 s.cleanupOldContainer(ctx, existing, newContainerID, domainName)384 s.cleanupOldContainer(ctx, existing, newContainerID, domainName)
379 }385 }
380 386

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close