detached 4117ca5

refactor(proxy): remove unused ExposeContainerID config field

commit
4117ca55550deee4cc5ad661ba82f7d91f300189
author
bnema · · 2026-01-18 02:24 UTC
parent
c37592d
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +0 -8
M internal/usecase/proxy/service.go +0 -8
@@ -39,9 +39,6 @@ var proxyTransport = &http.Transport{
3939 type Config struct {
4040 RegistryDomain string
4141 RegistryPort int
42- // ExposeContainerID controls whether to add X-Container-ID header to responses.
43- // Default: false (disabled for security - prevents container enumeration)
44- ExposeContainerID bool
4542 }
4643
4744 // Service implements the ProxyService interface.
@@ -325,11 +322,6 @@ func (s *Service) proxyToTarget(w http.ResponseWriter, r *http.Request, target *
325322 },
326323 func(resp *http.Response) error {
327324 resp.Header.Set("X-Proxied-By", "Gordon")
328- // SECURITY: Only expose container ID if explicitly enabled
329- // This prevents container enumeration attacks
330- if s.config.ExposeContainerID && target.ContainerID != "" {
331- resp.Header.Set("X-Container-ID", target.ContainerID)
332- }
333325 return nil
334326 },
335327 )
@@ -39,9 +39,6 @@ var proxyTransport = &http.Transport{
39 type Config struct {39 type Config struct {
40 RegistryDomain string40 RegistryDomain string
41 RegistryPort int41 RegistryPort int
42- // ExposeContainerID controls whether to add X-Container-ID header to responses.
43- // Default: false (disabled for security - prevents container enumeration)
44- ExposeContainerID bool
45 }42 }
46 43
47 // Service implements the ProxyService interface.44 // Service implements the ProxyService interface.
@@ -325,11 +322,6 @@ func (s *Service) proxyToTarget(w http.ResponseWriter, r *http.Request, target *
325 },322 },
326 func(resp *http.Response) error {323 func(resp *http.Response) error {
327 resp.Header.Set("X-Proxied-By", "Gordon")324 resp.Header.Set("X-Proxied-By", "Gordon")
328- // SECURITY: Only expose container ID if explicitly enabled
329- // This prevents container enumeration attacks
330- if s.config.ExposeContainerID && target.ContainerID != "" {
331- resp.Header.Set("X-Container-ID", target.ContainerID)
332- }
333 return nil325 return nil
334 },326 },
335 )327 )

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 8

Tags 106

↑↓ moveenter openesc close