fix: handle StopContainer error in attachment readiness rollback

Satisfies errcheck linter — log warning on stop failure during cleanup.

commit: a76d51fc82bc31af5c69e31159d2372968dc3676
author: brice · 7mo ago · 2026-03-23 19:15 UTC
parent: c151e54
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +3 -1

M internal/usecase/container/service.go +3 -1


@@ -2283,7 +2283,9 @@ func (s *Service) deployAttachedService(ctx context.Context, ownerDomain, servic
2283	2283		// Wait for attachment to be ready before proceeding
2284	2284		if err := s.waitForAttachmentReady(ctx, container.ID, config); err != nil {
2285	2285		log.WrapErr(err, "attachment readiness check failed, cleaning up")
2286		-	s.runtime.StopContainer(ctx, container.ID)
	2286	+	if stopErr := s.runtime.StopContainer(ctx, container.ID); stopErr != nil {
	2287	+	log.Warn().Err(stopErr).Str(zerowrap.FieldEntityID, container.ID).Msg("failed to stop unready attachment")
	2288	+	}
2287	2289		s.runtime.RemoveContainer(ctx, container.ID, true)
2288	2290		return fmt.Errorf("attachment %q not ready: %w", serviceName, err)
2289	2291		}

 	// Wait for attachment to be ready before proceeding
 	if err := s.waitForAttachmentReady(ctx, container.ID, config); err != nil {
 		log.WrapErr(err, "attachment readiness check failed, cleaning up")
-		s.runtime.StopContainer(ctx, container.ID)
+		if stopErr := s.runtime.StopContainer(ctx, container.ID); stopErr != nil {
+			log.Warn().Err(stopErr).Str(zerowrap.FieldEntityID, container.ID).Msg("failed to stop unready attachment")
+		}
 		s.runtime.RemoveContainer(ctx, container.ID, true)
 		return fmt.Errorf("attachment %q not ready: %w", serviceName, err)
 	}