detached ae4cf2c

feat(preview): remove routes from config on preview TTL expiry

commit
ae4cf2c5377378d90ceac02e7325a9279cb4bca4
author
brice · · 2026-03-18 17:25 UTC
committer
brice · · 2026-03-18 21:42 UTC
parent
76b1eb4
signature
unsigned
1 file · +4 -0
M internal/app/run.go +4 -0
@@ -596,6 +596,10 @@ func initPreviewService(ctx context.Context, cfg Config, svc *services, log zero
596596 log.Warn().Err(err).Str("volume", volName).Str("preview", p.Domain).Msg("failed to remove preview volume")
597597 }
598598 }
599+ // Remove route from config so proxy stops routing to this domain
600+ if err := svc.configSvc.RemoveRoute(ctx, p.Domain); err != nil {
601+ log.Debug().Err(err).Str("domain", p.Domain).Msg("preview route already removed from config")
602+ }
599603 svc.proxySvc.InvalidateTarget(ctx, p.Domain)
600604 })
601605 }
@@ -596,6 +596,10 @@ func initPreviewService(ctx context.Context, cfg Config, svc *services, log zero
596 log.Warn().Err(err).Str("volume", volName).Str("preview", p.Domain).Msg("failed to remove preview volume")596 log.Warn().Err(err).Str("volume", volName).Str("preview", p.Domain).Msg("failed to remove preview volume")
597 }597 }
598 }598 }
599+ // Remove route from config so proxy stops routing to this domain
600+ if err := svc.configSvc.RemoveRoute(ctx, p.Domain); err != nil {
601+ log.Debug().Err(err).Str("domain", p.Domain).Msg("preview route already removed from config")
602+ }
599 svc.proxySvc.InvalidateTarget(ctx, p.Domain)603 svc.proxySvc.InvalidateTarget(ctx, p.Domain)
600 })604 })
601 }605 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close