fix(security): require explicit opt-in for unsafe token store

commit: b77f360b73793cbc87e4300c9266294cb03f0a63
author: bnema · 9mo ago · 2026-01-17 20:56 UTC
parent: 9cc9012
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

2 files · +21 -4

M internal/adapters/out/tokenstore/store.go +1 -1


@@ -28,7 +28,7 @@ func NewStore(backend domain.SecretsBackend, dataDir string, log zerowrap.Logger
28	28		if dataDir == "" {
29	29		return nil, fmt.Errorf("data_dir is required for unsafe backend")
30	30		}
31		-	return NewUnsafeStore(dataDir, log), nil
	31	+	return NewUnsafeStore(dataDir, log)
32	32
33	33		default:
34	34		return nil, fmt.Errorf("unknown secrets backend: %s", backend)


@@ -28,7 +28,7 @@ func NewStore(backend domain.SecretsBackend, dataDir string, log zerowrap.Logger
28		if dataDir == "" {	28		if dataDir == "" {
29		return nil, fmt.Errorf("data_dir is required for unsafe backend")	29		return nil, fmt.Errorf("data_dir is required for unsafe backend")
30		}	30		}
31	-	return NewUnsafeStore(dataDir, log), nil	31	+	return NewUnsafeStore(dataDir, log)
32			32
33		default:	33		default:
34		return nil, fmt.Errorf("unknown secrets backend: %s", backend)	34		return nil, fmt.Errorf("unknown secrets backend: %s", backend)

M internal/adapters/out/tokenstore/unsafe.go +20 -3


@@ -29,6 +29,10 @@ const (
29	29		unsafeRevokedFile = "secrets/gordon/registry/revoked.json"
30	30		)
31	31
	32	+	// UnsafeEnvVar is the environment variable that must be set to "true"
	33	+	// to enable the unsafe token store.
	34	+	const UnsafeEnvVar = "GORDON_ALLOW_UNSAFE_SECRETS"
	35	+
32	36		// UnsafeStore implements TokenStore using plain text files.
33	37		// WARNING: This store does not encrypt secrets. Only use when pass/sops are unavailable.
34	38		type UnsafeStore struct {

@@ -38,7 +42,20 @@ type UnsafeStore struct {
38	42
39	43		// NewUnsafeStore creates a new file-based token store.
40	44		// dataDir is the base directory for storing secrets (typically gordon's data_dir).
41		-	func NewUnsafeStore(dataDir string, log zerowrap.Logger) *UnsafeStore {
	45	+	//
	46	+	// SECURITY: Requires GORDON_ALLOW_UNSAFE_SECRETS=true environment variable.
	47	+	// Returns an error if the environment variable is not set, preventing
	48	+	// accidental use of plaintext secret storage in production.
	49	+	func NewUnsafeStore(dataDir string, log zerowrap.Logger) (*UnsafeStore, error) {
	50	+	// SECURITY: Require explicit opt-in for plaintext storage
	51	+	if os.Getenv(UnsafeEnvVar) != "true" {
	52	+	return nil, fmt.Errorf(
	53	+	"unsafe token store is disabled by default; "+
	54	+	"set %s=true to enable plaintext secret storage (NOT recommended for production)",
	55	+	UnsafeEnvVar,
	56	+	)
	57	+	}
	58	+
42	59		store := &UnsafeStore{
43	60		dataDir: dataDir,
44	61		log: log,

@@ -49,9 +66,9 @@ func NewUnsafeStore(dataDir string, log zerowrap.Logger) *UnsafeStore {
49	66		Str(zerowrap.FieldAdapter, "tokenstore").
50	67		Str("provider", "unsafe").
51	68		Str("data_dir", dataDir).
52		-	Msg("using unsafe secrets backend - secrets are stored in plain text")
	69	+	Msg("SECURITY WARNING: using unsafe secrets backend - secrets are stored in plain text")
53	70
54		-	return store
	71	+	return store, nil
55	72		}
56	73
57	74		// unsafeTokenData holds both JWT and metadata in a single file.

 	unsafeRevokedFile = "secrets/gordon/registry/revoked.json"
 )
+// UnsafeEnvVar is the environment variable that must be set to "true"
+// to enable the unsafe token store.
+const UnsafeEnvVar = "GORDON_ALLOW_UNSAFE_SECRETS"
 // UnsafeStore implements TokenStore using plain text files.
 // WARNING: This store does not encrypt secrets. Only use when pass/sops are unavailable.
 type UnsafeStore struct {
 // NewUnsafeStore creates a new file-based token store.
 // dataDir is the base directory for storing secrets (typically gordon's data_dir).
-func NewUnsafeStore(dataDir string, log zerowrap.Logger) *UnsafeStore {
+//
+// SECURITY: Requires GORDON_ALLOW_UNSAFE_SECRETS=true environment variable.
+// Returns an error if the environment variable is not set, preventing
+// accidental use of plaintext secret storage in production.
+func NewUnsafeStore(dataDir string, log zerowrap.Logger) (*UnsafeStore, error) {
+	// SECURITY: Require explicit opt-in for plaintext storage
+	if os.Getenv(UnsafeEnvVar) != "true" {
+		return nil, fmt.Errorf(
+			"unsafe token store is disabled by default; "+
+				"set %s=true to enable plaintext secret storage (NOT recommended for production)",
+			UnsafeEnvVar,
+		)
+	}
 	store := &UnsafeStore{
 		dataDir: dataDir,
 		log:     log,
 		Str(zerowrap.FieldAdapter, "tokenstore").
 		Str("provider", "unsafe").
 		Str("data_dir", dataDir).
-		Msg("using unsafe secrets backend - secrets are stored in plain text")
+		Msg("SECURITY WARNING: using unsafe secrets backend - secrets are stored in plain text")
-	return store
+	return store, nil
 }
 // unsafeTokenData holds both JWT and metadata in a single file.