detached bac4edd

Implement a retry mechanism in case of very slow response from the htmx routes

commit
bac4edd8ce307893e52b59eb19b2eef34e171fe7
author
bnema · · 2023-11-04 09:17 UTC
parent
61c96d2
signature
unsigned
1 file · +11 -4
M internal/httpserve/middleware/requirelogin.go +11 -4
@@ -15,14 +15,21 @@ import (
1515 func RequireLogin(a *server.App) echo.MiddlewareFunc {
1616 return func(next echo.HandlerFunc) echo.HandlerFunc {
1717 return func(c echo.Context) error {
18- if err := validateSessionAndUser(c, a); err != nil {
19- return c.JSON(401, map[string]string{"error": err.Error()})
18+ const maxRetries = 3
19+ var err error
20+ for i := 0; i < maxRetries; i++ {
21+ err = validateSessionAndUser(c, a)
22+ if err == nil {
23+ return next(c)
24+ }
25+ if i < maxRetries-1 {
26+ time.Sleep(time.Duration(i+1) * 500 * time.Millisecond)
27+ }
2028 }
21- return next(c)
29+ return c.JSON(401, map[string]string{"error": err.Error()})
2230 }
2331 }
2432 }
25-
2633 func validateSessionAndUser(c echo.Context, a *server.App) error {
2734 sessionExpiryTime := 30 * time.Minute
2835
@@ -15,14 +15,21 @@ import (
15 func RequireLogin(a *server.App) echo.MiddlewareFunc {15 func RequireLogin(a *server.App) echo.MiddlewareFunc {
16 return func(next echo.HandlerFunc) echo.HandlerFunc {16 return func(next echo.HandlerFunc) echo.HandlerFunc {
17 return func(c echo.Context) error {17 return func(c echo.Context) error {
18- if err := validateSessionAndUser(c, a); err != nil {18+ const maxRetries = 3
19- return c.JSON(401, map[string]string{"error": err.Error()})19+ var err error
20+ for i := 0; i < maxRetries; i++ {
21+ err = validateSessionAndUser(c, a)
22+ if err == nil {
23+ return next(c)
24+ }
25+ if i < maxRetries-1 {
26+ time.Sleep(time.Duration(i+1) * 500 * time.Millisecond)
27+ }
20 }28 }
21- return next(c)29+ return c.JSON(401, map[string]string{"error": err.Error()})
22 }30 }
23 }31 }
24 }32 }
25-
26 func validateSessionAndUser(c echo.Context, a *server.App) error {33 func validateSessionAndUser(c echo.Context, a *server.App) error {
27 sessionExpiryTime := 30 * time.Minute34 sessionExpiryTime := 30 * time.Minute
28 35

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close