detached cdeffe2

fix(cli): log panic in token refresh callback instead of silently discarding

commit
cdeffe2e5c665bf56298969de5b411ec187b1199
author
bnema · · 2026-02-25 01:32 UTC
parent
2cd6dfb
signature
unsigned
1 file · +5 -1
M internal/adapters/in/cli/remote/client.go +5 -1
@@ -162,7 +162,11 @@ func (c *Client) request(ctx context.Context, method, path string, body any) (*h
162162 if c.onTokenRefreshed != nil {
163163 // Token persistence is non-fatal: a panic in the callback must not crash the request.
164164 func() {
165- defer func() { recover() }() //nolint:errcheck
165+ defer func() {
166+ if r := recover(); r != nil {
167+ fmt.Fprintf(os.Stderr, "warning: token refresh callback panicked: %v\n", r)
168+ }
169+ }()
166170 c.onTokenRefreshed(newToken)
167171 }()
168172 }
@@ -162,7 +162,11 @@ func (c *Client) request(ctx context.Context, method, path string, body any) (*h
162 if c.onTokenRefreshed != nil {162 if c.onTokenRefreshed != nil {
163 // Token persistence is non-fatal: a panic in the callback must not crash the request.163 // Token persistence is non-fatal: a panic in the callback must not crash the request.
164 func() {164 func() {
165- defer func() { recover() }() //nolint:errcheck165+ defer func() {
166+ if r := recover(); r != nil {
167+ fmt.Fprintf(os.Stderr, "warning: token refresh callback panicked: %v\n", r)
168+ }
169+ }()
166 c.onTokenRefreshed(newToken)170 c.onTokenRefreshed(newToken)
167 }()171 }()
168 }172 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close