detached cf696fb

fix(cli): filter preview routes from image route resolution

Preview domains (containing "--") were appearing in the route
selector when pushing base images, causing confusion.
commit
cf696fbe25ee759af522c7b700c2a83aa5bb7dbf
author
brice · · 2026-03-18 17:52 UTC
committer
brice · · 2026-03-18 18:15 UTC
parent
515e15b
signature
unsigned
1 file · +10 -0
M internal/adapters/in/cli/push.go +10 -0
@@ -276,6 +276,16 @@ func resolveFromImage(ctx context.Context, cp ControlPlane, imageArg, dockerfile
276276 return "", "", "", fmt.Errorf("failed to find routes for image %q: %w", imageArg, err)
277277 }
278278
279+ // Filter out preview routes (domains containing "--") so they don't
280+ // pollute the selection when pushing the base image.
281+ filtered := routes[:0]
282+ for _, r := range routes {
283+ if !strings.Contains(r.Domain, "--") {
284+ filtered = append(filtered, r)
285+ }
286+ }
287+ routes = filtered
288+
279289 if len(routes) == 0 {
280290 // bootstrap command is registered in bootstrap.go (see issue #98)
281291 return "", "", "", fmt.Errorf(
@@ -276,6 +276,16 @@ func resolveFromImage(ctx context.Context, cp ControlPlane, imageArg, dockerfile
276 return "", "", "", fmt.Errorf("failed to find routes for image %q: %w", imageArg, err)276 return "", "", "", fmt.Errorf("failed to find routes for image %q: %w", imageArg, err)
277 }277 }
278 278
279+ // Filter out preview routes (domains containing "--") so they don't
280+ // pollute the selection when pushing the base image.
281+ filtered := routes[:0]
282+ for _, r := range routes {
283+ if !strings.Contains(r.Domain, "--") {
284+ filtered = append(filtered, r)
285+ }
286+ }
287+ routes = filtered
288+
279 if len(routes) == 0 {289 if len(routes) == 0 {
280 // bootstrap command is registered in bootstrap.go (see issue #98)290 // bootstrap command is registered in bootstrap.go (see issue #98)
281 return "", "", "", fmt.Errorf(291 return "", "", "", fmt.Errorf(

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 7

Tags 106

↑↓ moveenter openesc close