skip to content

detached 7839b6b

test(ui): skip the allocation guard under the race detector

commit: 7839b6b350ade1912b051902c1dd72cdf2b2f140
author: brice · 21d ago · 2026-10-01 16:33 UTC
parent: ee44fbd
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

3 files · +14 -0

A internal/ui/race_off_test.go +5 -0

@@ -0,0 +1,5 @@
	1	+	//go:build !race
	2	+
	3	+	package ui
	4	+
	5	+	const raceEnabled = false

@@ -0,0 +1,5 @@
			1	+	//go:build !race
			2	+
			3	+	package ui
			4	+
			5	+	const raceEnabled = false

A internal/ui/race_on_test.go +6 -0

@@ -0,0 +1,6 @@
	1	+	//go:build race
	2	+
	3	+	package ui
	4	+
	5	+	// raceEnabled: the race detector adds allocations, so alloc guards skip.
	6	+	const raceEnabled = true

@@ -0,0 +1,6 @@
			1	+	//go:build race
			2	+
			3	+	package ui
			4	+
			5	+	// raceEnabled: the race detector adds allocations, so alloc guards skip.
			6	+	const raceEnabled = true

M internal/ui/renderer_gpu_test.go +3 -0


@@ -189,6 +189,9 @@ const allocBaselineRenderer = 244
189	189		// changes on every frame and an unchanged structure. It runs on the real GPU
190	190		// path because testify mocks would allocate.
191	191		func TestAllocRendererSteadyFrame(t *testing.T) {
	192	+	if raceEnabled {
	193	+	t.Skip("race instrumentation changes allocation counts")
	194	+	}
192	195		r, tg := gpuRenderer(t)
193	196		var out Output
194	197		n := 0


@@ -189,6 +189,9 @@ const allocBaselineRenderer = 244
189		// changes on every frame and an unchanged structure. It runs on the real GPU	189		// changes on every frame and an unchanged structure. It runs on the real GPU
190		// path because testify mocks would allocate.	190		// path because testify mocks would allocate.
191		func TestAllocRendererSteadyFrame(t *testing.T) {	191		func TestAllocRendererSteadyFrame(t *testing.T) {
			192	+	if raceEnabled {
			193	+	t.Skip("race instrumentation changes allocation counts")
			194	+	}
192		r, tg := gpuRenderer(t)	195		r, tg := gpuRenderer(t)
193		var out Output	196		var out Output
194		n := 0	197		n := 0