detached 20eb377

test(logging): table the owner of each narrow category

commit
20eb377c958997278b003297dc622cebf065294a
author
brice · · 2026-10-13 17:58 UTC
committer
brice · · 2026-10-14 04:34 UTC
parent
9577230
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +5 -3
M internal/adapters/logging/logging_test.go +5 -3
@@ -168,10 +168,12 @@ func TestLogWriteNeverBlocksOnSlowDisk(t *testing.T) {
168168
169169 // Narrow categories are on only when named, never through "all".
170170 func TestEnabledCategories(t *testing.T) {
171- for _, category := range []string{"input-motion", "input-keys", "drm-flip", "wayland-damage", "render-damage"} {
171+ // The component each narrow category logs under; "" is not asserted.
172+ owners := map[string]string{"input-motion": "", "input-keys": "", "drm-flip": "", "wayland-damage": "wayland", "render-damage": "render"}
173+ for category, owner := range owners {
172174 component := categories[category]
173- if category == "wayland-damage" && component != "wayland" || category == "render-damage" && component != "render" {
174- t.Errorf("%s belongs to %q", category, component)
175+ if owner != "" && component != owner {
176+ t.Errorf("%s belongs to %q, want %q", category, component, owner)
175177 }
176178 for _, tc := range []struct {
177179 debug string
@@ -168,10 +168,12 @@ func TestLogWriteNeverBlocksOnSlowDisk(t *testing.T) {
168 168
169 // Narrow categories are on only when named, never through "all".169 // Narrow categories are on only when named, never through "all".
170 func TestEnabledCategories(t *testing.T) {170 func TestEnabledCategories(t *testing.T) {
171- for _, category := range []string{"input-motion", "input-keys", "drm-flip", "wayland-damage", "render-damage"} {171+ // The component each narrow category logs under; "" is not asserted.
172+ owners := map[string]string{"input-motion": "", "input-keys": "", "drm-flip": "", "wayland-damage": "wayland", "render-damage": "render"}
173+ for category, owner := range owners {
172 component := categories[category]174 component := categories[category]
173- if category == "wayland-damage" && component != "wayland" || category == "render-damage" && component != "render" {175+ if owner != "" && component != owner {
174- t.Errorf("%s belongs to %q", category, component)176+ t.Errorf("%s belongs to %q, want %q", category, component, owner)
175 }177 }
176 for _, tc := range []struct {178 for _, tc := range []struct {
177 debug string179 debug string

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 23

Tags 10

↑↓ moveenter openesc close