detached c821b80

fix(drm): no VRR-off retry loop while switched away

commit
c821b809446578518246a10a20af5098fc19ebfd
author
brice · · 2026-09-25 18:04 UTC
parent
19dda7c
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -2
M internal/adapters/drm/output.go +4 -2
@@ -295,14 +295,16 @@ func (o *Output) Run(ctx context.Context, newRenderer func(w, h int) (ports.Rend
295295 }
296296 // A composed screen that stopped changing still drops VRR on time.
297297 var vrrOff <-chan time.Time
298- if o.vrrOn && !o.composedSince.IsZero() {
298+ if enabled && o.vrrOn && !o.composedSince.IsZero() {
299299 vrrOff = time.After(max(0, vrrHold-time.Since(o.composedSince)))
300300 }
301301 select {
302302 case <-retry:
303303 continue
304304 case <-vrrOff:
305- o.setVRR(false)
305+ if o.setVRR(false); o.vrrOn {
306+ o.composedSince = time.Now() // failed: retry later, not in a loop
307+ }
306308 continue
307309 case <-ctx.Done():
308310 return nil
@@ -295,14 +295,16 @@ func (o *Output) Run(ctx context.Context, newRenderer func(w, h int) (ports.Rend
295 }295 }
296 // A composed screen that stopped changing still drops VRR on time.296 // A composed screen that stopped changing still drops VRR on time.
297 var vrrOff <-chan time.Time297 var vrrOff <-chan time.Time
298- if o.vrrOn && !o.composedSince.IsZero() {298+ if enabled && o.vrrOn && !o.composedSince.IsZero() {
299 vrrOff = time.After(max(0, vrrHold-time.Since(o.composedSince)))299 vrrOff = time.After(max(0, vrrHold-time.Since(o.composedSince)))
300 }300 }
301 select {301 select {
302 case <-retry:302 case <-retry:
303 continue303 continue
304 case <-vrrOff:304 case <-vrrOff:
305- o.setVRR(false)305+ if o.setVRR(false); o.vrrOn {
306+ o.composedSince = time.Now() // failed: retry later, not in a loop
307+ }
306 continue308 continue
307 case <-ctx.Done():309 case <-ctx.Done():
308 return nil310 return nil

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 23

Tags 10

↑↓ moveenter openesc close