skip to content

detached e1de5a5

test(xwm): replace the sinkPeer sleep with a peer lock barrier

commit: e1de5a53cadd0d5f9ade1dd51cd0dd4decabc9c3
author: brice · 23h ago · 2026-10-22 13:24 UTC
committer: brice · 19h ago · 2026-10-22 17:54 UTC
parent: 9439437
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +5 -0

M internal/adapters/wayland/xwm/configure_test.go +5 -0


@@ -511,6 +511,11 @@ func sinkPeer(t testing.T, x XWM, p *xpeer) {
511	511		xproto.GetInputFocus(x.conn.Buf()) // served by the old loop iteration
512	512		require.NoError(t, x.conn.Flush())
513	513		p.waitReq(n, func(r xpeerReq) bool { return r.major == opGetInputFocus })
	514	+	// The peer records a request and answers it under mu: once the lock is
	515	+	// free again it is back in its sink loop, which does not allocate.
	516	+	p.mu.Lock()
	517	+	_ = p.seq
	518	+	p.mu.Unlock()
514	519		x.src = nil // no source: write backpressure would not allocate either
515	520		x.post = func(func()) {}
516	521		x.warnedRing = true // the sink never answers: Expect slots stay used


@@ -511,6 +511,11 @@ func sinkPeer(t testing.T, x XWM, p *xpeer) {
511		xproto.GetInputFocus(x.conn.Buf()) // served by the old loop iteration	511		xproto.GetInputFocus(x.conn.Buf()) // served by the old loop iteration
512		require.NoError(t, x.conn.Flush())	512		require.NoError(t, x.conn.Flush())
513		p.waitReq(n, func(r xpeerReq) bool { return r.major == opGetInputFocus })	513		p.waitReq(n, func(r xpeerReq) bool { return r.major == opGetInputFocus })
			514	+	// The peer records a request and answers it under mu: once the lock is
			515	+	// free again it is back in its sink loop, which does not allocate.
			516	+	p.mu.Lock()
			517	+	_ = p.seq
			518	+	p.mu.Unlock()
514		x.src = nil // no source: write backpressure would not allocate either	519		x.src = nil // no source: write backpressure would not allocate either
515		x.post = func(func()) {}	520		x.post = func(func()) {}
516		x.warnedRing = true // the sink never answers: Expect slots stay used	521		x.warnedRing = true // the sink never answers: Expect slots stay used