detached e6d2caf

test(busretry): stop attempts from blocking on a full channel after cancel

commit
e6d2caf1de9cb0c1866d7244eac06f071d725e57
author
brice · · 2026-10-08 19:54 UTC
parent
412bdb0
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +4 -1
M internal/adapters/busretry/busretry_test.go +4 -1
@@ -20,7 +20,10 @@ func TestRunRetriesUntilCancelled(t *testing.T) {
2020 defer close(done)
2121 Run(ctx, time.Millisecond, "test feature", logging.For(ctx, "test"), func(context.Context) error {
2222 n++
23- calls <- n
23+ select {
24+ case calls <- n:
25+ case <-ctx.Done():
26+ }
2427 if n%2 == 0 {
2528 return nil
2629 }
@@ -20,7 +20,10 @@ func TestRunRetriesUntilCancelled(t *testing.T) {
20 defer close(done)20 defer close(done)
21 Run(ctx, time.Millisecond, "test feature", logging.For(ctx, "test"), func(context.Context) error {21 Run(ctx, time.Millisecond, "test feature", logging.For(ctx, "test"), func(context.Context) error {
22 n++22 n++
23- calls <- n23+ select {
24+ case calls <- n:
25+ case <-ctx.Done():
26+ }
24 if n%2 == 0 {27 if n%2 == 0 {
25 return nil28 return nil
26 }29 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 23

Tags 10

↑↓ moveenter openesc close