main fdd661a

#23 refactor(drm): remove the Vulkan-export fallback for output images

state
open
opened
bnema ·
updated

Context

DRM output images are allocated with GBM and imported into Vulkan. For each image kind (driver modifier, single-plane, linear), the renderer's own Vulkan export is kept as a fallback when GBM is missing, fails, or its images are refused (exportImages and the fallback branch of setupImages in internal/adapters/drm/images.go). The Vulkan export path corrupts scanout on nvidia-drm.

The fallback stays while GBM is validated on few setups (amdgpu, one nvidia-drm machine). It logs a warning with "alloc":"vulkan" when it is used.

Remove when

No report shows the zero-copy output line with "alloc":"vulkan" for a few releases, including Intel and multi-GPU setups.

Scope

  • Remove exportImages and the Vulkan branch of setupImages; a GBM failure for every kind then fails the output.
  • Keep Renderer.ExportTargets: the headless backend uses it.
  • Update docs/dev/architecture.md (Output images, Fallback).

Comments0

no comments yet.

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 24

Tags 10

↑↓ moveenter openesc close