detached 1512f32

internal/fakecgo: remove runtime.load_g references (#456)

Go 1.27 (golang/go@aee6009) enforces stricter checklinkname for
assembly symbols. runtime.load_g is now //go:linknamestd (std-only),
causing linker errors for non-std packages that reference it.

In crosscall2, the load_g call is unnecessary because
runtime.cgocallback already calls load_g internally. Remove it from
all 6 architectures that had it (arm, arm64, loong64, ppc64le,
riscv64, s390x). The amd64 and 386 variants already did not call it.

In setg_trampoline on ppc64le, replace the load_g call with a direct
assignment to the g register from the saved newg argument, since
setg_gcc has already stored it into TLS.

This resolves the runtime.load_g linker error. The runtime.cgocallback
reference remains and will need an upstream Go change or the
-ldflags='-checklinkname=0' workaround until then.

Updates #455
commit
1512f327e9958354283654ee4497800e33a7b838
author
George Adams · · 2026-05-27 13:07 UTC
committer
GitHub · · 2026-05-27 13:07 UTC
parent
11272d2
signature
GPG UnverifiedB5690EEEBB952194 The key is unknown
7 files · +6 -14
Split
UnifiedSplit
M internal/fakecgo/asm_arm.s +0 -2
@@ -32,8 +32,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
3232 MOVD F14, (13*4+8*7)(R13)
3333 MOVD F15, (13*4+8*8)(R13)
3434
35- BL runtime·load_g(SB)
36-
3735 // We set up the arguments to cgocallback when saving registers above.
3836 BL runtime·cgocallback(SB)
3937
@@ -32,8 +32,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
32 MOVD F14, (13*4+8*7)(R13)32 MOVD F14, (13*4+8*7)(R13)
33 MOVD F15, (13*4+8*8)(R13)33 MOVD F15, (13*4+8*8)(R13)
34 34
35- BL runtime·load_g(SB)
36-
37 // We set up the arguments to cgocallback when saving registers above.35 // We set up the arguments to cgocallback when saving registers above.
38 BL runtime·cgocallback(SB)36 BL runtime·cgocallback(SB)
39 37
M internal/fakecgo/asm_arm64.s +0 -1
@@ -25,7 +25,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
2525 STP (R29, R30), (8*22)(RSP)
2626
2727 // Initialize Go ABI environment
28- BL runtime·load_g(SB)
2928 BL runtime·cgocallback(SB)
3029
3130 RESTORE_R19_TO_R28(8*4)
@@ -25,7 +25,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
25 STP (R29, R30), (8*22)(RSP)25 STP (R29, R30), (8*22)(RSP)
26 26
27 // Initialize Go ABI environment27 // Initialize Go ABI environment
28- BL runtime·load_g(SB)
29 BL runtime·cgocallback(SB)28 BL runtime·cgocallback(SB)
30 29
31 RESTORE_R19_TO_R28(8*4)30 RESTORE_R19_TO_R28(8*4)
M internal/fakecgo/asm_loong64.s +0 -2
@@ -27,8 +27,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
2727 MOVV R1, (22*8)(R3)
2828
2929 // Initialize Go ABI environment
30- JAL runtime·load_g(SB)
31-
3230 JAL runtime·cgocallback(SB)
3331
3432 RESTORE_R22_TO_R31((4*8))
@@ -27,8 +27,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
27 MOVV R1, (22*8)(R3)27 MOVV R1, (22*8)(R3)
28 28
29 // Initialize Go ABI environment29 // Initialize Go ABI environment
30- JAL runtime·load_g(SB)
31-
32 JAL runtime·cgocallback(SB)30 JAL runtime·cgocallback(SB)
33 31
34 RESTORE_R22_TO_R31((4*8))32 RESTORE_R22_TO_R31((4*8))
M internal/fakecgo/asm_ppc64le.s +0 -3
@@ -50,9 +50,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
5050 // Initialize R0 to 0 as expected by Go
5151 MOVD $0, R0
5252
53- // Load the current g.
54- BL runtime·load_g(SB)
55-
5653 // Set up arguments for cgocallback
5754 MOVD R3, FIXED_FRAME+0(R1) // fn unsafe.Pointer
5855 MOVD R4, FIXED_FRAME+8(R1) // a unsafe.Pointer
@@ -50,9 +50,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
50 // Initialize R0 to 0 as expected by Go50 // Initialize R0 to 0 as expected by Go
51 MOVD $0, R051 MOVD $0, R0
52 52
53- // Load the current g.
54- BL runtime·load_g(SB)
55-
56 // Set up arguments for cgocallback53 // Set up arguments for cgocallback
57 MOVD R3, FIXED_FRAME+0(R1) // fn unsafe.Pointer54 MOVD R3, FIXED_FRAME+0(R1) // fn unsafe.Pointer
58 MOVD R4, FIXED_FRAME+8(R1) // a unsafe.Pointer55 MOVD R4, FIXED_FRAME+8(R1) // a unsafe.Pointer
M internal/fakecgo/asm_riscv64.s +0 -1
@@ -25,7 +25,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
2525 SAVE_FPR((8*17))
2626
2727 // Initialize Go ABI environment
28- CALL runtime·load_g(SB)
2928 CALL runtime·cgocallback(SB)
3029
3130 RESTORE_GPR((8*4))
@@ -25,7 +25,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
25 SAVE_FPR((8*17))25 SAVE_FPR((8*17))
26 26
27 // Initialize Go ABI environment27 // Initialize Go ABI environment
28- CALL runtime·load_g(SB)
29 CALL runtime·cgocallback(SB)28 CALL runtime·cgocallback(SB)
30 29
31 RESTORE_GPR((8*4))30 RESTORE_GPR((8*4))
M internal/fakecgo/asm_s390x.s +0 -3
@@ -27,9 +27,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
2727 FMOVD F14, 80(R15)
2828 FMOVD F15, 88(R15)
2929
30- // Initialize Go ABI environment.
31- BL runtime·load_g(SB)
32-
3330 MOVD R2, 8(R15) // fn unsafe.Pointer
3431 MOVD R3, 16(R15) // a unsafe.Pointer
3532
@@ -27,9 +27,6 @@ TEXT crosscall2(SB), NOSPLIT|NOFRAME, $0
27 FMOVD F14, 80(R15)27 FMOVD F14, 80(R15)
28 FMOVD F15, 88(R15)28 FMOVD F15, 88(R15)
29 29
30- // Initialize Go ABI environment.
31- BL runtime·load_g(SB)
32-
33 MOVD R2, 8(R15) // fn unsafe.Pointer30 MOVD R2, 8(R15) // fn unsafe.Pointer
34 MOVD R3, 16(R15) // a unsafe.Pointer31 MOVD R3, 16(R15) // a unsafe.Pointer
35 32
M internal/fakecgo/trampolines_ppc64le.s +6 -2
@@ -47,15 +47,19 @@ TEXT x_cgo_bindm_trampoline(SB), NOSPLIT, $0-0
4747
4848 // func setg_trampoline(setg uintptr, g uintptr)
4949 TEXT ·setg_trampoline(SB), NOSPLIT, $16-16
50- MOVD R31, 8(R1) // save R31 (load_g clobbers it)
50+ MOVD R31, 8(R1) // save R31
5151
5252 MOVD setg+0(FP), R12
5353 MOVD newg+8(FP), R3
5454
55+ MOVD R3, 16(R1) // save newg before call
56+
5557 MOVD R12, CTR
5658 CALL CTR
5759
58- CALL runtime·load_g(SB)
60+ // Assign g directly instead of calling runtime·load_g
61+ // setg_gcc has already stored newg into TLS; put it in the g register too.
62+ MOVD 16(R1), g
5963
6064 MOVD 8(R1), R31
6165 XOR R0, R0, R0
@@ -47,15 +47,19 @@ TEXT x_cgo_bindm_trampoline(SB), NOSPLIT, $0-0
47 47
48 // func setg_trampoline(setg uintptr, g uintptr)48 // func setg_trampoline(setg uintptr, g uintptr)
49 TEXT ·setg_trampoline(SB), NOSPLIT, $16-1649 TEXT ·setg_trampoline(SB), NOSPLIT, $16-16
50- MOVD R31, 8(R1) // save R31 (load_g clobbers it)50+ MOVD R31, 8(R1) // save R31
51 51
52 MOVD setg+0(FP), R1252 MOVD setg+0(FP), R12
53 MOVD newg+8(FP), R353 MOVD newg+8(FP), R3
54 54
55+ MOVD R3, 16(R1) // save newg before call
56+
55 MOVD R12, CTR57 MOVD R12, CTR
56 CALL CTR58 CALL CTR
57 59
58- CALL runtime·load_g(SB)60+ // Assign g directly instead of calling runtime·load_g
61+ // setg_gcc has already stored newg into TLS; put it in the g register too.
62+ MOVD 16(R1), g
59 63
60 MOVD 8(R1), R3164 MOVD 8(R1), R31
61 XOR R0, R0, R065 XOR R0, R0, R0

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close