Revert "internal/strings: explicitly copy C string into Go memory in GoString (#63)"

This reverts commit 6dfb1bbf605466de9d3c3bf031a149a17313e096.

Reason: Casting []byte to string should make a copy implicitly from the
current Go specification (strings are immutable).
See the discussion at https://github.com/ebitengine/purego/commit/6dfb1bbf605466de9d3c3bf031a149a17313e096#r89321682

commit: 54b6cdc43bccd40142c78d3f7ac72df5c147056d
author: Hajime Hoshi · 3y ago · 2022-11-10 15:23 UTC
parent: 2ebcfb9
signature: unsigned

1 file · +1 -3

M internal/strings/strings.go +1 -3


@@ -36,7 +36,5 @@ func GoString(c uintptr) string {
36	36		}
37	37		length++
38	38		}
39		-	dst := make([]byte, length)
40		-	copy(dst, unsafe.Slice((*byte)(ptr), length))
41		-	return string(dst)
	39	+	return string(unsafe.Slice((*byte)(ptr), length))
42	40		}


@@ -36,7 +36,5 @@ func GoString(c uintptr) string {
36		}	36		}
37		length++	37		length++
38		}	38		}
39	-	dst := make([]byte, length)	39	+	return string(unsafe.Slice((*byte)(ptr), length))
40	-	copy(dst, unsafe.Slice((*byte)(ptr), length))
41	-	return string(dst)
42		}	40		}