detached c965cb3

GIR: Embed `parent_class` as value, not uintptr

Signed-off-by: Felicitas Pojtinger <felicitas@pojtinger.com>
commit
c965cb30bf64715f3a0f4bc911f98402a6127b7a
author
Felicitas Pojtinger · · 2025-10-09 04:29 UTC
committer
Jeroen Wijenbergh · · 2025-10-16 13:39 UTC
parent
fe4d51f
signature
unsigned
1 file · +14 -0
M internal/gir/pass/pass.go +14 -0
@@ -190,6 +190,20 @@ func (p *Pass) writeGo(r types.Repository, gotemp *template.Template, dir string
190190 if _type == "string" {
191191 _type = "uintptr"
192192 }
193+
194+ // HACK: Special handling for parent_class field - it should be embedded as a full struct
195+ // to match C's memory layout, not converted to uintptr
196+ // See https://docs.gtk.org/gobject/tutorial.html
197+ if f.Name == "parent_class" && f.AnyType.Type != nil {
198+ // Check if this is a Record type with no pointers (embedded struct)
199+ typeName := util.NormalizeNamespace(ns.Name, f.AnyType.Type.Name, true)
200+ kind := p.Types.Kind(ns.Name, typeName)
201+ if kind == types.RecordsType && !strings.Contains(f.AnyType.Type.CType, "*") {
202+ // Use the full struct type for embedding
203+ _type = typeName
204+ }
205+ }
206+
193207 fieldName = util.SnakeToCamel(f.Name)
194208 }
195209
@@ -190,6 +190,20 @@ func (p *Pass) writeGo(r types.Repository, gotemp *template.Template, dir string
190 if _type == "string" {190 if _type == "string" {
191 _type = "uintptr"191 _type = "uintptr"
192 }192 }
193+
194+ // HACK: Special handling for parent_class field - it should be embedded as a full struct
195+ // to match C's memory layout, not converted to uintptr
196+ // See https://docs.gtk.org/gobject/tutorial.html
197+ if f.Name == "parent_class" && f.AnyType.Type != nil {
198+ // Check if this is a Record type with no pointers (embedded struct)
199+ typeName := util.NormalizeNamespace(ns.Name, f.AnyType.Type.Name, true)
200+ kind := p.Types.Kind(ns.Name, typeName)
201+ if kind == types.RecordsType && !strings.Contains(f.AnyType.Type.CType, "*") {
202+ // Use the full struct type for embedding
203+ _type = typeName
204+ }
205+ }
206+
193 fieldName = util.SnakeToCamel(f.Name)207 fieldName = util.SnakeToCamel(f.Name)
194 }208 }
195 209

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 102

↑↓ moveenter openesc close