detached ece7682

broker_store_outcome_test.go RawHistoryFolder

1package ports
2
3import (
4	"errors"
5	"fmt"
6	"testing"
7
8	"github.com/stretchr/testify/require"
9)
10
11// TestBrokerStoreOutcomeUnknownErrorClassification pins the indeterminate-write
12// contract at the ports seam: the error reports a store failure that happened
13// after the durable commit point, stays classifiable after wrapping, and keeps
14// the underlying store cause inspectable so a caller can log or classify it
15// without importing the adapter.
16func TestBrokerStoreOutcomeUnknownErrorClassification(t *testing.T) {
17	cause := errors.New("power loss")
18	unknown := BrokerStoreOutcomeUnknownError{Err: cause}
19
20	require.ErrorContains(t, unknown, "outcome unknown")
21	require.ErrorContains(t, unknown, "power loss")
22	require.ErrorIs(t, unknown, cause, "the underlying store cause stays inspectable")
23	var classified BrokerStoreOutcomeUnknownError
24	require.ErrorAs(t, unknown, &classified)
25	require.Equal(t, cause, classified.Err)
26
27	// Wrapping by a caller or a composing use case must not erase the
28	// classification: that is the whole point of a typed error here.
29	wrapped := fmt.Errorf("broker: replace hosts: %w", unknown)
30	require.ErrorAs(t, wrapped, &classified)
31	require.ErrorIs(t, wrapped, cause)
32
33	// A definite store failure is never an unknown outcome, so a caller cannot
34	// mistake a retryable conflict for a reopen-required indeterminate write.
35	for name, definite := range map[string]error{
36		"conflict":      ErrBrokerHostConflict,
37		"locked":        ErrBrokerStoreLocked,
38		"invalid state": ErrBrokerStoreInvalidState,
39		"immutable":     ErrBrokerMembershipImmutable,
40	} {
41		t.Run(name, func(t *testing.T) {
42			require.False(t, errors.As(definite, &classified))
43			require.False(t, errors.As(fmt.Errorf("broker: replace hosts: %w", definite), &classified))
44		})
45	}
46}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close