detached 1e03a92

refactor(layout): remove redundant target index assignment

commit
1e03a92ca58e87b561ac0d7fcbd82f1e37006932
author
brice · · 2026-07-27 13:31 UTC
parent
3f0da0d
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -2
M internal/usecase/layout/consume_expel.go +2 -2
@@ -23,7 +23,7 @@ func (t *Tree) ConsumeOrExpelPane(target PaneID, dir Direction, area domain.Rect
2323 }
2424
2525 columns := canonicalColumns(t.Root)
26- columnIndex, memberIndex, found := findColumnMember(columns, target)
26+ columnIndex, _, found := findColumnMember(columns, target)
2727 if !found {
2828 return false, ErrNotFound
2929 }
@@ -44,7 +44,7 @@ func (t *Tree) ConsumeOrExpelPane(target PaneID, dir Direction, area domain.Rect
4444 }
4545
4646 columns = canonicalColumns(candidate.Root)
47- columnIndex, memberIndex, _ = findColumnMember(columns, target)
47+ columnIndex, memberIndex, _ := findColumnMember(columns, target)
4848 if candidate.Root.Kind == Split && candidate.Root.Dir == Horizontal {
4949 normalizeChildWeightsFromArea(candidate.Root, area)
5050 }
@@ -23,7 +23,7 @@ func (t *Tree) ConsumeOrExpelPane(target PaneID, dir Direction, area domain.Rect
23 }23 }
24 24
25 columns := canonicalColumns(t.Root)25 columns := canonicalColumns(t.Root)
26- columnIndex, memberIndex, found := findColumnMember(columns, target)26+ columnIndex, _, found := findColumnMember(columns, target)
27 if !found {27 if !found {
28 return false, ErrNotFound28 return false, ErrNotFound
29 }29 }
@@ -44,7 +44,7 @@ func (t *Tree) ConsumeOrExpelPane(target PaneID, dir Direction, area domain.Rect
44 }44 }
45 45
46 columns = canonicalColumns(candidate.Root)46 columns = canonicalColumns(candidate.Root)
47- columnIndex, memberIndex, _ = findColumnMember(columns, target)47+ columnIndex, memberIndex, _ := findColumnMember(columns, target)
48 if candidate.Root.Kind == Split && candidate.Root.Dir == Horizontal {48 if candidate.Root.Kind == Split && candidate.Root.Dir == Horizontal {
49 normalizeChildWeightsFromArea(candidate.Root, area)49 normalizeChildWeightsFromArea(candidate.Root, area)
50 }50 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close