detached 46cc97f

test(client): remove redundant close hook

commit
46cc97fd9e5300e300944291fd2868be3bb12b17
author
brice · · 2026-08-25 15:55 UTC
parent
52935c6
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +0 -1
M internal/usecase/client/client_test.go +0 -1
@@ -845,7 +845,6 @@ func TestHybridPickerPrepareResponseTimeoutClosesRetainedTransport(t *testing.T)
845845 remote.onSend = hybridParkedRequestHandler(nil, nil, map[ports.ParkedRouteAction]chan struct{}{
846846 ports.ParkedRoutePrepare: prepareSent,
847847 })
848- remote.onClose = func() { closeOnce.Do(func() { close(remoteClosed) }) }
849848
850849 localDialer := &sequenceDialer{trs: []ports.Transport{localInitial}}
851850 remoteDialer := &sequenceDialer{trs: []ports.Transport{markedDatagramTransport{Transport: remote}}}
@@ -845,7 +845,6 @@ func TestHybridPickerPrepareResponseTimeoutClosesRetainedTransport(t *testing.T)
845 remote.onSend = hybridParkedRequestHandler(nil, nil, map[ports.ParkedRouteAction]chan struct{}{845 remote.onSend = hybridParkedRequestHandler(nil, nil, map[ports.ParkedRouteAction]chan struct{}{
846 ports.ParkedRoutePrepare: prepareSent,846 ports.ParkedRoutePrepare: prepareSent,
847 })847 })
848- remote.onClose = func() { closeOnce.Do(func() { close(remoteClosed) }) }
849 848
850 localDialer := &sequenceDialer{trs: []ports.Transport{localInitial}}849 localDialer := &sequenceDialer{trs: []ports.Transport{localInitial}}
851 remoteDialer := &sequenceDialer{trs: []ports.Transport{markedDatagramTransport{Transport: remote}}}850 remoteDialer := &sequenceDialer{trs: []ports.Transport{markedDatagramTransport{Transport: remote}}}

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close