chore(daemon): clarify floating launch ownership
- commit
- 645e5a40674bee830c7504cd8cd4dfe0f393e95b
- author
- brice · · 2026-07-12 11:27 UTC
- parent
- 02c900e
- signature
- GPG Verified
CD88F9E564E0102646FB6077A1A07C7C7C3E349D· arch-gpg Verified for the committer email
1 file · +2 -2
M internal/usecase/daemon/floating.go +2 -2
| @@ -248,7 +248,7 @@ func (sess *session) registerFloatingLaunch() (*floatingLaunch, bool) { | |||
| 248 | 248 | ||
| 249 | 249 | // openFloating runs fn while only the dedicated launch-ownership lock is | |
| 250 | 250 | // held. It deliberately does not hold sess.mu, tb.mu, or d.mu across Open. | |
| 251 | - | func (sess *session) openFloating(launch *floatingLaunch, fn func() (ports.PTY, error)) (ports.PTY, error, bool) { | |
| 251 | + | func (sess *session) openFloating(fn func() (ports.PTY, error)) (ports.PTY, error, bool) { | |
| 252 | 252 | sess.floatingLaunchMu.Lock() | |
| 253 | 253 | defer sess.floatingLaunchMu.Unlock() | |
| 254 | 254 | if sess.floatingLaunchStopping { | |
| @@ -386,7 +386,7 @@ func (d *Daemon) openAndInstallFloating(sess *session, tb *tab, spec floatingLau | |||
| 386 | 386 | d.floatingLaunchGate.Unlock() | |
| 387 | 387 | return | |
| 388 | 388 | } | |
| 389 | - | pty, err, opened := sess.openFloating(launch, func() (ports.PTY, error) { | |
| 389 | + | pty, err, opened := sess.openFloating(func() (ports.PTY, error) { | |
| 390 | 390 | return d.ptys.Open(spec.command, spec.args, spec.env, spec.cwd, spec.size) | |
| 391 | 391 | }) | |
| 392 | 392 | d.floatingLaunchGate.Unlock() | |
| @@ -248,7 +248,7 @@ func (sess *session) registerFloatingLaunch() (*floatingLaunch, bool) { | |||||
| 248 | 248 | ||||
| 249 | // openFloating runs fn while only the dedicated launch-ownership lock is | 249 | // openFloating runs fn while only the dedicated launch-ownership lock is | ||
| 250 | // held. It deliberately does not hold sess.mu, tb.mu, or d.mu across Open. | 250 | // held. It deliberately does not hold sess.mu, tb.mu, or d.mu across Open. | ||
| 251 | - | func (sess *session) openFloating(launch *floatingLaunch, fn func() (ports.PTY, error)) (ports.PTY, error, bool) { | 251 | + | func (sess *session) openFloating(fn func() (ports.PTY, error)) (ports.PTY, error, bool) { |
| 252 | sess.floatingLaunchMu.Lock() | 252 | sess.floatingLaunchMu.Lock() | ||
| 253 | defer sess.floatingLaunchMu.Unlock() | 253 | defer sess.floatingLaunchMu.Unlock() | ||
| 254 | if sess.floatingLaunchStopping { | 254 | if sess.floatingLaunchStopping { | ||
| @@ -386,7 +386,7 @@ func (d *Daemon) openAndInstallFloating(sess *session, tb *tab, spec floatingLau | |||||
| 386 | d.floatingLaunchGate.Unlock() | 386 | d.floatingLaunchGate.Unlock() | ||
| 387 | return | 387 | return | ||
| 388 | } | 388 | } | ||
| 389 | - | pty, err, opened := sess.openFloating(launch, func() (ports.PTY, error) { | 389 | + | pty, err, opened := sess.openFloating(func() (ports.PTY, error) { |
| 390 | return d.ptys.Open(spec.command, spec.args, spec.env, spec.cwd, spec.size) | 390 | return d.ptys.Open(spec.command, spec.args, spec.env, spec.cwd, spec.size) | ||
| 391 | }) | 391 | }) | ||
| 392 | d.floatingLaunchGate.Unlock() | 392 | d.floatingLaunchGate.Unlock() | ||