test(boundary): limit the snapshot codec to the daemon among use cases

commit: 7ebc8f82128d39400439382709af6656b7513753
author: brice · 14d ago · 2026-10-08 09:03 UTC
committer: brice · 14d ago · 2026-10-08 09:31 UTC
parent: b034df2
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +13 -5

M boundary_test.go +13 -5


@@ -96,6 +96,7 @@ func TestImportBoundaryNegativeFixtures(t *testing.T) {
96	96		{"snapshot adapter accepts codec", modulePath + "/internal/adapters/snapshot", modulePath + "/internal/snapshotcodec", false, true},
97	97		{"daemon accepts snapshot codec", modulePath + "/internal/usecase/daemon", modulePath + "/internal/snapshotcodec", false, true},
98	98		{"other adapter rejects snapshot codec", modulePath + "/internal/adapters/ipc", modulePath + "/internal/snapshotcodec", false, false},
	99	+	{"client rejects snapshot codec", modulePath + "/internal/usecase/client", modulePath + "/internal/snapshotcodec", false, false},
99	100		{"snapshot codec rejects usecase", modulePath + "/internal/snapshotcodec", modulePath + "/internal/usecase/daemon", false, false},
100	101		{"snapshot codec rejects adapter", modulePath + "/internal/snapshotcodec", modulePath + "/internal/adapters/snapshot", false, false},
101	102		{"snapshot adapter rejects usecase", modulePath + "/internal/adapters/snapshot", modulePath + "/internal/usecase/daemon", false, false},

@@ -216,8 +217,10 @@ func dependencyAllowed(source, target string, testFile bool) (bool, error) {
216	217
217	218		// packageImportDenied encodes ADR 001 ownership at package granularity for
218	219		// production files. Layer rules alone permit any usecase-to-usecase import;
219		-	// other, and keep the broker free of every sibling use case. Test files stay
220		-	// exempt so composition tests can wire adapters and orchestrators together.
	220	+	// this keeps client and daemon from importing each other, keeps the broker
	221	+	// free of every sibling use case, and limits the snapshot codec to the daemon
	222	+	// and the snapshot adapter. Test files stay exempt so composition tests can
	223	+	// wire adapters and orchestrators together.
221	224		func packageImportDenied(source, target string) bool {
222	225		brokerPkg := modulePath + "/internal/usecase/broker"
223	226		clientPkg := modulePath + "/internal/usecase/client"

@@ -227,9 +230,14 @@ func packageImportDenied(source, target string) bool {
227	230		return path == root \|\| strings.HasPrefix(path, root+"/")
228	231		}
229	232		// The durable snapshot format is shared by the daemon and its one
230		-	// repository adapter; no other adapter may depend on it.
231		-	if target == modulePath+"/internal/snapshotcodec" && strings.HasPrefix(source, modulePath+"/internal/adapters/") {
232		-	return source != modulePath+"/internal/adapters/snapshot"
	233	+	// repository adapter; no other adapter or use case may depend on it.
	234	+	if target == modulePath+"/internal/snapshotcodec" {
	235	+	switch {
	236	+	case strings.HasPrefix(source, modulePath+"/internal/adapters/"):
	237	+	return source != modulePath+"/internal/adapters/snapshot"
	238	+	case strings.HasPrefix(source, usecasePrefix):
	239	+	return !under(source, daemonPkg)
	240	+	}
233	241		}
234	242		switch {
235	243		case under(source, brokerPkg):

 		{"snapshot adapter accepts codec", modulePath + "/internal/adapters/snapshot", modulePath + "/internal/snapshotcodec", false, true},
 		{"daemon accepts snapshot codec", modulePath + "/internal/usecase/daemon", modulePath + "/internal/snapshotcodec", false, true},
 		{"other adapter rejects snapshot codec", modulePath + "/internal/adapters/ipc", modulePath + "/internal/snapshotcodec", false, false},
+		{"client rejects snapshot codec", modulePath + "/internal/usecase/client", modulePath + "/internal/snapshotcodec", false, false},
 		{"snapshot codec rejects usecase", modulePath + "/internal/snapshotcodec", modulePath + "/internal/usecase/daemon", false, false},
 		{"snapshot codec rejects adapter", modulePath + "/internal/snapshotcodec", modulePath + "/internal/adapters/snapshot", false, false},
 		{"snapshot adapter rejects usecase", modulePath + "/internal/adapters/snapshot", modulePath + "/internal/usecase/daemon", false, false},
 // packageImportDenied encodes ADR 001 ownership at package granularity for
 // production files. Layer rules alone permit any usecase-to-usecase import;
-// other, and keep the broker free of every sibling use case. Test files stay
+// this keeps client and daemon from importing each other, keeps the broker
-// exempt so composition tests can wire adapters and orchestrators together.
+// free of every sibling use case, and limits the snapshot codec to the daemon
+// and the snapshot adapter. Test files stay exempt so composition tests can
+// wire adapters and orchestrators together.
 func packageImportDenied(source, target string) bool {
 	brokerPkg := modulePath + "/internal/usecase/broker"
 	clientPkg := modulePath + "/internal/usecase/client"
 		return path == root || strings.HasPrefix(path, root+"/")
 	}
 	// The durable snapshot format is shared by the daemon and its one
-	// repository adapter; no other adapter may depend on it.
+	// repository adapter; no other adapter or use case may depend on it.
-	if target == modulePath+"/internal/snapshotcodec" && strings.HasPrefix(source, modulePath+"/internal/adapters/") {
+	if target == modulePath+"/internal/snapshotcodec" {
-		return source != modulePath+"/internal/adapters/snapshot"
+		switch {
+		case strings.HasPrefix(source, modulePath+"/internal/adapters/"):
+			return source != modulePath+"/internal/adapters/snapshot"
+		case strings.HasPrefix(source, usecasePrefix):
+			return !under(source, daemonPkg)
+		}
 	}
 	switch {
 	case under(source, brokerPkg):