detached a5ac8f2

fix(kv): preserve write error wrapping

commit
a5ac8f2141c08ce6228e3e52d6ea48d14a8c9d44
author
brice · · 2026-07-03 21:32 UTC
parent
b5b098c
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
1 file · +2 -2
M pkg/kv/kv.go +2 -2
@@ -210,11 +210,11 @@ func (s *Store) appendRecord(op byte, key, val []byte) error {
210210 }
211211 if tErr := s.file.Truncate(pos); tErr != nil {
212212 s.closed = true
213- return fmt.Errorf("write failed (%v) and recovery truncate failed: %w", writeErr, tErr)
213+ return fmt.Errorf("write failed (%w) and recovery truncate failed: %w", writeErr, tErr)
214214 }
215215 if _, sErr := s.file.Seek(pos, io.SeekStart); sErr != nil {
216216 s.closed = true
217- return fmt.Errorf("write failed (%v) and recovery seek failed: %w", writeErr, sErr)
217+ return fmt.Errorf("write failed (%w) and recovery seek failed: %w", writeErr, sErr)
218218 }
219219 return writeErr
220220 }
@@ -210,11 +210,11 @@ func (s *Store) appendRecord(op byte, key, val []byte) error {
210 }210 }
211 if tErr := s.file.Truncate(pos); tErr != nil {211 if tErr := s.file.Truncate(pos); tErr != nil {
212 s.closed = true212 s.closed = true
213- return fmt.Errorf("write failed (%v) and recovery truncate failed: %w", writeErr, tErr)213+ return fmt.Errorf("write failed (%w) and recovery truncate failed: %w", writeErr, tErr)
214 }214 }
215 if _, sErr := s.file.Seek(pos, io.SeekStart); sErr != nil {215 if _, sErr := s.file.Seek(pos, io.SeekStart); sErr != nil {
216 s.closed = true216 s.closed = true
217- return fmt.Errorf("write failed (%v) and recovery seek failed: %w", writeErr, sErr)217+ return fmt.Errorf("write failed (%w) and recovery seek failed: %w", writeErr, sErr)
218 }218 }
219 return writeErr219 return writeErr
220 }220 }

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close