detached a65e2c7

refactor(daemon): remove obsolete transition state

commit
a65e2c7dbf655a06fc877193581d51df481d2b29
author
brice · · 2026-08-03 00:12 UTC
committer
brice · · 2026-08-03 20:53 UTC
parent
db24042
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
3 files · +4 -9
M internal/usecase/daemon/attachment_transition.go +3 -5
@@ -74,11 +74,9 @@ func transitionSourceTokenCurrentLocked(token attachmentRoleToken, source attach
7474 }
7575
7676 type attachmentTransitionResult struct {
77- published attachmentRoleToken
78- displaced attachmentRoleToken
79- terminalDisplaced detachedAttachmentSnapshot
80- displacedInterrupted bool
81- cleanups []renderLifecycleCleanup
77+ published attachmentRoleToken
78+ displaced attachmentRoleToken
79+ cleanups []renderLifecycleCleanup
8280 }
8381
8482 type attachmentTransitionParticipants struct {
@@ -74,11 +74,9 @@ func transitionSourceTokenCurrentLocked(token attachmentRoleToken, source attach
74 }74 }
75 75
76 type attachmentTransitionResult struct {76 type attachmentTransitionResult struct {
77- published attachmentRoleToken77+ published attachmentRoleToken
78- displaced attachmentRoleToken78+ displaced attachmentRoleToken
79- terminalDisplaced detachedAttachmentSnapshot79+ cleanups []renderLifecycleCleanup
80- displacedInterrupted bool
81- cleanups []renderLifecycleCleanup
82 }80 }
83 81
84 type attachmentTransitionParticipants struct {82 type attachmentTransitionParticipants struct {
M internal/usecase/daemon/attachment_transition_publish.go +0 -3
@@ -90,10 +90,7 @@ type attachmentPublication struct {
9090 sourceCoordinator *renderCoordinator
9191 targetCoordinator *renderCoordinator
9292 releaseCoordinators func()
93- displacedTransport transportSnapshot
94- terminalDisplaced bool
9593 nextGeneration uint64
96- displacedGeneration uint64
9794 }
9895
9996 func (p *attachmentPublication) unlockCoordinators() {
@@ -90,10 +90,7 @@ type attachmentPublication struct {
90 sourceCoordinator *renderCoordinator90 sourceCoordinator *renderCoordinator
91 targetCoordinator *renderCoordinator91 targetCoordinator *renderCoordinator
92 releaseCoordinators func()92 releaseCoordinators func()
93- displacedTransport transportSnapshot
94- terminalDisplaced bool
95 nextGeneration uint6493 nextGeneration uint64
96- displacedGeneration uint64
97 }94 }
98 95
99 func (p *attachmentPublication) unlockCoordinators() {96 func (p *attachmentPublication) unlockCoordinators() {
M internal/usecase/daemon/proxy_lifecycle.go +1 -1
@@ -245,7 +245,7 @@ func (d *Daemon) withProxyLocked(p *proxySession, update func() bool) bool {
245245 p.sessionCore.mu.Lock()
246246 p.mu.Lock()
247247 current := update()
248- attachments := append([]*attachedClient(nil), p.sessionCore.snapshotAttachmentsLocked()...)
248+ attachments := append([]*attachedClient(nil), p.snapshotAttachmentsLocked()...)
249249 p.mu.Unlock()
250250 p.sessionCore.mu.Unlock()
251251 d.mu.Unlock()
@@ -245,7 +245,7 @@ func (d *Daemon) withProxyLocked(p *proxySession, update func() bool) bool {
245 p.sessionCore.mu.Lock()245 p.sessionCore.mu.Lock()
246 p.mu.Lock()246 p.mu.Lock()
247 current := update()247 current := update()
248- attachments := append([]*attachedClient(nil), p.sessionCore.snapshotAttachmentsLocked()...)248+ attachments := append([]*attachedClient(nil), p.snapshotAttachmentsLocked()...)
249 p.mu.Unlock()249 p.mu.Unlock()
250 p.sessionCore.mu.Unlock()250 p.sessionCore.mu.Unlock()
251 d.mu.Unlock()251 d.mu.Unlock()

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 12

Tags 11

↑↓ moveenter openesc close