test(daemon): coordinate atomic theme snapshot reads

commit: adce876489a69cc962df715a5999c3bd228e638c
author: brice · 3mo ago · 2026-07-17 09:23 UTC
parent: 00f573e
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +18 -6

M internal/usecase/daemon/config_test.go +18 -6


@@ -197,16 +197,22 @@ func TestThemeConfigSnapshotIsAtomic(t *testing.T) {
197	197		{mode: domain.ThemeAuto, paletteOff: true}: {},
198	198		{mode: domain.ThemeDark, paletteOff: false}: {},
199	199		}
200		-	ready := make(chan struct{})
201		-	readerStarted := make(chan struct{})
	200	+	firstPublished := make(chan struct{})
	201	+	firstObserved := make(chan struct{})
	202	+	secondPublished := make(chan struct{})
	203	+	secondObserved := make(chan struct{})
	204	+	observed := make(chan themeConfigSnapshot, 2)
202	205		invalid := make(chan themeConfigSnapshot, 1)
203	206		var wg sync.WaitGroup
204	207		wg.Add(2)
205	208		go func() {
206	209		defer wg.Done()
207	210		d.storeThemeConfig(first)
208		-	close(ready)
209		-	<-readerStarted
	211	+	close(firstPublished)
	212	+	<-firstObserved
	213	+	d.storeThemeConfig(second)
	214	+	close(secondPublished)
	215	+	<-secondObserved
210	216		for range 10_000 {
211	217		d.storeThemeConfig(second)
212	218		d.storeThemeConfig(first)

@@ -214,8 +220,12 @@ func TestThemeConfigSnapshotIsAtomic(t *testing.T) {
214	220		}()
215	221		go func() {
216	222		defer wg.Done()
217		-	<-ready
218		-	close(readerStarted)
	223	+	<-firstPublished
	224	+	observed <- d.currentThemeConfig()
	225	+	close(firstObserved)
	226	+	<-secondPublished
	227	+	observed <- d.currentThemeConfig()
	228	+	close(secondObserved)
219	229		for range 20_000 {
220	230		snapshot := d.currentThemeConfig()
221	231		if _, ok := allowed[snapshot]; !ok {

@@ -228,6 +238,8 @@ func TestThemeConfigSnapshotIsAtomic(t *testing.T) {
228	238		}
229	239		}()
230	240		wg.Wait()
	241	+	require.Equal(t, themeConfigSnapshot{mode: domain.ThemeAuto, paletteOff: true}, <-observed)
	242	+	require.Equal(t, themeConfigSnapshot{mode: domain.ThemeDark, paletteOff: false}, <-observed)
231	243		select {
232	244		case snapshot := <-invalid:
233	245		t.Fatalf("observed mixed theme configuration: %#v", snapshot)

 		{mode: domain.ThemeAuto, paletteOff: true}:  {},
 		{mode: domain.ThemeDark, paletteOff: false}: {},
 	}
-	ready := make(chan struct{})
+	firstPublished := make(chan struct{})
-	readerStarted := make(chan struct{})
+	firstObserved := make(chan struct{})
+	secondPublished := make(chan struct{})
+	secondObserved := make(chan struct{})
+	observed := make(chan themeConfigSnapshot, 2)
 	invalid := make(chan themeConfigSnapshot, 1)
 	var wg sync.WaitGroup
 	wg.Add(2)
 	go func() {
 		defer wg.Done()
 		d.storeThemeConfig(first)
-		close(ready)
+		close(firstPublished)
-		<-readerStarted
+		<-firstObserved
+		d.storeThemeConfig(second)
+		close(secondPublished)
+		<-secondObserved
 		for range 10_000 {
 			d.storeThemeConfig(second)
 			d.storeThemeConfig(first)
 	}()
 	go func() {
 		defer wg.Done()
-		<-ready
+		<-firstPublished
-		close(readerStarted)
+		observed <- d.currentThemeConfig()
+		close(firstObserved)
+		<-secondPublished
+		observed <- d.currentThemeConfig()
+		close(secondObserved)
 		for range 20_000 {
 			snapshot := d.currentThemeConfig()
 			if _, ok := allowed[snapshot]; !ok {
 		}
 	}()
 	wg.Wait()
+	require.Equal(t, themeConfigSnapshot{mode: domain.ThemeAuto, paletteOff: true}, <-observed)
+	require.Equal(t, themeConfigSnapshot{mode: domain.ThemeDark, paletteOff: false}, <-observed)
 	select {
 	case snapshot := <-invalid:
 		t.Fatalf("observed mixed theme configuration: %#v", snapshot)