skip to content

detached bba2691

test(config): note why the polling fallback test is not parallel

commit: bba2691a273899204baa0c300256010a446f05fc
author: brice · 12d ago · 2026-10-10 08:35 UTC
parent: fcb004a
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +2 -1

M internal/adapters/config/config_test.go +2 -1


@@ -1048,7 +1048,8 @@ func ptr[T any](v T) *T { return &v }
1048	1048
1049	1049		// When native watching fails (inotify limits), watch keeps the current
1050	1050		// config, warns once and polls instead of giving up.
1051		-	func TestWatchFallsBackToPolling(t *testing.T) { //nolint:paralleltest // replaces kvWatch
	1051	+	// Not parallel: it replaces kvWatch.
	1052	+	func TestWatchFallsBackToPolling(t *testing.T) {
1052	1053		path := filepath.Join(t.TempDir(), "config")
1053	1054		writeAtomic(t, path, []byte("theme = light\n"))
1054	1055		var polled atomic.Bool


@@ -1048,7 +1048,8 @@ func ptr[T any](v T) *T { return &v }
1048			1048
1049		// When native watching fails (inotify limits), watch keeps the current	1049		// When native watching fails (inotify limits), watch keeps the current
1050		// config, warns once and polls instead of giving up.	1050		// config, warns once and polls instead of giving up.
1051	-	func TestWatchFallsBackToPolling(t *testing.T) { //nolint:paralleltest // replaces kvWatch	1051	+	// Not parallel: it replaces kvWatch.
			1052	+	func TestWatchFallsBackToPolling(t *testing.T) {
1052		path := filepath.Join(t.TempDir(), "config")	1053		path := filepath.Join(t.TempDir(), "config")
1053		writeAtomic(t, path, []byte("theme = light\n"))	1054		writeAtomic(t, path, []byte("theme = light\n"))
1054		var polled atomic.Bool	1055		var polled atomic.Bool