detached f2df270

test(runtime): accept a closed connection for refused Xvfb setups

commit
f2df2700a3d1f7bbdebba07ee203c2922d907ed6
author
brice · · 2026-10-22 09:00 UTC
parent
c1fb73f
signature
GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email
checks
1/2
1 file · +3 -2
M conn_xserver_test.go +3 -2
@@ -85,9 +85,10 @@ func TestXserverDial(t *testing.T) {
8585 writeXauthority(t, auth, cookie)
8686 display := startXvfb(t, auth)
8787
88- // Without a cookie the server refuses the setup.
88+ // Without a cookie the server refuses the setup: some builds answer Failed,
89+ // others close the connection without a reply.
8990 t.Setenv("XAUTHORITY", filepath.Join(dir, "missing"))
90- if _, err := xturbo.Dial(display); !errors.Is(err, xturbo.ErrSetupFailed) {
91+ if _, err := xturbo.Dial(display); !errors.Is(err, xturbo.ErrSetupFailed) && !errors.Is(err, xturbo.ErrClosed) {
9192 t.Fatalf("unauthenticated Dial: %v", err)
9293 }
9394
@@ -85,9 +85,10 @@ func TestXserverDial(t *testing.T) {
85 writeXauthority(t, auth, cookie)85 writeXauthority(t, auth, cookie)
86 display := startXvfb(t, auth)86 display := startXvfb(t, auth)
87 87
88- // Without a cookie the server refuses the setup.88+ // Without a cookie the server refuses the setup: some builds answer Failed,
89+ // others close the connection without a reply.
89 t.Setenv("XAUTHORITY", filepath.Join(dir, "missing"))90 t.Setenv("XAUTHORITY", filepath.Join(dir, "missing"))
90- if _, err := xturbo.Dial(display); !errors.Is(err, xturbo.ErrSetupFailed) {91+ if _, err := xturbo.Dial(display); !errors.Is(err, xturbo.ErrSetupFailed) && !errors.Is(err, xturbo.ErrClosed) {
91 t.Fatalf("unauthenticated Dial: %v", err)92 t.Fatalf("unauthenticated Dial: %v", err)
92 }93 }
93 94

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 1

↑↓ moveenter openesc close