1package subagents
2
3import (
4 "context"
5 "encoding/json"
6 "os"
7 "path/filepath"
8 "testing"
9
10 "github.com/bnema/zut/packages/core"
11 "github.com/bnema/zut/packages/provider"
12)
13
14func TestReadResidentHistoryReturnsCompleteFinalizedItems(t *testing.T) {
15 root := t.TempDir()
16 journal, err := OpenResidentJournal(root, "history-child")
17 if err != nil {
18 t.Fatal(err)
19 }
20 spec := ResidentChildSpec{ID: "history-child", SessionID: "history-session", Provider: "openai", Model: "gpt-5"}
21 if err := journal.Accept(spec, "task"); err != nil {
22 t.Fatal(err)
23 }
24 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "question"}}}}); err != nil {
25 t.Fatal(err)
26 }
27 if err := journal.RecordAgentEvent(core.EvToolCall{ID: "call-1", Name: "bash", Args: json.RawMessage(`{"command":"pwd"}`)}); err != nil {
28 t.Fatal(err)
29 }
30 if err := journal.RecordAgentEvent(core.EvToolResult{ID: "call-1", Result: core.ToolResult{Content: []provider.Content{provider.TextBlock{Text: "/repo"}}}}); err != nil {
31 t.Fatal(err)
32 }
33 if err := journal.Close(); err != nil {
34 t.Fatal(err)
35 }
36 history, err := ReadResidentHistory(filepath.Join(root, spec.ID), 10)
37 if err != nil {
38 t.Fatal(err)
39 }
40 if len(history) != 3 || history[1].ToolName != "bash" || string(history[1].ToolArgs) != `{"command":"pwd"}` || len(history[2].ToolResult) == 0 {
41 t.Fatalf("history = %#v", history)
42 }
43 if _, err := ResidentHistoryDir(root, "../escape"); err == nil {
44 t.Fatal("ResidentHistoryDir accepted traversal")
45 }
46}
47
48func TestResidentHistoryMessagesRestoresToolCallsAndResults(t *testing.T) {
49 assistant, err := json.Marshal(provider.Message{Role: provider.RoleAssistant, Content: []provider.Content{provider.ToolCallBlock{ID: "call-1", Name: "bash", Arguments: json.RawMessage(`{"command":"pwd"}`)}}})
50 if err != nil {
51 t.Fatal(err)
52 }
53 result, err := json.Marshal(core.ToolResult{Content: []provider.Content{provider.TextBlock{Text: "/repo"}}})
54 if err != nil {
55 t.Fatal(err)
56 }
57 messages, err := ResidentHistoryMessages([]ResidentHistoryItem{
58 {Type: residentRecordAssistant, Message: assistant},
59 {Type: residentRecordToolCall, ToolID: "call-1", ToolName: "bash", ToolArgs: json.RawMessage(`{"command":"pwd"}`)},
60 {Type: residentRecordToolResult, ToolID: "call-1", ToolResult: result},
61 })
62 if err != nil {
63 t.Fatal(err)
64 }
65 if len(messages) != 2 {
66 t.Fatalf("messages = %#v", messages)
67 }
68 call, ok := messages[0].Content[0].(provider.ToolCallBlock)
69 if !ok || call.ID != "call-1" {
70 t.Fatalf("assistant call = %#v", messages[0])
71 }
72 tool, ok := messages[1].Content[0].(provider.ToolResultBlock)
73 if !ok || tool.CallID != "call-1" || len(tool.Content) != 1 {
74 t.Fatalf("tool message = %#v", messages[1])
75 }
76}
77
78func TestReadResidentTranscriptMessagesRestoresFinalizedConversation(t *testing.T) {
79 root := t.TempDir()
80 journal, err := OpenResidentJournal(root, "transcript")
81 if err != nil {
82 t.Fatal(err)
83 }
84 spec := ResidentChildSpec{ID: "transcript", SessionID: "session", Provider: "openai", Model: "gpt-5"}
85 if err := journal.Accept(spec, "task"); err != nil {
86 t.Fatal(err)
87 }
88 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "question"}}}}); err != nil {
89 t.Fatal(err)
90 }
91 if err := journal.Close(); err != nil {
92 t.Fatal(err)
93 }
94 messages, err := ReadResidentTranscriptMessages(filepath.Join(root, spec.ID))
95 if err != nil {
96 t.Fatal(err)
97 }
98 if len(messages) != 1 || messages[0].Role != provider.RoleUser {
99 t.Fatalf("messages = %#v", messages)
100 }
101}
102
103func TestReadResidentHistoryPageKeepsToolGroupsTogether(t *testing.T) {
104 root := t.TempDir()
105 journal, err := OpenResidentJournal(root, "history-page")
106 if err != nil {
107 t.Fatal(err)
108 }
109 spec := ResidentChildSpec{ID: "history-page", SessionID: "history-session", Provider: "openai", Model: "gpt-5"}
110 if err := journal.Accept(spec, "task"); err != nil {
111 t.Fatal(err)
112 }
113 for _, group := range []struct{ id, text string }{{"old", "old answer"}, {"new", "new answer"}} {
114 if err := journal.RecordAgentEvent(core.EvAssistantMessage{Message: provider.Message{Role: provider.RoleAssistant, Content: []provider.Content{provider.TextBlock{Text: group.text}}}}); err != nil {
115 t.Fatal(err)
116 }
117 if err := journal.RecordAgentEvent(core.EvToolCall{ID: group.id, Name: "bash", Args: json.RawMessage(`{"command":"pwd"}`)}); err != nil {
118 t.Fatal(err)
119 }
120 if err := journal.RecordAgentEvent(core.EvToolResult{ID: group.id, Result: core.ToolResult{Content: []provider.Content{provider.TextBlock{Text: "/repo"}}}}); err != nil {
121 t.Fatal(err)
122 }
123 }
124 if err := journal.Close(); err != nil {
125 t.Fatal(err)
126 }
127
128 page, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), "", 2)
129 if err != nil {
130 t.Fatal(err)
131 }
132 if len(page.Items) != 3 || page.Items[0].Type != residentRecordAssistant || page.Items[1].ToolID != "new" || page.Items[2].ToolID != "new" {
133 t.Fatalf("latest page split a tool group: %#v", page.Items)
134 }
135 if page.OlderCursor == "" {
136 t.Fatal("latest page has no cursor for the older group")
137 }
138 older, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), page.OlderCursor, 2)
139 if err != nil {
140 t.Fatal(err)
141 }
142 if len(older.Items) != 3 || older.Items[0].Type != residentRecordAssistant || older.Items[1].ToolID != "old" || older.Items[2].ToolID != "old" || older.OlderCursor != "" {
143 t.Fatalf("older page = %#v", older)
144 }
145}
146
147func TestReadResidentHistoryPageDefersIncompleteTailAndInvalidatesReplacedJournal(t *testing.T) {
148 root := t.TempDir()
149 journal, err := OpenResidentJournal(root, "history-cursor")
150 if err != nil {
151 t.Fatal(err)
152 }
153 spec := ResidentChildSpec{ID: "history-cursor", SessionID: "history-session", Provider: "openai", Model: "gpt-5"}
154 if err := journal.Accept(spec, "task"); err != nil {
155 t.Fatal(err)
156 }
157 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "saved"}}}}); err != nil {
158 t.Fatal(err)
159 }
160 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "newer"}}}}); err != nil {
161 t.Fatal(err)
162 }
163 if err := journal.Close(); err != nil {
164 t.Fatal(err)
165 }
166 path := filepath.Join(root, spec.ID, residentTranscriptName)
167 f, err := os.OpenFile(path, os.O_APPEND|os.O_WRONLY, 0o600)
168 if err != nil {
169 t.Fatal(err)
170 }
171 if _, err := f.WriteString(`{"type":"message.assistant"}`); err != nil {
172 t.Fatal(err)
173 }
174 if err := f.Close(); err != nil {
175 t.Fatal(err)
176 }
177 page, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), "", 1)
178 if err != nil {
179 t.Fatal(err)
180 }
181 if len(page.Items) != 1 || page.Items[0].Type != residentRecordUser {
182 t.Fatalf("incomplete tail leaked into page: %#v", page.Items)
183 }
184 if page.OlderCursor == "" {
185 t.Fatal("page has no cursor before replacement")
186 }
187
188 if err := os.WriteFile(path, []byte("{}\n"), 0o600); err != nil {
189 t.Fatal(err)
190 }
191 if _, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), page.OlderCursor, 10); err == nil {
192 t.Fatal("replaced journal cursor was accepted")
193 }
194}
195
196func TestReadResidentHistoryPageCursorSurvivesJournalAppend(t *testing.T) {
197 root := t.TempDir()
198 journal, err := OpenResidentJournal(root, "history-append")
199 if err != nil {
200 t.Fatal(err)
201 }
202 spec := ResidentChildSpec{ID: "history-append", SessionID: "history-session", Provider: "openai", Model: "gpt-5"}
203 if err := journal.Accept(spec, "task"); err != nil {
204 t.Fatal(err)
205 }
206 for _, text := range []string{"first", "second"} {
207 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: text}}}}); err != nil {
208 t.Fatal(err)
209 }
210 }
211 if err := journal.Close(); err != nil {
212 t.Fatal(err)
213 }
214 page, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), "", 1)
215 if err != nil || page.OlderCursor == "" {
216 t.Fatalf("latest page = %#v, err=%v", page, err)
217 }
218 journal, err = OpenResidentJournal(root, spec.ID)
219 if err != nil {
220 t.Fatal(err)
221 }
222 if err := journal.RecordAgentEvent(core.EvUserMessage{Message: provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "third"}}}}); err != nil {
223 t.Fatal(err)
224 }
225 if err := journal.Close(); err != nil {
226 t.Fatal(err)
227 }
228 older, err := ReadResidentHistoryPage(filepath.Join(root, spec.ID), page.OlderCursor, 1)
229 if err != nil || len(older.Items) != 1 {
230 t.Fatalf("older page = %#v, err=%v", older, err)
231 }
232}
233
234func TestResidentManagerHistoryRejectsPathTraversal(t *testing.T) {
235 manager := NewResidentManager(t.TempDir(), func(ResidentChildSpec, *ResidentJournal) (ResidentTurnRunner, error) {
236 return func(context.Context, string) error { return nil }, nil
237 })
238 if _, err := manager.History("../escape", 10); err == nil {
239 t.Fatal("History accepted traversal")
240 }
241 for _, childID := range []string{"../escape", "..", ".", "sub/child"} {
242 if _, err := manager.HistoryPage(childID, "", 10); err == nil {
243 t.Fatalf("HistoryPage(%q) accepted traversal", childID)
244 }
245 }
246}