1package agent
2
3import (
4 "net/http"
5 "os"
6 "path/filepath"
7 "strings"
8 "testing"
9
10 "github.com/patriceckhart/zot/packages/provider"
11)
12
13func TestReadAgentsContextLoadsGlobalAndAncestors(t *testing.T) {
14 root := t.TempDir()
15 zotHome := filepath.Join(root, "zot-home")
16 project := filepath.Join(root, "repo")
17 nested := filepath.Join(project, "packages", "app")
18 if err := os.MkdirAll(zotHome, 0o755); err != nil {
19 t.Fatal(err)
20 }
21 if err := os.MkdirAll(nested, 0o755); err != nil {
22 t.Fatal(err)
23 }
24 if err := os.WriteFile(filepath.Join(zotHome, "AGENTS.md"), []byte("global rule"), 0o644); err != nil {
25 t.Fatal(err)
26 }
27 if err := os.WriteFile(filepath.Join(project, "AGENTS.md"), []byte("repo rule"), 0o644); err != nil {
28 t.Fatal(err)
29 }
30 if err := os.WriteFile(filepath.Join(nested, "AGENTS.md"), []byte("app rule"), 0o644); err != nil {
31 t.Fatal(err)
32 }
33
34 got := readAgentsContext(nested, zotHome)
35 for _, want := range []string{"global rule", "repo rule", "app rule"} {
36 if !strings.Contains(got, want) {
37 t.Fatalf("readAgentsContext missing %q in:\n%s", want, got)
38 }
39 }
40 if strings.Index(got, "global rule") > strings.Index(got, "repo rule") || strings.Index(got, "repo rule") > strings.Index(got, "app rule") {
41 t.Fatalf("AGENTS.md files loaded in wrong order:\n%s", got)
42 }
43}
44
45func TestReadAgentsContextMissingFilesIsEmpty(t *testing.T) {
46 got := readAgentsContext(t.TempDir(), t.TempDir())
47 if got != "" {
48 t.Fatalf("expected no context, got %q", got)
49 }
50}
51
52// TestResolveFallsBackWhenConfiguredModelIsGone reproduces the
53// startup failure caught by the user's screenshot: the persisted
54// config.json points at a model id that's no longer in the active
55// catalogue (because they edited models.json or zot's bundled
56// catalogue changed). Resolve must NOT error — strands the user
57// with no way to fix it from the TUI — and should repair the config
58// so the next launch is silent.
59func TestResolveFallsBackWhenConfiguredModelIsGone(t *testing.T) {
60 t.Setenv("ZOT_HOME", t.TempDir())
61 t.Setenv("OPENAI_API_KEY", "test-key")
62 // Persist a stale model id.
63 stale := "gpt-5.5-pro-not-real"
64 if err := SaveConfig(Config{Provider: "openai", Model: stale}); err != nil {
65 t.Fatal(err)
66 }
67
68 r, err := Resolve(Args{}, false)
69 if err != nil {
70 t.Fatalf("Resolve refused to launch with stale model: %v", err)
71 }
72 if r.Model == stale {
73 t.Fatalf("Resolve kept stale model %q", r.Model)
74 }
75 if r.Provider != "openai" {
76 t.Errorf("provider drifted: got %q; want openai", r.Provider)
77 }
78
79 // Config on disk should now hold the fallback so subsequent
80 // launches don't repeat the warning.
81 cfg, _ := LoadConfig()
82 if cfg.Model == stale {
83 t.Errorf("config.json still pins the stale model %q", cfg.Model)
84 }
85 if cfg.Model == "" {
86 t.Errorf("config.json was emptied; expected the fallback model id")
87 }
88}
89
90// TestResolveExplicitFlagStaleDoesNotRepairConfig confirms the
91// repair-on-disk happens ONLY when the stale id came from the
92// persisted config. If the user passed --model X explicitly and X is
93// unknown, we still fall back, but we don't touch their config.
94func TestResolveExplicitFlagStaleDoesNotRepairConfig(t *testing.T) {
95 t.Setenv("ZOT_HOME", t.TempDir())
96 t.Setenv("OPENAI_API_KEY", "test-key")
97 good := "gpt-5"
98 if err := SaveConfig(Config{Provider: "openai", Model: good}); err != nil {
99 t.Fatal(err)
100 }
101
102 r, err := Resolve(Args{Model: "gpt-totally-fake"}, false)
103 if err != nil {
104 t.Fatalf("Resolve errored on unknown --model: %v", err)
105 }
106 if r.Model == "gpt-totally-fake" {
107 t.Errorf("Resolve kept the bogus --model value")
108 }
109 cfg, _ := LoadConfig()
110 if cfg.Model != good {
111 t.Errorf("config.json was clobbered (was %q; now %q)", good, cfg.Model)
112 }
113}
114
115// TestResolveEnvOnlyBedrockDiscoveredWithoutConfig reproduces issue
116// #15: pointing ZOT_HOME at a fresh dir drops the persisted
117// config.json (which pinned provider=amazon-bedrock). Resolve must
118// still discover bedrock from the AWS env vars instead of falling back
119// to anthropic and reporting "not logged in".
120func TestResolveEnvOnlyBedrockDiscoveredWithoutConfig(t *testing.T) {
121 t.Setenv("ZOT_HOME", t.TempDir()) // fresh home: no config.json
122 // Disable the Kimi CLI token fallback so a developer machine with a
123 // real Kimi CLI login doesn't pre-empt bedrock in the scan.
124 if err := SetKimiCLIFallbackDisabled(true); err != nil {
125 t.Fatal(err)
126 }
127 t.Setenv("AWS_BEARER_TOKEN_BEDROCK", "test-bedrock-token")
128 t.Setenv("AWS_REGION", "us-east-1")
129 // Make sure no other provider's env credential pre-empts bedrock.
130 for _, k := range []string{"ANTHROPIC_API_KEY", "ANTHROPIC_OAUTH_TOKEN", "OPENAI_API_KEY", "GEMINI_API_KEY", "GOOGLE_API_KEY", "DEEPSEEK_API_KEY", "KIMI_API_KEY", "MOONSHOT_API_KEY"} {
131 t.Setenv(k, "")
132 }
133
134 r, err := Resolve(Args{}, true)
135 if err != nil {
136 t.Fatalf("Resolve errored with env-only bedrock: %v", err)
137 }
138 if r.Provider != "amazon-bedrock" {
139 t.Fatalf("provider = %q, want amazon-bedrock", r.Provider)
140 }
141 if !r.HasCredential() {
142 t.Fatalf("bedrock credential not resolved from env")
143 }
144}
145
146func TestResolveOllamaUsesModelBaseURLBeforeDefault(t *testing.T) {
147 t.Setenv("ZOT_HOME", t.TempDir())
148 provider.SetLiveModels(nil)
149 defer provider.SetLiveModels(nil)
150 provider.SetUserModels([]provider.Model{{
151 Provider: "ollama",
152 ID: "qwen-local",
153 DisplayName: "Qwen Local",
154 ContextWindow: 32768,
155 MaxOutput: 8192,
156 BaseURL: "http://localhost:8000/v1",
157 }})
158
159 r, err := Resolve(Args{Provider: "ollama", Model: "qwen-local"}, false)
160 if err != nil {
161 t.Fatalf("Resolve failed: %v", err)
162 }
163 if r.BaseURL != "http://localhost:8000/v1" {
164 t.Fatalf("BaseURL = %q, want models.json baseUrl", r.BaseURL)
165 }
166}
167
168func TestResolveCustomProviderModelBaseURLBeatsProviderBaseURL(t *testing.T) {
169 t.Setenv("ZOT_HOME", t.TempDir())
170 t.Setenv("MY_COMPANY_API_KEY", "test-key")
171 path := filepath.Join(t.TempDir(), "models.json")
172 if err := os.WriteFile(path, []byte(`{
173 "providers": {
174 "my-company": {
175 "baseUrl": "https://provider.example.com/v1",
176 "api": "openai",
177 "models": [
178 {"id": "fast", "baseUrl": "https://model.example.com/v1"}
179 ]
180 }
181 }
182 }`), 0o644); err != nil {
183 t.Fatal(err)
184 }
185 models, warnings := provider.LoadUserModelsWithWarnings(path)
186 if len(warnings) != 0 {
187 t.Fatalf("warnings = %v", warnings)
188 }
189 provider.SetLiveModels(nil)
190 provider.SetUserModels(models)
191 t.Cleanup(func() { provider.SetLiveModels(nil) })
192
193 r, err := Resolve(Args{Provider: "my-company", Model: "fast"}, true)
194 if err != nil {
195 t.Fatalf("Resolve failed: %v", err)
196 }
197 if r.BaseURL != "https://model.example.com/v1" {
198 t.Fatalf("BaseURL = %q, want model-level baseUrl", r.BaseURL)
199 }
200}
201
202func TestResolveCustomProviderInsecureFromModelsJSONBaseURL(t *testing.T) {
203 t.Setenv("ZOT_HOME", t.TempDir())
204 t.Setenv("LOCAL_PROXY_API_KEY", "test-key")
205 path := filepath.Join(t.TempDir(), "models.json")
206 if err := os.WriteFile(path, []byte(`{
207 "providers": {
208 "local-proxy": {
209 "baseUrl": "https://proxy.example.com/v1",
210 "api": "openai",
211 "models": [{"id": "default"}]
212 }
213 }
214 }`), 0o644); err != nil {
215 t.Fatal(err)
216 }
217 models, warnings := provider.LoadUserModelsWithWarnings(path)
218 if len(warnings) != 0 {
219 t.Fatalf("warnings = %v", warnings)
220 }
221 provider.SetLiveModels(nil)
222 provider.SetUserModels(models)
223 t.Cleanup(func() { provider.SetLiveModels(nil) })
224
225 r, err := Resolve(Args{Provider: "local-proxy", Model: "default", InsecureTLS: true}, true)
226 if err != nil {
227 t.Fatalf("Resolve failed: %v", err)
228 }
229 if !r.InsecureTLS {
230 t.Fatal("InsecureTLS must be set for --insecure with models.json custom baseUrl")
231 }
232}
233
234func TestResolveOllamaFallsBackToDefaultBaseURL(t *testing.T) {
235 t.Setenv("ZOT_HOME", t.TempDir())
236 provider.SetLiveModels(nil)
237 defer provider.SetLiveModels(nil)
238
239 r, err := Resolve(Args{Provider: "ollama", Model: "any-local-model"}, false)
240 if err != nil {
241 t.Fatalf("Resolve failed: %v", err)
242 }
243 if r.BaseURL != "http://localhost:11434" {
244 t.Fatalf("BaseURL = %q, want ollama default", r.BaseURL)
245 }
246}
247
248func TestCanonicalProviderResolvesAliases(t *testing.T) {
249 cases := map[string]string{
250 "bedrock": "amazon-bedrock",
251 "AWS-Bedrock": "amazon-bedrock",
252 " bedrock ": "amazon-bedrock",
253 "vertex": "google-vertex",
254 "gemini": "google",
255 "azure": "azure-openai-responses",
256 "copilot": "github-copilot",
257 "codex": "openai-codex",
258 "moonshot": "moonshotai",
259 "vercel": "vercel-ai-gateway",
260 "hf": "huggingface",
261 "anthropic": "anthropic", // canonical passes through
262 "amazon-bedrock": "amazon-bedrock", // already canonical
263 "totally-unknown": "totally-unknown", // unknown returned unchanged (lowered)
264 "Totally-UNKNOWN": "totally-unknown",
265 "": "",
266 }
267 for in, want := range cases {
268 if got := canonicalProvider(in); got != want {
269 t.Errorf("canonicalProvider(%q) = %q, want %q", in, got, want)
270 }
271 }
272}
273
274func TestCanonicalProviderAliasesAreKnown(t *testing.T) {
275 for alias, canon := range providerAliases {
276 if !isKnownProvider(canon) {
277 t.Errorf("alias %q maps to %q which is not a known provider", alias, canon)
278 }
279 }
280}
281
282func TestResolveInsecureOnlyWithExplicitBaseURL(t *testing.T) {
283 orig := http.DefaultTransport
284 t.Cleanup(func() { http.DefaultTransport = orig })
285
286 t.Setenv("ZOT_HOME", t.TempDir())
287 t.Setenv("OPENAI_API_KEY", "test-key")
288
289 resolved, err := Resolve(Args{Provider: "moonshotai", InsecureTLS: true}, false)
290 if err != nil {
291 t.Fatalf("Resolve: %v", err)
292 }
293 if resolved.InsecureTLS {
294 t.Fatal("InsecureTLS must not be set for built-in provider base URLs")
295 }
296 assertDefaultTransportStillSecure(t)
297
298 resolved, err = Resolve(Args{Provider: "openai", InsecureTLS: true, BaseURL: "https://my-llm.internal/v1"}, false)
299 if err != nil {
300 t.Fatalf("Resolve: %v", err)
301 }
302 if !resolved.InsecureTLS {
303 t.Fatal("InsecureTLS must be set with --insecure and explicit --base-url")
304 }
305 assertDefaultTransportStillSecure(t)
306}
307
308func TestResolveInsecureFromConfigRequiresExplicitBaseURL(t *testing.T) {
309 orig := http.DefaultTransport
310 t.Cleanup(func() { http.DefaultTransport = orig })
311
312 t.Setenv("ZOT_HOME", t.TempDir())
313 t.Setenv("OPENAI_API_KEY", "test-key")
314 if err := SaveConfig(Config{Provider: "openai", Insecure: true}); err != nil {
315 t.Fatal(err)
316 }
317
318 resolved, err := Resolve(Args{Provider: "openai"}, false)
319 if err != nil {
320 t.Fatalf("Resolve: %v", err)
321 }
322 if resolved.InsecureTLS {
323 t.Fatal("InsecureTLS must not be set without a custom base URL")
324 }
325 assertDefaultTransportStillSecure(t)
326
327 resolved, err = Resolve(Args{Provider: "openai", BaseURL: "https://my-llm.internal/v1"}, false)
328 if err != nil {
329 t.Fatalf("Resolve: %v", err)
330 }
331 if !resolved.InsecureTLS {
332 t.Fatal("InsecureTLS must be set when config insecure=true and --base-url is provided")
333 }
334 assertDefaultTransportStillSecure(t)
335}
336
337func assertDefaultTransportStillSecure(t *testing.T) {
338 t.Helper()
339 tr, ok := http.DefaultTransport.(*http.Transport)
340 if !ok {
341 return
342 }
343 if tr.TLSClientConfig != nil && tr.TLSClientConfig.InsecureSkipVerify {
344 t.Fatal("http.DefaultTransport must not be made insecure")
345 }
346}