1package agent
2
3import (
4 "net/http"
5 "os"
6 "path/filepath"
7 "strings"
8 "testing"
9
10 "github.com/patriceckhart/zot/packages/provider"
11)
12
13func TestReadAgentsContextLoadsGlobalAndAncestors(t *testing.T) {
14 root := t.TempDir()
15 zotHome := filepath.Join(root, "zot-home")
16 project := filepath.Join(root, "repo")
17 nested := filepath.Join(project, "packages", "app")
18 if err := os.MkdirAll(zotHome, 0o755); err != nil {
19 t.Fatal(err)
20 }
21 if err := os.MkdirAll(nested, 0o755); err != nil {
22 t.Fatal(err)
23 }
24 if err := os.WriteFile(filepath.Join(zotHome, "AGENTS.md"), []byte("global rule"), 0o644); err != nil {
25 t.Fatal(err)
26 }
27 if err := os.WriteFile(filepath.Join(project, "AGENTS.md"), []byte("repo rule"), 0o644); err != nil {
28 t.Fatal(err)
29 }
30 if err := os.WriteFile(filepath.Join(nested, "AGENTS.md"), []byte("app rule"), 0o644); err != nil {
31 t.Fatal(err)
32 }
33
34 got := readAgentsContext(nested, zotHome)
35 for _, want := range []string{"global rule", "repo rule", "app rule"} {
36 if !strings.Contains(got, want) {
37 t.Fatalf("readAgentsContext missing %q in:\n%s", want, got)
38 }
39 }
40 if strings.Index(got, "global rule") > strings.Index(got, "repo rule") || strings.Index(got, "repo rule") > strings.Index(got, "app rule") {
41 t.Fatalf("AGENTS.md files loaded in wrong order:\n%s", got)
42 }
43}
44
45func TestReadAgentsContextMissingFilesIsEmpty(t *testing.T) {
46 got := readAgentsContext(t.TempDir(), t.TempDir())
47 if got != "" {
48 t.Fatalf("expected no context, got %q", got)
49 }
50}
51
52// TestResolveFallsBackWhenConfiguredModelIsGone reproduces the
53// startup failure caught by the user's screenshot: the persisted
54// config.json points at a model id that's no longer in the active
55// catalogue (because they edited models.json or zot's bundled
56// catalogue changed). Resolve must NOT error — strands the user
57// with no way to fix it from the TUI — and should repair the config
58// so the next launch is silent.
59func TestResolveFallsBackWhenConfiguredModelIsGone(t *testing.T) {
60 t.Setenv("ZOT_HOME", t.TempDir())
61 t.Setenv("OPENAI_API_KEY", "test-key")
62 // Persist a stale model id.
63 stale := "gpt-5.5-pro-not-real"
64 if err := SaveConfig(Config{Provider: "openai", Model: stale}); err != nil {
65 t.Fatal(err)
66 }
67
68 r, err := Resolve(Args{}, false)
69 if err != nil {
70 t.Fatalf("Resolve refused to launch with stale model: %v", err)
71 }
72 if r.Model == stale {
73 t.Fatalf("Resolve kept stale model %q", r.Model)
74 }
75 if r.Provider != "openai" {
76 t.Errorf("provider drifted: got %q; want openai", r.Provider)
77 }
78
79 // Config on disk should now hold the fallback so subsequent
80 // launches don't repeat the warning.
81 cfg, _ := LoadConfig()
82 if cfg.Model == stale {
83 t.Errorf("config.json still pins the stale model %q", cfg.Model)
84 }
85 if cfg.Model == "" {
86 t.Errorf("config.json was emptied; expected the fallback model id")
87 }
88}
89
90func TestResolveAppliesJailByDefault(t *testing.T) {
91 for _, tc := range []struct {
92 name string
93 config Config
94 want bool
95 }{
96 {name: "missing defaults to unlocked", config: Config{Provider: "openai", Model: "gpt-5"}},
97 {name: "enabled starts locked", config: Config{Provider: "openai", Model: "gpt-5", JailByDefault: boolPtr(true)}, want: true},
98 } {
99 t.Run(tc.name, func(t *testing.T) {
100 t.Setenv("ZOT_HOME", t.TempDir())
101 t.Setenv("OPENAI_API_KEY", "test-key")
102 if err := SaveConfig(tc.config); err != nil {
103 t.Fatal(err)
104 }
105
106 r, err := Resolve(Args{}, false)
107 if err != nil {
108 t.Fatalf("Resolve failed: %v", err)
109 }
110 if got := r.Sandbox.Locked(); got != tc.want {
111 t.Fatalf("sandbox locked = %v, want %v", got, tc.want)
112 }
113 })
114 }
115}
116
117func boolPtr(v bool) *bool { return &v }
118
119// TestResolveExplicitFlagStaleDoesNotRepairConfig confirms the
120// repair-on-disk happens ONLY when the stale id came from the
121// persisted config. If the user passed --model X explicitly and X is
122// unknown, we still fall back, but we don't touch their config.
123func TestResolveExplicitFlagStaleDoesNotRepairConfig(t *testing.T) {
124 t.Setenv("ZOT_HOME", t.TempDir())
125 t.Setenv("OPENAI_API_KEY", "test-key")
126 good := "gpt-5"
127 if err := SaveConfig(Config{Provider: "openai", Model: good}); err != nil {
128 t.Fatal(err)
129 }
130
131 r, err := Resolve(Args{Model: "gpt-totally-fake"}, false)
132 if err != nil {
133 t.Fatalf("Resolve errored on unknown --model: %v", err)
134 }
135 if r.Model == "gpt-totally-fake" {
136 t.Errorf("Resolve kept the bogus --model value")
137 }
138 cfg, _ := LoadConfig()
139 if cfg.Model != good {
140 t.Errorf("config.json was clobbered (was %q; now %q)", good, cfg.Model)
141 }
142}
143
144func TestResolveOpenRouterPreservesSavedRoutedModelID(t *testing.T) {
145 t.Setenv("ZOT_HOME", t.TempDir())
146 t.Setenv("OPENROUTER_API_KEY", "test-key")
147 want := "deepseek/deepseek-v4-flash"
148 if err := SaveConfig(Config{Provider: "openrouter", Model: want}); err != nil {
149 t.Fatal(err)
150 }
151
152 r, err := Resolve(Args{}, true)
153 if err != nil {
154 t.Fatalf("Resolve failed: %v", err)
155 }
156 if r.Provider != "openrouter" {
157 t.Fatalf("provider = %q, want openrouter", r.Provider)
158 }
159 if r.Model != want {
160 t.Fatalf("model = %q, want %q", r.Model, want)
161 }
162 if r.MaxOutput != 64000 {
163 t.Fatalf("MaxOutput = %d, want synthetic gateway default 64000", r.MaxOutput)
164 }
165}
166
167func TestResolveGatewayPlainUnknownModelFallsBack(t *testing.T) {
168 t.Setenv("ZOT_HOME", t.TempDir())
169 t.Setenv("OPENROUTER_API_KEY", "test-key")
170 stale := "not-a-routed-model"
171 if err := SaveConfig(Config{Provider: "openrouter", Model: stale}); err != nil {
172 t.Fatal(err)
173 }
174
175 r, err := Resolve(Args{}, true)
176 if err != nil {
177 t.Fatalf("Resolve failed: %v", err)
178 }
179 if r.Provider != "openrouter" {
180 t.Fatalf("provider = %q, want openrouter", r.Provider)
181 }
182 if r.Model == stale || r.Model == "" {
183 t.Fatalf("model = %q, want repaired gateway default", r.Model)
184 }
185}
186
187// TestResolveEnvOnlyBedrockDiscoveredWithoutConfig reproduces issue
188// #15: pointing ZOT_HOME at a fresh dir drops the persisted
189// config.json (which pinned provider=amazon-bedrock). Resolve must
190// still discover bedrock from the AWS env vars instead of falling back
191// to anthropic and reporting "not logged in".
192func TestResolveEnvOnlyBedrockDiscoveredWithoutConfig(t *testing.T) {
193 t.Setenv("ZOT_HOME", t.TempDir()) // fresh home: no config.json
194 // Disable the Kimi CLI token fallback so a developer machine with a
195 // real Kimi CLI login doesn't pre-empt bedrock in the scan.
196 if err := SetKimiCLIFallbackDisabled(true); err != nil {
197 t.Fatal(err)
198 }
199 t.Setenv("AWS_BEARER_TOKEN_BEDROCK", "test-bedrock-token")
200 t.Setenv("AWS_REGION", "us-east-1")
201 // Make sure no other provider's env credential pre-empts bedrock.
202 for _, k := range []string{"ANTHROPIC_API_KEY", "ANTHROPIC_OAUTH_TOKEN", "OPENAI_API_KEY", "GEMINI_API_KEY", "GOOGLE_API_KEY", "DEEPSEEK_API_KEY", "KIMI_API_KEY", "MOONSHOT_API_KEY"} {
203 t.Setenv(k, "")
204 }
205
206 r, err := Resolve(Args{}, true)
207 if err != nil {
208 t.Fatalf("Resolve errored with env-only bedrock: %v", err)
209 }
210 if r.Provider != "amazon-bedrock" {
211 t.Fatalf("provider = %q, want amazon-bedrock", r.Provider)
212 }
213 if !r.HasCredential() {
214 t.Fatalf("bedrock credential not resolved from env")
215 }
216}
217
218func TestResolveOllamaUsesModelBaseURLBeforeDefault(t *testing.T) {
219 t.Setenv("ZOT_HOME", t.TempDir())
220 provider.SetLiveModels(nil)
221 defer provider.SetLiveModels(nil)
222 provider.SetUserModels([]provider.Model{{
223 Provider: "ollama",
224 ID: "qwen-local",
225 DisplayName: "Qwen Local",
226 ContextWindow: 32768,
227 MaxOutput: 8192,
228 BaseURL: "http://localhost:8000/v1",
229 }})
230
231 r, err := Resolve(Args{Provider: "ollama", Model: "qwen-local"}, false)
232 if err != nil {
233 t.Fatalf("Resolve failed: %v", err)
234 }
235 if r.BaseURL != "http://localhost:8000/v1" {
236 t.Fatalf("BaseURL = %q, want models.json baseUrl", r.BaseURL)
237 }
238}
239
240func TestResolveCustomProviderModelBaseURLBeatsProviderBaseURL(t *testing.T) {
241 t.Setenv("ZOT_HOME", t.TempDir())
242 t.Setenv("MY_COMPANY_API_KEY", "test-key")
243 path := filepath.Join(t.TempDir(), "models.json")
244 if err := os.WriteFile(path, []byte(`{
245 "providers": {
246 "my-company": {
247 "baseUrl": "https://provider.example.com/v1",
248 "api": "openai",
249 "models": [
250 {"id": "fast", "baseUrl": "https://model.example.com/v1"}
251 ]
252 }
253 }
254 }`), 0o644); err != nil {
255 t.Fatal(err)
256 }
257 models, warnings := provider.LoadUserModelsWithWarnings(path)
258 if len(warnings) != 0 {
259 t.Fatalf("warnings = %v", warnings)
260 }
261 provider.SetLiveModels(nil)
262 provider.SetUserModels(models)
263 t.Cleanup(func() { provider.SetLiveModels(nil) })
264
265 r, err := Resolve(Args{Provider: "my-company", Model: "fast"}, true)
266 if err != nil {
267 t.Fatalf("Resolve failed: %v", err)
268 }
269 if r.BaseURL != "https://model.example.com/v1" {
270 t.Fatalf("BaseURL = %q, want model-level baseUrl", r.BaseURL)
271 }
272}
273
274func TestResolveCustomProviderInsecureFromModelsJSONBaseURL(t *testing.T) {
275 t.Setenv("ZOT_HOME", t.TempDir())
276 t.Setenv("LOCAL_PROXY_API_KEY", "test-key")
277 path := filepath.Join(t.TempDir(), "models.json")
278 if err := os.WriteFile(path, []byte(`{
279 "providers": {
280 "local-proxy": {
281 "baseUrl": "https://proxy.example.com/v1",
282 "api": "openai",
283 "models": [{"id": "default"}]
284 }
285 }
286 }`), 0o644); err != nil {
287 t.Fatal(err)
288 }
289 models, warnings := provider.LoadUserModelsWithWarnings(path)
290 if len(warnings) != 0 {
291 t.Fatalf("warnings = %v", warnings)
292 }
293 provider.SetLiveModels(nil)
294 provider.SetUserModels(models)
295 t.Cleanup(func() { provider.SetLiveModels(nil) })
296
297 r, err := Resolve(Args{Provider: "local-proxy", Model: "default", InsecureTLS: true}, true)
298 if err != nil {
299 t.Fatalf("Resolve failed: %v", err)
300 }
301 if !r.InsecureTLS {
302 t.Fatal("InsecureTLS must be set for --insecure with models.json custom baseUrl")
303 }
304}
305
306func TestResolveOllamaFallsBackToDefaultBaseURL(t *testing.T) {
307 t.Setenv("ZOT_HOME", t.TempDir())
308 provider.SetLiveModels(nil)
309 defer provider.SetLiveModels(nil)
310
311 r, err := Resolve(Args{Provider: "ollama", Model: "any-local-model"}, false)
312 if err != nil {
313 t.Fatalf("Resolve failed: %v", err)
314 }
315 if r.BaseURL != "http://localhost:11434" {
316 t.Fatalf("BaseURL = %q, want ollama default", r.BaseURL)
317 }
318}
319
320func TestCanonicalProviderResolvesAliases(t *testing.T) {
321 cases := map[string]string{
322 "bedrock": "amazon-bedrock",
323 "AWS-Bedrock": "amazon-bedrock",
324 " bedrock ": "amazon-bedrock",
325 "vertex": "google-vertex",
326 "gemini": "google",
327 "azure": "azure-openai-responses",
328 "copilot": "github-copilot",
329 "codex": "openai-codex",
330 "moonshot": "moonshotai",
331 "vercel": "vercel-ai-gateway",
332 "hf": "huggingface",
333 "anthropic": "anthropic", // canonical passes through
334 "amazon-bedrock": "amazon-bedrock", // already canonical
335 "totally-unknown": "totally-unknown", // unknown returned unchanged (lowered)
336 "Totally-UNKNOWN": "totally-unknown",
337 "": "",
338 }
339 for in, want := range cases {
340 if got := canonicalProvider(in); got != want {
341 t.Errorf("canonicalProvider(%q) = %q, want %q", in, got, want)
342 }
343 }
344}
345
346func TestCanonicalProviderAliasesAreKnown(t *testing.T) {
347 for alias, canon := range providerAliases {
348 if !isKnownProvider(canon) {
349 t.Errorf("alias %q maps to %q which is not a known provider", alias, canon)
350 }
351 }
352}
353
354func TestResolveInsecureOnlyWithExplicitBaseURL(t *testing.T) {
355 orig := http.DefaultTransport
356 t.Cleanup(func() { http.DefaultTransport = orig })
357
358 t.Setenv("ZOT_HOME", t.TempDir())
359 t.Setenv("OPENAI_API_KEY", "test-key")
360
361 resolved, err := Resolve(Args{Provider: "moonshotai", InsecureTLS: true}, false)
362 if err != nil {
363 t.Fatalf("Resolve: %v", err)
364 }
365 if resolved.InsecureTLS {
366 t.Fatal("InsecureTLS must not be set for built-in provider base URLs")
367 }
368 assertDefaultTransportStillSecure(t)
369
370 resolved, err = Resolve(Args{Provider: "openai", InsecureTLS: true, BaseURL: "https://my-llm.internal/v1"}, false)
371 if err != nil {
372 t.Fatalf("Resolve: %v", err)
373 }
374 if !resolved.InsecureTLS {
375 t.Fatal("InsecureTLS must be set with --insecure and explicit --base-url")
376 }
377 assertDefaultTransportStillSecure(t)
378}
379
380func TestResolveInsecureFromConfigRequiresExplicitBaseURL(t *testing.T) {
381 orig := http.DefaultTransport
382 t.Cleanup(func() { http.DefaultTransport = orig })
383
384 t.Setenv("ZOT_HOME", t.TempDir())
385 t.Setenv("OPENAI_API_KEY", "test-key")
386 if err := SaveConfig(Config{Provider: "openai", Insecure: true}); err != nil {
387 t.Fatal(err)
388 }
389
390 resolved, err := Resolve(Args{Provider: "openai"}, false)
391 if err != nil {
392 t.Fatalf("Resolve: %v", err)
393 }
394 if resolved.InsecureTLS {
395 t.Fatal("InsecureTLS must not be set without a custom base URL")
396 }
397 assertDefaultTransportStillSecure(t)
398
399 resolved, err = Resolve(Args{Provider: "openai", BaseURL: "https://my-llm.internal/v1"}, false)
400 if err != nil {
401 t.Fatalf("Resolve: %v", err)
402 }
403 if !resolved.InsecureTLS {
404 t.Fatal("InsecureTLS must be set when config insecure=true and --base-url is provided")
405 }
406 assertDefaultTransportStillSecure(t)
407}
408
409func TestDefaultXAIModelIsGrok45(t *testing.T) {
410 if got := defaultModelForProvider("xai"); got != "grok-4.5" {
411 t.Fatalf("default xAI model = %q, want grok-4.5", got)
412 }
413}
414
415func assertDefaultTransportStillSecure(t *testing.T) {
416 t.Helper()
417 tr, ok := http.DefaultTransport.(*http.Transport)
418 if !ok {
419 return
420 }
421 if tr.TLSClientConfig != nil && tr.TLSClientConfig.InsecureSkipVerify {
422 t.Fatal("http.DefaultTransport must not be made insecure")
423 }
424}