1package agent
2
3import (
4 "context"
5 "encoding/json"
6 "errors"
7 "fmt"
8 "os"
9 "path/filepath"
10 "strings"
11 "sync"
12 "testing"
13 "time"
14
15 "github.com/bnema/zut/packages/agent/modes"
16 "github.com/bnema/zut/packages/agent/tools"
17 "github.com/bnema/zut/packages/core"
18 "github.com/bnema/zut/packages/provider"
19 "github.com/google/uuid"
20)
21
22func TestWireRetryLifecyclePersistence(t *testing.T) {
23 session, err := core.NewSession(t.TempDir(), "/workspace", "provider", "model", "test")
24 if err != nil {
25 t.Fatal(err)
26 }
27 agent := core.NewAgent(nil, "model", "system", core.Registry{})
28 agent.SetMessages([]provider.Message{{
29 Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: "hello"}},
30 }})
31 wireRetryLifecyclePersistence(agent, session)
32 if agent.OnRetryLifecycle == nil {
33 t.Fatal("session-backed agent has no retry lifecycle persistence")
34 }
35 agent.OnRetryLifecycle(core.RetryLifecycleRecord{
36 Event: core.RetryLifecycleRequestFailed, Scope: core.RetryScopeAgent,
37 Attempt: 1, MaxAttempts: 1, Reason: core.RetryReasonServer, Terminal: true,
38 })
39 // Headless modes call WriteNewTranscript on both success and provider
40 // failure. Exercise that real finalization path rather than draining the
41 // session buffer directly.
42 if err := WriteNewTranscript(agent, session, 0); err != nil {
43 t.Fatal(err)
44 }
45 path := session.Path
46 if err := session.Close(); err != nil {
47 t.Fatal(err)
48 }
49 raw, err := os.ReadFile(path)
50 if err != nil {
51 t.Fatal(err)
52 }
53 var lifecycle []core.RetryLifecycleRecord
54 for _, line := range strings.Split(strings.TrimSpace(string(raw)), "\n") {
55 var row struct {
56 Type string `json:"type"`
57 RetryLifecycle []core.RetryLifecycleRecord `json:"retry_lifecycle"`
58 }
59 if err := json.Unmarshal([]byte(line), &row); err != nil {
60 t.Fatal(err)
61 }
62 if row.Type == "usage" && len(row.RetryLifecycle) > 0 {
63 lifecycle = row.RetryLifecycle
64 }
65 }
66 if len(lifecycle) != 1 {
67 t.Fatalf("retry lifecycle = %#v, want one record", lifecycle)
68 }
69 record := lifecycle[0]
70 if record.Event != core.RetryLifecycleRequestFailed || record.Scope != core.RetryScopeAgent ||
71 record.Attempt != 1 || record.MaxAttempts != 1 || record.Reason != core.RetryReasonServer || !record.Terminal {
72 t.Fatalf("retry lifecycle record = %#v", record)
73 }
74
75 wireRetryLifecyclePersistence(agent, nil)
76 if agent.OnRetryLifecycle != nil {
77 t.Fatal("sessionless agent retained retry lifecycle persistence")
78 }
79}
80
81func TestToolResultPersistenceUsesBoundSession(t *testing.T) {
82 root := t.TempDir()
83 original, err := core.NewSession(root, "original", "provider", "model", "test")
84 if err != nil {
85 t.Fatal(err)
86 }
87 defer original.Close()
88 next, err := core.NewSession(root, "next", "provider", "model", "test")
89 if err != nil {
90 t.Fatal(err)
91 }
92 defer next.Close()
93 for _, sess := range []*core.Session{original, next} {
94 if err := sess.UpdateGoal(&core.SessionGoal{Objective: "finish", Status: core.GoalActive}); err != nil {
95 t.Fatal(err)
96 }
97 }
98
99 boundSession := original
100 currentSession := next // Simulate a completed session switch before callback delivery.
101 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalDone}}
102 if err := persistToolResultState(nil, boundSession, result); err != nil {
103 t.Fatal(err)
104 }
105
106 if original.Meta.Goal == nil || original.Meta.Goal.Status != core.GoalDone {
107 t.Fatalf("original goal = %#v, want done", original.Meta.Goal)
108 }
109 if currentSession.Meta.Goal == nil || currentSession.Meta.Goal.Status != core.GoalActive {
110 t.Fatalf("current goal = %#v, want active", currentSession.Meta.Goal)
111 }
112}
113
114func TestPersistToolResultStateUsesSafeGoalPersistenceCategories(t *testing.T) {
115 const privateGoal = "private goal text"
116 const privateMission = "private-mission-id"
117 const privateReason = "private active reason"
118 const privateSessionContent = "private session content"
119 var writeFailureGoal core.SessionGoal
120
121 newSession := func(t *testing.T) *core.Session {
122 t.Helper()
123 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
124 if err != nil {
125 t.Fatal(err)
126 }
127 if err := sess.AppendMessage(provider.Message{Role: provider.RoleUser, Content: []provider.Content{provider.TextBlock{Text: privateSessionContent}}}); err != nil {
128 t.Fatal(err)
129 }
130 t.Cleanup(func() { _ = sess.Close() })
131 return sess
132 }
133
134 tests := []struct {
135 name string
136 setup func(*testing.T) *core.Session
137 update tools.GoalUpdate
138 message string
139 assertUnchanged func(*testing.T, *core.Session)
140 }{
141 {
142 name: "active goal",
143 setup: func(t *testing.T) *core.Session {
144 sess := newSession(t)
145 if err := sess.UpdateGoal(&core.SessionGoal{Objective: privateGoal, Status: core.GoalActive}); err != nil {
146 t.Fatal(err)
147 }
148 return sess
149 },
150 update: tools.GoalUpdate{Status: core.GoalActive, Objective: privateGoal},
151 message: "goal transition rejected: the current goal is still active",
152 },
153 {
154 name: "mismatched mission",
155 setup: func(t *testing.T) *core.Session {
156 sess := newSession(t)
157 if err := sess.EnsureMission(privateGoal, core.MissionSourceUser); err != nil {
158 t.Fatal(err)
159 }
160 return sess
161 },
162 update: tools.GoalUpdate{Status: core.GoalActive, Objective: privateGoal, MissionID: privateMission},
163 message: "goal transition rejected: it does not belong to the active mission",
164 },
165 {
166 name: "storage unavailable",
167 setup: func(*testing.T) *core.Session { return nil },
168 update: tools.GoalUpdate{Status: core.GoalActive, Objective: privateGoal, MissionID: privateMission},
169 message: "goal state unavailable: session persistence is disabled",
170 },
171 {
172 name: "write failure",
173 setup: func(t *testing.T) *core.Session {
174 sess := newSession(t)
175 if err := sess.UpdateGoal(&core.SessionGoal{Objective: privateGoal, Status: core.GoalActive, Reason: privateReason}); err != nil {
176 t.Fatal(err)
177 }
178 writeFailureGoal = *sess.Meta.Goal
179 if err := sess.Close(); err != nil {
180 t.Fatal(err)
181 }
182 return sess
183 },
184 update: tools.GoalUpdate{Status: core.GoalDone},
185 message: "goal state could not be saved",
186 assertUnchanged: func(t *testing.T, sess *core.Session) {
187 t.Helper()
188 assertGoal := func(source string, goal *core.SessionGoal) {
189 t.Helper()
190 if goal == nil || goal.Status != writeFailureGoal.Status || goal.Objective != writeFailureGoal.Objective || goal.Reason != writeFailureGoal.Reason {
191 t.Fatalf("%s goal after failed update = %#v, want status=%q objective=%q reason=%q", source, goal, writeFailureGoal.Status, writeFailureGoal.Objective, writeFailureGoal.Reason)
192 }
193 }
194 assertGoal("in-memory", sess.Meta.Goal)
195 snapshot, err := core.ReadSessionSnapshot(sess.Path)
196 if err != nil {
197 t.Fatal(err)
198 }
199 assertGoal("persisted", snapshot.Meta.Goal)
200 },
201 },
202 }
203 for _, test := range tests {
204 t.Run(test.name, func(t *testing.T) {
205 sess := test.setup(t)
206 err := persistToolResultState(nil, sess, core.ToolResult{Details: test.update})
207 var safe *core.ToolResultCommitError
208 if !errors.As(err, &safe) {
209 t.Fatalf("persist error = %T %v, want safe tool result commit error", err, err)
210 }
211 if safe.Message != test.message {
212 t.Fatalf("safe message = %q, want %q", safe.Message, test.message)
213 }
214 if strings.Contains(safe.Message, privateGoal) || strings.Contains(safe.Message, privateMission) || strings.Contains(safe.Message, privateSessionContent) || (sess != nil && strings.Contains(safe.Message, sess.Path)) {
215 t.Fatalf("safe message leaked private state: %q", safe.Message)
216 }
217 if test.assertUnchanged != nil {
218 test.assertUnchanged(t, sess)
219 }
220 })
221 }
222}
223
224func TestPersistGoalToolResultStartsManagerMission(t *testing.T) {
225 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
226 if err != nil {
227 t.Fatal(err)
228 }
229 defer sess.Close()
230
231 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "reproduce the reported failure"}}
232 if err := persistGoalToolResult(sess, result); err != nil {
233 t.Fatal(err)
234 }
235 goal := sess.Meta.Goal
236 if goal == nil || goal.Status != core.GoalActive || goal.Objective != "reproduce the reported failure" || goal.Owner != core.GoalOwnerManager {
237 t.Fatalf("persisted goal = %#v", goal)
238 }
239 mission := sess.Meta.Mission
240 if mission == nil || mission.Source != core.MissionSourceManager || mission.Objective != goal.Objective || mission.ID != goal.MissionID || mission.ActiveGoalID != goal.ID {
241 t.Fatalf("persisted mission = %#v, goal = %#v", mission, goal)
242 }
243}
244
245func TestPersistGoalToolResultAppliesConfiguredBudget(t *testing.T) {
246 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
247 if err != nil {
248 t.Fatal(err)
249 }
250 defer sess.Close()
251 if err := sess.EnsureMission("reproduce the reported failure", core.MissionSourceUser); err != nil {
252 t.Fatal(err)
253 }
254
255 budget := uint64(1_000_000)
256 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "reproduce the reported failure", MissionID: sess.Meta.Mission.ID}}
257 if err := persistGoalToolResult(sess, result, &budget); err != nil {
258 t.Fatal(err)
259 }
260 if goal := sess.Meta.Goal; goal == nil || goal.TokenBudget == nil || *goal.TokenBudget != budget {
261 t.Fatalf("persisted goal budget = %#v", goal)
262 }
263}
264
265func TestPersistGoalToolResultStartsGoalInCurrentMissionWithoutID(t *testing.T) {
266 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
267 if err != nil {
268 t.Fatal(err)
269 }
270 defer sess.Close()
271 if err := sess.EnsureMission("fix the reported failure", core.MissionSourceUser); err != nil {
272 t.Fatal(err)
273 }
274 missionID := sess.Meta.Mission.ID
275
276 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "inspect the failure"}}
277 if err := persistGoalToolResult(sess, result); err != nil {
278 t.Fatal(err)
279 }
280 goal := sess.Meta.Goal
281 if goal == nil || goal.Status != core.GoalActive || goal.MissionID != missionID {
282 t.Fatalf("goal = %#v, want active goal in mission %q", goal, missionID)
283 }
284}
285
286func TestPersistGoalToolResultRejectsActiveGoalReplacement(t *testing.T) {
287 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
288 if err != nil {
289 t.Fatal(err)
290 }
291 defer sess.Close()
292 if err := sess.UpdateGoal(&core.SessionGoal{Objective: "current work", Status: core.GoalActive}); err != nil {
293 t.Fatal(err)
294 }
295
296 err = persistGoalToolResult(sess, core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "unrelated work"}})
297 if err == nil {
298 t.Fatal("active goal replacement succeeded")
299 }
300 if got := sess.Meta.Goal; got == nil || got.Objective != "current work" || got.Status != core.GoalActive {
301 t.Fatalf("persisted goal = %#v", got)
302 }
303}
304
305func TestPersistGoalToolResultCreatesNextGoalInMission(t *testing.T) {
306 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
307 if err != nil {
308 t.Fatal(err)
309 }
310 defer sess.Close()
311 if err := sess.UpdateGoal(&core.SessionGoal{Objective: "reproduce", Status: core.GoalActive}); err != nil {
312 t.Fatal(err)
313 }
314 missionID := sess.Meta.Mission.ID
315 if err := persistGoalToolResult(sess, core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalDone}}); err != nil {
316 t.Fatal(err)
317 }
318 if err := persistGoalToolResult(sess, core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "implement fix", MissionID: missionID}}); err != nil {
319 t.Fatal(err)
320 }
321 goal := sess.Meta.Goal
322 if goal == nil || goal.Objective != "implement fix" || goal.MissionID != missionID || goal.Owner != core.GoalOwnerManager || goal.Ordinal != 3 {
323 t.Fatalf("next goal = %#v", goal)
324 }
325}
326
327func TestPersistGoalToolResultRejectsMismatchedMission(t *testing.T) {
328 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "provider", "model", "version")
329 if err != nil {
330 t.Fatal(err)
331 }
332 defer sess.Close()
333 if err := sess.EnsureMission("current work", core.MissionSourceUser); err != nil {
334 t.Fatal(err)
335 }
336
337 err = persistGoalToolResult(sess, core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalActive, Objective: "next work", MissionID: "other-mission"}})
338 if err == nil {
339 t.Fatal("mismatched mission was accepted")
340 }
341}
342
343func TestPersistGoalToolResultRejectsBlockedWithoutReason(t *testing.T) {
344 sess, err := core.NewSession(t.TempDir(), "cwd", "provider", "model", "test")
345 if err != nil {
346 t.Fatal(err)
347 }
348 defer sess.Close()
349 if err := sess.UpdateGoal(&core.SessionGoal{Objective: "finish the change", Status: core.GoalActive}); err != nil {
350 t.Fatal(err)
351 }
352
353 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalBlocked}}
354 if err := persistGoalToolResult(sess, result); err != nil {
355 t.Fatal(err)
356 }
357 if got := sess.Meta.Goal; got == nil || got.Status != core.GoalActive {
358 t.Fatalf("persisted goal = %#v, want active", got)
359 }
360}
361
362func TestPersistGoalToolResultUpdatesActiveGoal(t *testing.T) {
363 sess, err := core.NewSession(t.TempDir(), "cwd", "provider", "model", "test")
364 if err != nil {
365 t.Fatal(err)
366 }
367 defer sess.Close()
368 if err := sess.UpdateGoal(&core.SessionGoal{Objective: "finish the change", Status: core.GoalActive}); err != nil {
369 t.Fatal(err)
370 }
371
372 result := core.ToolResult{Details: tools.GoalUpdate{Status: core.GoalBlocked, Reason: "need user input"}}
373 if err := persistGoalToolResult(sess, result); err != nil {
374 t.Fatal(err)
375 }
376 if got := sess.Meta.Goal; got == nil || got.Status != core.GoalBlocked || got.Reason != "need user input" {
377 t.Fatalf("persisted goal = %#v", got)
378 }
379}
380
381type failingStdinReader struct{}
382
383func (failingStdinReader) Read([]byte) (int, error) { return 0, errors.New("stdin failed") }
384
385func TestReadAllStdinFromPropagatesReadErrors(t *testing.T) {
386 if _, err := readAllStdinFrom(failingStdinReader{}); err == nil || !strings.Contains(err.Error(), "stdin failed") {
387 t.Fatalf("readAllStdinFrom error = %v, want stdin failure", err)
388 }
389}
390
391func TestOpenOrCreateSessionResumesByUUIDAcrossCWDAndAgentStores(t *testing.T) {
392 root := t.TempDir()
393 cwd := t.TempDir()
394 otherCWD := t.TempDir()
395 t.Setenv("ZUT_HOME", root)
396
397 session, err := core.NewSession(root, cwd, "provider", "model", "test")
398 if err != nil {
399 t.Fatal(err)
400 }
401 if err := session.AppendMessage(provider.Message{
402 Role: provider.RoleUser,
403 Content: []provider.Content{provider.TextBlock{Text: "resume me"}},
404 }); err != nil {
405 t.Fatal(err)
406 }
407 id := session.ID
408 if err := session.Close(); err != nil {
409 t.Fatal(err)
410 }
411
412 ag := core.NewAgent(nil, "model", "", nil)
413 got, err := openOrCreateSession(context.Background(), Args{
414 CWD: otherCWD,
415 Resume: true,
416 ResumeSessionID: id,
417 }, Resolved{Provider: "provider", Model: "model"}, ag, "test")
418 if err != nil {
419 t.Fatal(err)
420 }
421 if got == nil || got.ID != id || got.Meta.CWD != cwd {
422 t.Fatalf("resumed session = %#v, want id=%q cwd=%q", got, id, cwd)
423 }
424 if got := firstMessageText(ag.Messages()); got != "resume me" {
425 t.Fatalf("resumed message = %q, want resume me", got)
426 }
427 if err := got.Close(); err != nil {
428 t.Fatal(err)
429 }
430
431 namedRoot := filepath.Join(root, "sessions", "agents", "demo")
432 named, err := core.NewSession(namedRoot, cwd, "provider", "model", "test")
433 if err != nil {
434 t.Fatal(err)
435 }
436 if err := named.AppendMessage(provider.Message{
437 Role: provider.RoleUser,
438 Content: []provider.Content{provider.TextBlock{Text: "named resume me"}},
439 }); err != nil {
440 t.Fatal(err)
441 }
442 namedID := named.ID
443 if err := named.Close(); err != nil {
444 t.Fatal(err)
445 }
446
447 namedAgent := core.NewAgent(nil, "model", "", nil)
448 namedGot, err := openOrCreateSession(context.Background(), Args{
449 CWD: otherCWD,
450 Resume: true,
451 ResumeSessionID: namedID,
452 }, Resolved{Provider: "provider", Model: "model"}, namedAgent, "test")
453 if err != nil {
454 t.Fatal(err)
455 }
456 if namedGot == nil || namedGot.ID != namedID || namedGot.Path != named.Path {
457 t.Fatalf("named resumed session = %#v, want path %q", namedGot, named.Path)
458 }
459 if got := firstMessageText(namedAgent.Messages()); got != "named resume me" {
460 t.Fatalf("named resumed message = %q, want named resume me", got)
461 }
462 if err := namedGot.Close(); err != nil {
463 t.Fatal(err)
464 }
465}
466
467func TestResumeHintSuppressesEmptyAndArbitrarySessions(t *testing.T) {
468 root := t.TempDir()
469 cwd := t.TempDir()
470
471 empty, err := core.NewSession(root, cwd, "provider", "model", "test")
472 if err != nil {
473 t.Fatal(err)
474 }
475 if err := empty.Close(); err != nil {
476 t.Fatal(err)
477 }
478 if _, err := os.Stat(empty.Path); !os.IsNotExist(err) {
479 t.Fatalf("empty session stat error = %v, want deleted", err)
480 }
481 if got := resumableSessionID(root, empty, false); got != "" {
482 t.Fatalf("empty session hint ID = %q, want empty", got)
483 }
484
485 arbitraryPath := filepath.Join(t.TempDir(), "session.jsonl")
486 arbitrary, err := core.NewSessionAtPath(arbitraryPath, cwd, "provider", "model", "test")
487 if err != nil {
488 t.Fatal(err)
489 }
490 if err := arbitrary.AppendMessage(provider.Message{
491 Role: provider.RoleUser,
492 Content: []provider.Content{provider.TextBlock{Text: "arbitrary"}},
493 }); err != nil {
494 t.Fatal(err)
495 }
496 if err := arbitrary.Close(); err != nil {
497 t.Fatal(err)
498 }
499 if got := resumableSessionID(root, arbitrary, true); got != "" {
500 t.Fatalf("arbitrary session hint ID = %q, want empty", got)
501 }
502}
503
504func TestResumeHintSuppressesPersistedEmptyExplicitUUIDSession(t *testing.T) {
505 root := t.TempDir()
506 cwd := t.TempDir()
507 otherCWD := t.TempDir()
508 t.Setenv("ZUT_HOME", root)
509
510 dir := core.SessionsDir(root, cwd)
511 if err := os.MkdirAll(dir, 0o755); err != nil {
512 t.Fatal(err)
513 }
514 id := uuid.NewString()
515 metaLine := struct {
516 Type string `json:"type"`
517 Meta core.SessionMeta `json:"meta"`
518 }{
519 Type: "meta",
520 Meta: core.SessionMeta{
521 ID: id,
522 CWD: cwd,
523 Provider: "provider",
524 Model: "model",
525 Started: time.Now().UTC(),
526 Version: "test",
527 },
528 }
529 data, err := json.Marshal(metaLine)
530 if err != nil {
531 t.Fatal(err)
532 }
533 path := filepath.Join(dir, "persisted-empty.jsonl")
534 if err := os.WriteFile(path, append(data, '\n'), 0o644); err != nil {
535 t.Fatal(err)
536 }
537
538 sess, err := openOrCreateSession(context.Background(), Args{
539 CWD: otherCWD,
540 Resume: true,
541 ResumeSessionID: id,
542 }, Resolved{Provider: "provider", Model: "model"}, core.NewAgent(nil, "model", "", nil), "test")
543 if err != nil {
544 t.Fatal(err)
545 }
546 if sess == nil || sess.Path != path {
547 t.Fatalf("resumed persisted empty session = %#v, want path %q", sess, path)
548 }
549 if got := resumableSessionID(root, sess, false); got != "" {
550 t.Fatalf("persisted empty session hint ID = %q, want empty", got)
551 }
552 if err := sess.Close(); err != nil {
553 t.Fatal(err)
554 }
555}
556
557func TestOpenOrCreateSessionUnknownUUIDDoesNotCreateSession(t *testing.T) {
558 root := t.TempDir()
559 cwd := t.TempDir()
560 t.Setenv("ZUT_HOME", root)
561 id := uuid.NewString()
562
563 _, err := openOrCreateSession(context.Background(), Args{
564 CWD: cwd,
565 Resume: true,
566 ResumeSessionID: id,
567 }, Resolved{Provider: "provider", Model: "model"}, core.NewAgent(nil, "model", "", nil), "test")
568 if err == nil {
569 t.Fatal("unknown UUID resume unexpectedly succeeded")
570 }
571 if !strings.Contains(err.Error(), id) {
572 t.Fatalf("unknown UUID error = %v, want session ID", err)
573 }
574 if sessions := core.ListSessions(root, cwd); len(sessions) != 0 {
575 t.Fatalf("unknown UUID created sessions: %v", sessions)
576 }
577}
578
579func TestOpenOrCreateSessionUUIDLookupIgnoresUnrelatedCorruption(t *testing.T) {
580 root := t.TempDir()
581 cwd := t.TempDir()
582 t.Setenv("ZUT_HOME", root)
583 target, err := core.NewSession(root, cwd, "provider", "model", "test")
584 if err != nil {
585 t.Fatal(err)
586 }
587 if err := target.AppendMessage(provider.Message{
588 Role: provider.RoleUser,
589 Content: []provider.Content{provider.TextBlock{Text: "resume me"}},
590 }); err != nil {
591 t.Fatal(err)
592 }
593 if err := target.Close(); err != nil {
594 t.Fatal(err)
595 }
596 if err := os.WriteFile(filepath.Join(core.SessionsDir(root, cwd), "bad.jsonl"), []byte("not json\n"), 0o644); err != nil {
597 t.Fatal(err)
598 }
599
600 session, err := openOrCreateSession(context.Background(), Args{
601 CWD: cwd,
602 Resume: true,
603 ResumeSessionID: target.ID,
604 }, Resolved{Provider: "provider", Model: "model"}, core.NewAgent(nil, "model", "", nil), "test")
605 if err != nil {
606 t.Fatalf("openOrCreateSession: %v", err)
607 }
608 defer session.Close()
609 if session.Path != target.Path {
610 t.Fatalf("resumed session path = %q, want %q", session.Path, target.Path)
611 }
612}
613
614func TestResumeSessionHint(t *testing.T) {
615 id := uuid.NewString()
616 want := "Session ID: " + id + "\nResume with: zut --resume " + id + "\n\n"
617 if got := resumeSessionHint(id); got != want {
618 t.Fatalf("resume hint = %q, want %q", got, want)
619 }
620}
621
622func TestResumableSessionIDAcceptsManagedPersistedSession(t *testing.T) {
623 root := t.TempDir()
624 cwd := t.TempDir()
625 sess, err := core.NewSession(root, cwd, "provider", "model", "test")
626 if err != nil {
627 t.Fatal(err)
628 }
629 if err := sess.AppendMessage(provider.Message{
630 Role: provider.RoleUser,
631 Content: []provider.Content{provider.TextBlock{Text: "resume me"}},
632 }); err != nil {
633 t.Fatal(err)
634 }
635 if err := sess.Close(); err != nil {
636 t.Fatal(err)
637 }
638 if got := resumableSessionID(root, sess, true); got != sess.ID {
639 t.Fatalf("managed session hint ID = %q, want %q", got, sess.ID)
640 }
641}
642
643func TestTrimMessagesForResumeCarriesDeferredToolActivation(t *testing.T) {
644 msgs := make([]provider.Message, 0, 101)
645 msgs = append(msgs, provider.Message{
646 Role: provider.RoleTool,
647 AddedToolNames: []string{"lookup_weather"},
648 Content: []provider.Content{provider.ToolResultBlock{CallID: "old-call"}},
649 })
650 for idx := 1; idx < 101; idx++ {
651 msgs = append(msgs, provider.Message{
652 Role: provider.RoleUser,
653 Content: []provider.Content{provider.TextBlock{Text: "message"}},
654 })
655 }
656 trimmed := trimMessagesForResume(msgs, 100)
657 if len(trimmed) != 100 {
658 t.Fatalf("trimmed message count = %d, want 100", len(trimmed))
659 }
660 if len(trimmed[0].AddedToolNames) != 1 || trimmed[0].AddedToolNames[0] != "lookup_weather" {
661 t.Fatalf("trimmed activation markers = %v, want lookup_weather", trimmed[0].AddedToolNames)
662 }
663}
664
665func TestTrimMessagesForResumeKeepsCompactionSummaryAtTailBoundary(t *testing.T) {
666 for _, total := range []int{100, 101, 102} {
667 t.Run(fmt.Sprintf("%d messages", total), func(t *testing.T) {
668 msgs := make([]provider.Message, 0, total)
669 msgs = append(msgs, provider.Message{
670 Role: provider.RoleUser,
671 Meta: map[string]string{"compaction": "true"},
672 Content: []provider.Content{
673 provider.TextBlock{Text: "## Context Summary (compacted)"},
674 },
675 })
676 for idx := 1; idx < total; idx++ {
677 msgs = append(msgs, provider.Message{
678 Role: provider.RoleUser,
679 Content: []provider.Content{provider.TextBlock{Text: fmt.Sprintf("message-%d", idx)}},
680 })
681 }
682
683 trimmed := trimMessagesForResume(msgs, 100)
684 if len(trimmed) > 100 {
685 t.Fatalf("trimmed message count = %d, want at most 100", len(trimmed))
686 }
687 if len(trimmed) == 0 || trimmed[0].Meta["compaction"] != "true" {
688 t.Fatalf("trimmed transcript lost compaction summary: %+v", trimmed)
689 }
690 })
691 }
692}
693
694func TestLiveInteractiveAgentUsesReplacementAgentForSessionResume(t *testing.T) {
695 startup := core.NewAgent(nil, "startup-model", "", nil)
696 startup.SetMessages([]provider.Message{{
697 Role: provider.RoleUser,
698 Content: []provider.Content{provider.TextBlock{Text: "startup transcript"}},
699 }})
700
701 replacement := core.NewAgent(nil, "replacement-model", "", nil)
702 iv := modes.NewInteractive(modes.InteractiveConfig{Agent: replacement})
703
704 resumed := []provider.Message{{
705 Role: provider.RoleUser,
706 Content: []provider.Content{provider.TextBlock{Text: "resumed transcript"}},
707 }}
708 liveInteractiveAgent(iv, startup).SetMessages(resumed)
709
710 if got := firstMessageText(replacement.Messages()); got != "resumed transcript" {
711 t.Fatalf("replacement agent transcript = %q, want resumed transcript", got)
712 }
713 if got := firstMessageText(startup.Messages()); got != "startup transcript" {
714 t.Fatalf("startup agent transcript changed to %q", got)
715 }
716}
717
718func TestLiveInteractiveAgentFallsBackBeforeInteractiveConstruction(t *testing.T) {
719 startup := core.NewAgent(nil, "startup-model", "", nil)
720 if got := liveInteractiveAgent(nil, startup); got != startup {
721 t.Fatalf("fallback agent = %p, want %p", got, startup)
722 }
723}
724
725func TestPersistModelCallbackDoesNotReenterSessionTransition(t *testing.T) {
726 t.Setenv("ZUT_HOME", t.TempDir())
727 sess, err := core.NewSession(t.TempDir(), t.TempDir(), "old-provider", "old-model", "test")
728 if err != nil {
729 t.Fatal(err)
730 }
731 defer sess.Close()
732
733 var persistMu sync.Mutex
734 activeProvider, activeModel := "old-provider", "old-model"
735 persistModel := newPersistModelCallback(&persistMu, &sess, &activeProvider, &activeModel, nil)
736
737 var transitionMu sync.RWMutex
738 sessionTransition := newSessionTransition(&transitionMu)
739 done := make(chan struct{})
740 go func() {
741 sessionTransition(func() {
742 persistModel("new-provider", "new-model")
743 })
744 close(done)
745 }()
746 select {
747 case <-done:
748 case <-time.After(time.Second):
749 t.Fatal("model persistence deadlocked inside the session transition")
750 }
751 if sess.Meta.Provider != "new-provider" || sess.Meta.Model != "new-model" {
752 t.Fatalf("session model = %q/%q, want new-provider/new-model", sess.Meta.Provider, sess.Meta.Model)
753 }
754 if activeProvider != "new-provider" || activeModel != "new-model" {
755 t.Fatalf("active model = %q/%q, want new-provider/new-model", activeProvider, activeModel)
756 }
757}
758
759func firstMessageText(messages []provider.Message) string {
760 if len(messages) == 0 || len(messages[0].Content) == 0 {
761 return ""
762 }
763 text, _ := messages[0].Content[0].(provider.TextBlock)
764 return text.Text
765}
766
767func syntheticSession(t *testing.T, providerName, model string, usage provider.Usage) string {
768 t.Helper()
769 root := t.TempDir()
770 cwd := t.TempDir()
771 sess, err := core.NewSession(root, cwd, providerName, model, "test")
772 if err != nil {
773 t.Fatal(err)
774 }
775 if err := sess.AppendMessage(provider.Message{
776 Role: provider.RoleUser,
777 Content: []provider.Content{provider.TextBlock{Text: "resumed transcript"}},
778 }); err != nil {
779 t.Fatal(err)
780 }
781 if usage != (provider.Usage{}) {
782 if err := sess.AppendUsage(usage, usage); err != nil {
783 t.Fatal(err)
784 }
785 }
786 if err := sess.Close(); err != nil {
787 t.Fatal(err)
788 }
789 return sess.Path
790}
791
792func TestApplyInitialSessionResumeKeepsFreshEmptySessionOwned(t *testing.T) {
793 root := t.TempDir()
794 sess, err := core.NewSession(root, "/workspace", "provider", "model", "test")
795 if err != nil {
796 t.Fatal(err)
797 }
798 ag := core.NewAgent(nil, "model", "", nil)
799 gotSess, gotAgent, providerName, model, err := applyInitialSessionResume(context.Background(), Args{}, Resolved{Provider: "provider", Model: "model"}, nil, sess, ag)
800 if err != nil {
801 t.Fatal(err)
802 }
803 if gotSess != sess || gotAgent != ag || providerName != "provider" || model != "model" {
804 t.Fatalf("empty startup resume = session %p/%p agent %p/%p provider/model %q/%q", gotSess, sess, gotAgent, ag, providerName, model)
805 }
806 if _, err := os.Stat(sess.Path); err != nil {
807 t.Fatalf("fresh session disappeared before close: %v", err)
808 }
809 if err := sess.Close(); err != nil {
810 t.Fatal(err)
811 }
812 if _, err := os.Stat(sess.Path); !errors.Is(err, os.ErrNotExist) {
813 t.Fatalf("fresh empty session remained after close: %v", err)
814 }
815}
816
817func TestApplyInitialSessionResumeWithRuntimePreservesInheritedModelDefaults(t *testing.T) {
818 t.Setenv("ZUT_HOME", t.TempDir())
819 if err := SaveConfig(Config{Provider: "ollama", Model: "current-local-model"}); err != nil {
820 t.Fatal(err)
821 }
822 path := syntheticSession(t, "ollama", "stored-local-model", provider.Usage{})
823 args := Args{Mode: ModePrint, Orchestrate: true, CWD: t.TempDir()}
824 base, err := Resolve(args, true)
825 if err != nil {
826 t.Fatal(err)
827 }
828 current := base.NewAgent()
829 runtime := newSubagentRuntime(subagentRuntimeConfig{
830 Args: args,
831 Root: t.TempDir(),
832 RepoRoot: args.CWD,
833 Provider: base.Provider,
834 Model: base.Model,
835 })
836 defer func() { _ = runtime.Close(context.Background()) }()
837
838 sess, _, err := core.OpenSession(path)
839 if err != nil {
840 t.Fatal(err)
841 }
842 gotSess, gotAgent, providerName, model, err := applyInitialSessionResumeWithRuntime(context.Background(), args, base, nil, sess, current, runtime)
843 if err != nil {
844 t.Fatal(err)
845 }
846 defer gotSess.Close()
847 if gotAgent == current || providerName != "ollama" || model != "stored-local-model" {
848 t.Fatalf("resume candidate = rebuilt=%v provider/model=%q/%q", gotAgent == current, providerName, model)
849 }
850 if got := runtime.currentModel(); got != "stored-local-model" {
851 t.Fatalf("runtime inherited model = %q, want stored-local-model", got)
852 }
853 if _, ok := gotAgent.ToolsSnapshot()["subagent_spawn"]; !ok {
854 t.Fatal("resumed parent lost canonical subagent_spawn manager tool")
855 }
856}
857
858func TestPrepareSessionResumeRebuildsForStoredProviderAndModel(t *testing.T) {
859 old := core.NewAgent(nil, "old-model", "", nil)
860 old.SetMessages([]provider.Message{{
861 Role: provider.RoleUser,
862 Content: []provider.Content{provider.TextBlock{Text: "current transcript"}},
863 }})
864 path := syntheticSession(t, "stored-provider", "stored-model", provider.Usage{
865 InputTokens: 12,
866 OutputTokens: 7,
867 })
868
869 var gotProvider, gotModel string
870 candidate, err := prepareSessionResume(path, old, "current-provider", "old-model", func(providerName, model string) (*core.Agent, string, string, error) {
871 gotProvider, gotModel = providerName, model
872 return core.NewAgent(nil, model, "", nil), providerName, model, nil
873 })
874 if err != nil {
875 t.Fatal(err)
876 }
877 defer candidate.session.Close()
878
879 if gotProvider != "stored-provider" || gotModel != "stored-model" {
880 t.Fatalf("builder selection = %q/%q, want stored-provider/stored-model", gotProvider, gotModel)
881 }
882 if !candidate.rebuilt || candidate.agent == old {
883 t.Fatalf("candidate rebuilt = %v, agent=%p, old=%p", candidate.rebuilt, candidate.agent, old)
884 }
885 if got := firstMessageText(candidate.agent.Messages()); got != "resumed transcript" {
886 t.Fatalf("candidate transcript = %q, want resumed transcript", got)
887 }
888 if got := candidate.agent.Cost(); got.InputTokens != 12 || got.OutputTokens != 7 {
889 t.Fatalf("candidate usage = %+v, want input=12 output=7", got)
890 }
891 if got := old.Messages(); len(got) != 1 || firstMessageText(got) != "current transcript" {
892 t.Fatalf("current transcript changed during preparation: %+v", got)
893 }
894}
895
896func TestApplySessionResumeBindsRebuiltAgentToDurableSessionID(t *testing.T) {
897 path := syntheticSession(t, "stored-provider", "stored-model", provider.Usage{})
898 sess, _, err := core.OpenSession(path)
899 if err != nil {
900 t.Fatal(err)
901 }
902 defer sess.Close()
903
904 current := core.NewAgent(nil, "current-model", "", nil)
905 candidate, err := applySessionResume(sess, current, "current-provider", "current-model", false, false, func(providerName, model string) (*core.Agent, string, string, error) {
906 return core.NewAgent(nil, model, "", nil), providerName, model, nil
907 })
908 if err != nil {
909 t.Fatal(err)
910 }
911 defer candidate.session.Close()
912 if !candidate.rebuilt {
913 t.Fatal("resume did not rebuild the agent")
914 }
915 if got := candidate.agent.SessionID(); got != candidate.session.Meta.ID {
916 t.Fatalf("rebuilt agent session ID = %q, want durable session ID %q", got, candidate.session.Meta.ID)
917 }
918}
919
920func TestPrepareSessionResumeForWorkspaceRebuildsMatchingProviderAndModel(t *testing.T) {
921 path := syntheticSession(t, "provider", "model", provider.Usage{})
922 current := core.NewAgent(nil, "model", "", nil)
923 builds := 0
924 candidate, err := prepareSessionResumeForWorkspace(path, current, "provider", "model", func(providerName, model string) (*core.Agent, string, string, error) {
925 builds++
926 return core.NewAgent(nil, model, "", nil), providerName, model, nil
927 })
928 if err != nil {
929 t.Fatal(err)
930 }
931 defer candidate.session.Close()
932 if builds != 1 || !candidate.rebuilt || candidate.agent == current {
933 t.Fatalf("workspace resume = builds %d rebuilt %v agent=%p current=%p", builds, candidate.rebuilt, candidate.agent, current)
934 }
935}
936
937func TestPrepareSessionResumePreservesLegacyMissingMetadata(t *testing.T) {
938 old := core.NewAgent(nil, "old-model", "", nil)
939 old.SetMessages([]provider.Message{{
940 Role: provider.RoleUser,
941 Content: []provider.Content{provider.TextBlock{Text: "current transcript"}},
942 }})
943 path := syntheticSession(t, "", "", provider.Usage{})
944
945 candidate, err := prepareSessionResume(path, old, "current-provider", "old-model", func(string, string) (*core.Agent, string, string, error) {
946 t.Fatal("legacy session unexpectedly requested a rebuild")
947 return nil, "", "", nil
948 })
949 if err != nil {
950 t.Fatal(err)
951 }
952 defer candidate.session.Close()
953
954 if candidate.rebuilt || candidate.agent != old {
955 t.Fatalf("legacy candidate = rebuilt %v, agent=%p; want current agent without rebuild", candidate.rebuilt, candidate.agent)
956 }
957 if got := firstMessageText(old.Messages()); got != "current transcript" {
958 t.Fatalf("current transcript changed before commit: %q", got)
959 }
960 if got := firstMessageText(candidate.messages); got != "resumed transcript" {
961 t.Fatalf("legacy candidate transcript = %q, want resumed transcript", got)
962 }
963}
964
965func TestPrepareSessionResumePreservesCompactHandoffMetadata(t *testing.T) {
966 path := syntheticSession(t, "stored-provider", "stored-model", provider.Usage{})
967 session, _, err := core.OpenSession(path)
968 if err != nil {
969 t.Fatal(err)
970 }
971 handoff := json.RawMessage(`{"version":1,"reason":"status_rescue","rescue_attempts":1}`)
972 if err := session.UpdateCompactHandoff(handoff); err != nil {
973 t.Fatal(err)
974 }
975 if err := session.Close(); err != nil {
976 t.Fatal(err)
977 }
978
979 current := core.NewAgent(nil, "current-model", "", nil)
980 candidate, err := prepareSessionResume(path, current, "stored-provider", "stored-model", nil)
981 if err != nil {
982 t.Fatal(err)
983 }
984 defer candidate.session.Close()
985 if got := string(candidate.session.Meta.CompactHandoff); got != string(handoff) {
986 t.Fatalf("candidate compact handoff = %q, want %q", got, handoff)
987 }
988}
989
990func TestPrepareSessionResumeFailureLeavesCurrentAndCandidateFileUsable(t *testing.T) {
991 old := core.NewAgent(nil, "old-model", "", nil)
992 old.SetMessages([]provider.Message{{
993 Role: provider.RoleUser,
994 Content: []provider.Content{provider.TextBlock{Text: "current transcript"}},
995 }})
996 path := syntheticSession(t, "stored-provider", "stored-model", provider.Usage{})
997 wantErr := errors.New("synthetic builder failure")
998
999 if _, err := prepareSessionResume(path, old, "current-provider", "old-model", func(string, string) (*core.Agent, string, string, error) {
1000 return nil, "", "", wantErr
1001 }); !errors.Is(err, wantErr) {
1002 t.Fatalf("prepare error = %v, want %v", err, wantErr)
1003 }
1004 if got := firstMessageText(old.Messages()); got != "current transcript" {
1005 t.Fatalf("current transcript changed after failed preparation: %q", got)
1006 }
1007
1008 // The failed candidate must have released its append handle, leaving
1009 // the selected file readable and reopenable for a later retry.
1010 reopened, _, err := core.OpenSession(path)
1011 if err != nil {
1012 t.Fatalf("reopen candidate after failed preparation: %v", err)
1013 }
1014 if err := reopened.Close(); err != nil {
1015 t.Fatal(err)
1016 }
1017 if _, err := os.Stat(path); err != nil {
1018 t.Fatalf("candidate session disappeared after failed preparation: %v", err)
1019 }
1020}
1021
1022func TestPrepareSessionResumeHonorsExplicitProviderModelFields(t *testing.T) {
1023 for _, tc := range []struct {
1024 name string
1025 explicitProvider bool
1026 explicitModel bool
1027 wantProvider string
1028 wantModel string
1029 wantBuild bool
1030 }{
1031 {name: "both", explicitProvider: true, explicitModel: true, wantProvider: "current-provider", wantModel: "current-model"},
1032 {name: "provider-only", explicitProvider: true, wantProvider: "current-provider", wantModel: "stored-model", wantBuild: true},
1033 {name: "model-only", explicitModel: true, wantProvider: "stored-provider", wantModel: "current-model", wantBuild: true},
1034 } {
1035 t.Run(tc.name, func(t *testing.T) {
1036 old := core.NewAgent(nil, "old-model", "", nil)
1037 path := syntheticSession(t, "stored-provider", "stored-model", provider.Usage{})
1038 var gotProvider, gotModel string
1039 candidate, err := prepareSessionResumeWithOptions(path, old, "current-provider", "current-model", tc.explicitProvider, tc.explicitModel, false, func(providerName, model string) (*core.Agent, string, string, error) {
1040 gotProvider, gotModel = providerName, model
1041 return core.NewAgent(nil, model, "", nil), providerName, model, nil
1042 })
1043 if err != nil {
1044 t.Fatal(err)
1045 }
1046 defer candidate.session.Close()
1047 if tc.wantBuild {
1048 if gotProvider != tc.wantProvider || gotModel != tc.wantModel {
1049 t.Fatalf("builder selection = %q/%q, want %q/%q", gotProvider, gotModel, tc.wantProvider, tc.wantModel)
1050 }
1051 } else if candidate.provider != tc.wantProvider || candidate.model != tc.wantModel || candidate.rebuilt {
1052 t.Fatalf("candidate selection = %q/%q rebuilt=%v, want %q/%q without rebuild", candidate.provider, candidate.model, candidate.rebuilt, tc.wantProvider, tc.wantModel)
1053 }
1054 })
1055 }
1056}
1057
1058func TestWriteNewTranscriptTracksPartialAppend(t *testing.T) {
1059 sess, err := core.NewSession(t.TempDir(), "cwd", "provider", "model", "test")
1060 if err != nil {
1061 t.Fatal(err)
1062 }
1063 first := provider.Message{
1064 Role: provider.RoleUser,
1065 Content: []provider.Content{provider.TextBlock{Text: "first"}},
1066 }
1067 invalid := provider.Message{
1068 Role: provider.RoleAssistant,
1069 Content: []provider.Content{provider.ToolCallBlock{
1070 ID: "call-1",
1071 Name: "tool",
1072 Arguments: json.RawMessage("{"),
1073 }},
1074 }
1075 ag := core.NewAgent(nil, "model", "", nil)
1076 ag.SetMessages([]provider.Message{first, invalid})
1077 next, err := writeNewTranscriptLocked(ag, sess, 0)
1078 if err == nil {
1079 t.Fatal("writeNewTranscriptLocked succeeded with invalid message")
1080 }
1081 if next != 1 {
1082 t.Fatalf("next persisted message index = %d, want 1", next)
1083 }
1084
1085 second := provider.Message{
1086 Role: provider.RoleAssistant,
1087 Content: []provider.Content{provider.ToolCallBlock{ID: "call-1", Name: "tool", Arguments: json.RawMessage(`{}`)}},
1088 }
1089 third := provider.Message{
1090 Role: provider.RoleTool,
1091 Content: []provider.Content{provider.ToolResultBlock{CallID: "call-1", Content: []provider.Content{provider.TextBlock{Text: "done"}}}},
1092 }
1093 ag.SetMessages([]provider.Message{first, second, third})
1094 next, err = writeNewTranscriptLocked(ag, sess, next)
1095 if err != nil {
1096 t.Fatalf("retry transcript: %v", err)
1097 }
1098 if next != 3 {
1099 t.Fatalf("next persisted message index after retry = %d, want 3", next)
1100 }
1101 if err := sess.Close(); err != nil {
1102 t.Fatal(err)
1103 }
1104
1105 reopened, messages, err := core.OpenSession(sess.Path)
1106 if err != nil {
1107 t.Fatalf("reopen session: %v", err)
1108 }
1109 t.Cleanup(func() { _ = reopened.Close() })
1110 if len(messages) != 3 {
1111 t.Fatalf("replayed message count = %d, want 3", len(messages))
1112 }
1113 if repaired := provider.RepairOrphanedToolResults(messages); len(repaired) != len(messages) {
1114 t.Fatalf("replayed transcript lost tool pairing: %#v", messages)
1115 }
1116}