1package agent
2
3import (
4 "archive/tar"
5 "bytes"
6 "compress/gzip"
7 "errors"
8 "io"
9 "net/http"
10 "net/http/httptest"
11 "net/url"
12 "os"
13 "path/filepath"
14 "strings"
15 "testing"
16
17 "github.com/patriceckhart/zot/packages/agent/tools"
18 "github.com/patriceckhart/zot/packages/tui"
19)
20
21func TestReadZotfileConsentKeyAcceptsOnlyYesNo(t *testing.T) {
22 tests := []struct {
23 name string
24 input []byte
25 want byte
26 }{
27 {name: "lowercase yes", input: []byte{'y', '\r'}, want: 'y'},
28 {name: "uppercase yes", input: []byte{'Y', '\n'}, want: 'y'},
29 {name: "lowercase no", input: []byte{'n', '\r'}, want: 'n'},
30 {name: "uppercase no", input: []byte{'N', '\n'}, want: 'n'},
31 {name: "ignore unrelated keys", input: append([]byte("x\r\n\x1b[A"), 'y', '\r'), want: 'y'},
32 {name: "keep first valid answer", input: []byte{'n', 'y', '\r'}, want: 'n'},
33 {name: "backspace changes answer", input: []byte{'y', 0x7f, 'n', '\r'}, want: 'n'},
34 {name: "ctrl h changes answer", input: []byte{'n', '\b', 'y', '\r'}, want: 'y'},
35 {name: "backspace without answer is ignored", input: []byte{0x7f, 'y', '\r'}, want: 'y'},
36 }
37 for _, tt := range tests {
38 t.Run(tt.name, func(t *testing.T) {
39 var out bytes.Buffer
40 got, err := readZotfileConsentKey(bytes.NewReader(tt.input), func(answer byte) {
41 if answer == 0 {
42 out.Truncate(out.Len() - 1)
43 return
44 }
45 out.WriteByte(answer)
46 })
47 if err != nil {
48 t.Fatal(err)
49 }
50 if got != tt.want {
51 t.Fatalf("answer = %q, want %q", got, tt.want)
52 }
53 if out.String() != string(tt.want) {
54 t.Fatalf("echo = %q, want %q", out.String(), tt.want)
55 }
56 })
57 }
58}
59
60func TestReadZotfileConsentKeyWaitsForEnter(t *testing.T) {
61 var out bytes.Buffer
62 if _, err := readZotfileConsentKey(strings.NewReader("y"), func(answer byte) {
63 out.WriteByte(answer)
64 }); !errors.Is(err, io.EOF) {
65 t.Fatalf("error = %v, want EOF before Enter", err)
66 }
67 if out.String() != "y" {
68 t.Fatalf("echo = %q, want y", out.String())
69 }
70}
71
72func TestReadZotfileConsentKeyInterruptsOnCtrlC(t *testing.T) {
73 if _, err := readZotfileConsentKey(bytes.NewReader([]byte{'x', 3, 'y'}), nil); !errors.Is(err, errZotfileConsentInterrupted) {
74 t.Fatalf("error = %v, want interrupted", err)
75 }
76}
77
78func TestReadZotfileConsentKeyReportsInputError(t *testing.T) {
79 if _, err := readZotfileConsentKey(strings.NewReader("xxx"), nil); !errors.Is(err, io.EOF) {
80 t.Fatalf("error = %v, want EOF", err)
81 }
82}
83
84func writeTestZotfile(t *testing.T, manifest string) string {
85 t.Helper()
86 dir := t.TempDir()
87 if err := os.WriteFile(filepath.Join(dir, "manifest.json"), []byte(manifest), 0o600); err != nil {
88 t.Fatal(err)
89 }
90 if err := os.WriteFile(filepath.Join(dir, "AGENT.md"), []byte("Be useful."), 0o600); err != nil {
91 t.Fatal(err)
92 }
93 return dir
94}
95
96func TestLoadZotfileAllowsMissingAgentMD(t *testing.T) {
97 dir := t.TempDir()
98 if err := os.WriteFile(filepath.Join(dir, "manifest.json"), []byte(`{"zotfile":1,"name":"test"}`), 0o600); err != nil {
99 t.Fatal(err)
100 }
101 zf, cleanup, err := loadZotfile(dir)
102 if cleanup != nil {
103 defer cleanup()
104 }
105 if err != nil {
106 t.Fatalf("load without AGENT.md: %v", err)
107 }
108 if zf.Manifest.Name != "test" {
109 t.Fatalf("name = %q, want test", zf.Manifest.Name)
110 }
111}
112
113func TestValidateZotfileDirRejectsAgentMDDirectory(t *testing.T) {
114 dir := t.TempDir()
115 if err := os.Mkdir(filepath.Join(dir, "AGENT.md"), 0o700); err != nil {
116 t.Fatal(err)
117 }
118 if err := validateZotfileDir(dir); err == nil || !strings.Contains(err.Error(), "regular file") {
119 t.Fatalf("unexpected error: %v", err)
120 }
121}
122
123func TestLoadZotfileRejectsUnenforcedPermissions(t *testing.T) {
124 for _, field := range []string{
125 `"net":{"allow":["example.com"]}`,
126 `"env":{"read":["HOME"]}`,
127 } {
128 dir := writeTestZotfile(t, `{"zotfile":1,"name":"test","permissions":{`+field+`}}`)
129 if _, _, err := loadZotfile(dir); err == nil {
130 t.Fatalf("manifest with %s was accepted", field)
131 }
132 }
133}
134
135func TestLoadZotfileBashModes(t *testing.T) {
136 for _, mode := range []string{"none", "ask", "allowlist"} {
137 manifest := `{"zotfile":1,"name":"test","permissions":{"bash":{"mode":"` + mode + `"}}}`
138 if mode == "allowlist" {
139 manifest = `{"zotfile":1,"name":"test","permissions":{"bash":{"mode":"allowlist","allow":["git"]}}}`
140 }
141 dir := writeTestZotfile(t, manifest)
142 if _, _, err := loadZotfile(dir); err != nil {
143 t.Fatalf("mode %q rejected: %v", mode, err)
144 }
145 }
146 dir := writeTestZotfile(t, `{"zotfile":1,"name":"test","permissions":{"bash":{"mode":"all"}}}`)
147 if _, _, err := loadZotfile(dir); err == nil || !strings.Contains(err.Error(), "unsupported bash permission mode") {
148 t.Fatalf("unexpected error for all mode: %v", err)
149 }
150 dir = writeTestZotfile(t, `{"zotfile":1,"name":"test","permissions":{"bash":{"mode":"everything"}}}`)
151 if _, _, err := loadZotfile(dir); err == nil || !strings.Contains(err.Error(), "unsupported bash permission mode") {
152 t.Fatalf("unexpected error for unknown mode: %v", err)
153 }
154}
155
156func TestLoadZotfileRejectsUnsafeOrCollidingNames(t *testing.T) {
157 for _, name := range []string{"...", "Name", "two words", "a/b"} {
158 dir := writeTestZotfile(t, `{"zotfile":1,"name":"`+name+`"}`)
159 if _, _, err := loadZotfile(dir); err == nil {
160 t.Fatalf("unsafe manifest name %q was accepted", name)
161 }
162 }
163}
164
165func TestResolveZotfileRefUsesLocalFirstThenGitHubShorthand(t *testing.T) {
166 dir := t.TempDir()
167 t.Chdir(dir)
168 if err := os.Mkdir("local-agent", 0o700); err != nil {
169 t.Fatal(err)
170 }
171 if err := os.WriteFile("packed-agent.zot", []byte("test"), 0o600); err != nil {
172 t.Fatal(err)
173 }
174
175 tests := []struct {
176 ref string
177 want string
178 }{
179 {"local-agent", "local-agent"},
180 {"packed-agent", "packed-agent.zot"},
181 {"remote-agent", "remote-agent"},
182 {"missing.zot", "missing.zot"},
183 {"agents/remote-agent", "https://github.com/agents/remote-agent"},
184 {`agents\remote-agent`, "https://github.com/agents/remote-agent"},
185 {"frkr/zot-archify", "https://github.com/frkr/zot-archify"},
186 {"acme/agents/reviewer", "https://github.com/acme/agents/reviewer"},
187 {`acme\agents\reviewers\go`, "https://github.com/acme/agents/reviewers/go"},
188 {"./missing-agent", "./missing-agent"},
189 {"Remote-Agent", "Remote-Agent"},
190 {"https://github.com/acme/agents/example", "https://github.com/acme/agents/example"},
191 }
192 for _, tt := range tests {
193 got, err := resolveZotfileRef(tt.ref)
194 if err != nil {
195 t.Fatalf("resolve %q: %v", tt.ref, err)
196 }
197 if got != tt.want {
198 t.Errorf("resolve %q = %q, want %q", tt.ref, got, tt.want)
199 }
200 }
201}
202
203func TestLoadZotfileRejectsBundledExecutableExtension(t *testing.T) {
204 dir := writeTestZotfile(t, `{"zotfile":1,"name":"test"}`)
205 ext := filepath.Join(dir, "extensions", "bad")
206 if err := os.MkdirAll(ext, 0o700); err != nil {
207 t.Fatal(err)
208 }
209 if err := os.WriteFile(filepath.Join(ext, "extension.json"), []byte(`{"name":"bad"}`), 0o600); err != nil {
210 t.Fatal(err)
211 }
212 if _, _, err := loadZotfile(dir); err == nil || !strings.Contains(err.Error(), "cannot yet be confined") {
213 t.Fatalf("unexpected error: %v", err)
214 }
215}
216
217func TestCheckZotfileMinVersion(t *testing.T) {
218 var zf zotfileLoaded
219 zf.Manifest.Runtime.MinZot = "0.3.0"
220 if err := checkZotfileRequirements(zf, "0.2.75"); err == nil {
221 t.Fatal("old zot version accepted")
222 }
223 if err := checkZotfileRequirements(zf, "0.3.0"); err != nil {
224 t.Fatalf("minimum version rejected: %v", err)
225 }
226 if err := checkZotfileRequirements(zf, "not-a-version"); err == nil {
227 t.Fatal("invalid zot version accepted")
228 }
229
230 zf.Manifest.Runtime.MinZot = "not-a-version"
231 if err := checkZotfileRequirements(zf, "0.3.0"); err == nil {
232 t.Fatal("invalid min_zot requirement accepted")
233 }
234}
235
236func TestApplyZotfileModelRequirementsRejectsUnsupportedFields(t *testing.T) {
237 var m ZotfileManifest
238 m.Model.MinTier = "frontier"
239 if err := applyZotfileModelRequirements(&Args{}, m); err == nil {
240 t.Fatal("unsupported min_tier was ignored")
241 }
242 m.Model.MinTier = ""
243 m.Model.Requires = []string{"audio"}
244 if err := applyZotfileModelRequirements(&Args{}, m); err == nil {
245 t.Fatal("unsupported capability was ignored")
246 }
247}
248
249func TestUntarRejectsTraversalAndOversizedEntry(t *testing.T) {
250 makeTar := func(name string, size int64) []byte {
251 var buf bytes.Buffer
252 tw := tar.NewWriter(&buf)
253 if err := tw.WriteHeader(&tar.Header{Name: name, Mode: 0o600, Size: size}); err != nil {
254 t.Fatal(err)
255 }
256 _ = tw.Close()
257 return buf.Bytes()
258 }
259 if err := untar(bytes.NewReader(makeTar("../escape", 0)), t.TempDir()); err == nil {
260 t.Fatal("path traversal accepted")
261 }
262 if err := untar(bytes.NewReader(makeTar("large", maxZotfileEntrySize+1)), t.TempDir()); err == nil {
263 t.Fatal("oversized entry accepted")
264 }
265}
266
267func TestParseGitHubAgentURL(t *testing.T) {
268 tests := []struct {
269 input string
270 owner, repo, ref, dir string
271 }{
272 {"https://github.com/acme/agents/reviewer", "acme", "agents", "HEAD", "reviewer"},
273 {"https://github.com/acme/agents/tree/main/reviewer", "acme", "agents", "main", "reviewer"},
274 {"https://github.com/acme/agents/reviewers/go", "acme", "agents", "HEAD", "reviewers/go"},
275 {"https://github.com/acme/agent.git", "acme", "agent", "HEAD", ""},
276 }
277 for _, tt := range tests {
278 u, err := url.Parse(tt.input)
279 if err != nil {
280 t.Fatal(err)
281 }
282 owner, repo, ref, dir, err := parseGitHubAgentURL(u)
283 if err != nil {
284 t.Fatalf("parse %s: %v", tt.input, err)
285 }
286 if owner != tt.owner || repo != tt.repo || ref != tt.ref || dir != tt.dir {
287 t.Fatalf("parse %s = %q, %q, %q, %q", tt.input, owner, repo, ref, dir)
288 }
289 }
290}
291
292func TestLoadRemoteZotfileDownloadsTemporaryGitHubArchive(t *testing.T) {
293 var archive bytes.Buffer
294 gz := gzip.NewWriter(&archive)
295 tw := tar.NewWriter(gz)
296 files := map[string]string{
297 "agents-main/zot-maintenance/manifest.json": `{"zotfile":1,"name":"zot-maintenance"}`,
298 "agents-main/zot-maintenance/AGENT.md": "Maintain zot.",
299 }
300 for name, content := range files {
301 if err := tw.WriteHeader(&tar.Header{Name: name, Mode: 0o600, Size: int64(len(content))}); err != nil {
302 t.Fatal(err)
303 }
304 if _, err := tw.Write([]byte(content)); err != nil {
305 t.Fatal(err)
306 }
307 }
308 if err := tw.Close(); err != nil {
309 t.Fatal(err)
310 }
311 if err := gz.Close(); err != nil {
312 t.Fatal(err)
313 }
314
315 server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
316 w.Header().Set("Content-Type", "application/gzip")
317 _, _ = w.Write(archive.Bytes())
318 }))
319 defer server.Close()
320 oldArchiveURL := githubArchiveURL
321 githubArchiveURL = func(_, _, _ string) string { return server.URL }
322 t.Cleanup(func() { githubArchiveURL = oldArchiveURL })
323
324 u, _ := url.Parse("https://github.com/acme/agents/zot-maintenance")
325 zf, cleanup, err := loadRemoteZotfile(u)
326 if err != nil {
327 t.Fatal(err)
328 }
329 if zf.Manifest.Name != "zot-maintenance" || !zf.Temp {
330 t.Fatalf("unexpected zotfile: %+v", zf)
331 }
332 root := filepath.Dir(filepath.Dir(zf.Dir))
333 cleanup()
334 if _, err := os.Stat(root); !os.IsNotExist(err) {
335 t.Fatalf("temporary checkout was not removed: %v", err)
336 }
337}
338
339func TestFormatZotfileConsentUsesThemeColors(t *testing.T) {
340 th := tui.Theme{FG: 1, Muted: 2, Accent: 3, Assistant: 4, Warning: 5}
341 zf := zotfileLoaded{}
342 zf.Manifest.Name = "reviewer"
343 zf.Manifest.Version = "1.2.3"
344 perms := tools.PermissionSet{}
345 perms.FS.Read = []string{"/workspace"}
346 perms.Bash.Mode = "ask"
347
348 got := formatZotfileConsent(zf, perms, th, true)
349 for _, want := range []string{
350 th.FG256(th.Assistant, "Agent"),
351 th.FG256(th.Accent, "reviewer@1.2.3"),
352 th.FG256(th.Muted, " fs read: "),
353 th.FG256(th.FG, "/workspace"),
354 th.FG256(th.Warning, "ask"),
355 th.FG256(th.Assistant, "Allow?"),
356 th.FG256(th.Muted, "[y/n]"),
357 } {
358 if !strings.Contains(got, want) {
359 t.Fatalf("themed consent missing %q:\n%s", want, got)
360 }
361 }
362}
363
364func TestPermissionSummaryShowsDeniedScopes(t *testing.T) {
365 got := permissionSummary(tools.PermissionSet{})
366 if !strings.Contains(got, "fs read: none") || !strings.Contains(got, "fs write: none") {
367 t.Fatalf("summary did not show denied scopes:\n%s", got)
368 }
369}
370
371func TestPeelLeadingYes(t *testing.T) {
372 yes, rest := peelLeadingYes([]string{"-y", "--yes", "agent", "-y"})
373 if !yes {
374 t.Fatal("expected yes")
375 }
376 if len(rest) != 2 || rest[0] != "agent" || rest[1] != "-y" {
377 t.Fatalf("rest = %v", rest)
378 }
379 yes, rest = peelLeadingYes([]string{"agent", "-y"})
380 if yes || len(rest) != 2 {
381 t.Fatalf("yes=%v rest=%v", yes, rest)
382 }
383}
384
385func TestConsentZotfileAutoYesWritesReceipt(t *testing.T) {
386 home := t.TempDir()
387 t.Setenv("ZOT_HOME", home)
388 zf := zotfileLoaded{Digest: "abc123", Manifest: ZotfileManifest{Name: "demo", Version: "1.0.0"}}
389 var perms tools.PermissionSet
390 perms.Bash.Mode = "none"
391 allowed, err := consentZotfile(zf, perms, true)
392 if err != nil || !allowed {
393 t.Fatalf("auto yes: allowed=%v err=%v", allowed, err)
394 }
395 path := filepath.Join(home, "agents", "demo", "consents", "abc123.json")
396 if _, err := os.Stat(path); err != nil {
397 t.Fatalf("consent receipt missing: %v", err)
398 }
399 // Second call without -y should use the receipt.
400 allowed, err = consentZotfile(zf, perms, false)
401 if err != nil || !allowed {
402 t.Fatalf("cached consent: allowed=%v err=%v", allowed, err)
403 }
404}
405
406func TestConsentZotfileAutoYesAskDoesNotCache(t *testing.T) {
407 home := t.TempDir()
408 t.Setenv("ZOT_HOME", home)
409 zf := zotfileLoaded{Digest: "askdig", Manifest: ZotfileManifest{Name: "ask-agent", Version: "1.0.0"}}
410 var perms tools.PermissionSet
411 perms.Bash.Mode = "ask"
412 if _, err := consentZotfile(zf, perms, true); err != nil {
413 t.Fatal(err)
414 }
415 path := filepath.Join(home, "agents", "ask-agent", "consents", "askdig.json")
416 if _, err := os.Stat(path); !os.IsNotExist(err) {
417 t.Fatalf("ask mode should not cache consent, err=%v", err)
418 }
419}