detached 1eeff3a

Preserve Windows swarm construction

commit
1eeff3afef5b3fc177be1ea2c7376e48fded27bf
author
patriceckhart · · 2026-07-28 11:18 UTC
parent
6b2855e
signature
unsigned
2 files · +8 -1
M packages/agent/swarm/persist_test.go +4 -0
@@ -6,6 +6,7 @@ import (
66 "errors"
77 "os"
88 "path/filepath"
9+ "runtime"
910 "strings"
1011 "sync"
1112 "sync/atomic"
@@ -344,6 +345,9 @@ func TestResumeRestartsRunnerOnSameSession(t *testing.T) {
344345 }
345346
346347 func TestResumeRecalculatesLegacyStateInboxPath(t *testing.T) {
348+ if runtime.GOOS == "windows" {
349+ t.Skip("swarm inbox runtime relocation applies to Unix sockets")
350+ }
347351 root := t.TempDir()
348352 f := New(Config{
349353 Root: root, RepoRoot: root,
@@ -6,6 +6,7 @@ import (
6 "errors"6 "errors"
7 "os"7 "os"
8 "path/filepath"8 "path/filepath"
9+ "runtime"
9 "strings"10 "strings"
10 "sync"11 "sync"
11 "sync/atomic"12 "sync/atomic"
@@ -344,6 +345,9 @@ func TestResumeRestartsRunnerOnSameSession(t *testing.T) {
344 }345 }
345 346
346 func TestResumeRecalculatesLegacyStateInboxPath(t *testing.T) {347 func TestResumeRecalculatesLegacyStateInboxPath(t *testing.T) {
348+ if runtime.GOOS == "windows" {
349+ t.Skip("swarm inbox runtime relocation applies to Unix sockets")
350+ }
347 root := t.TempDir()351 root := t.TempDir()
348 f := New(Config{352 f := New(Config{
349 Root: root, RepoRoot: root,353 Root: root, RepoRoot: root,
M packages/agent/swarm/socketpath.go +4 -1
@@ -33,7 +33,10 @@ const maxUnixSocketPath = 100
3333 // stable path across parent and child processes and across Resume calls.
3434 func inboxSocketPath(root, agentID string) (string, error) {
3535 if runtime.GOOS == "windows" {
36- return "", fmt.Errorf("swarm inbox: unix sockets are not supported on %s", runtime.GOOS)
36+ // Keep swarm construction usable for callers with custom runners.
37+ // The production listener still reports that its unix transport is
38+ // unavailable, as it did before runtime-directory probing was added.
39+ return filepath.Join(root, "agents", agentID, "in.sock"), nil
3740 }
3841
3942 var bases []string
@@ -33,7 +33,10 @@ const maxUnixSocketPath = 100
33 // stable path across parent and child processes and across Resume calls.33 // stable path across parent and child processes and across Resume calls.
34 func inboxSocketPath(root, agentID string) (string, error) {34 func inboxSocketPath(root, agentID string) (string, error) {
35 if runtime.GOOS == "windows" {35 if runtime.GOOS == "windows" {
36- return "", fmt.Errorf("swarm inbox: unix sockets are not supported on %s", runtime.GOOS)36+ // Keep swarm construction usable for callers with custom runners.
37+ // The production listener still reports that its unix transport is
38+ // unavailable, as it did before runtime-directory probing was added.
39+ return filepath.Join(root, "agents", agentID, "in.sock"), nil
37 }40 }
38 41
39 var bases []string42 var bases []string

Keyboard shortcuts

Single-key shortcuts are on. ctrl k and esc work whatever this says.

ctrl k :
go to a section, branch, tag, file or repository
?
this list
j k
move the row cursor down / up
enter
open the row under the cursor; on Files, a directory opens or closes in place
↑ ↓ ← → home end
in the file tree (focus on a row): previous / next row, close / open a directory or go to its parent / first entry, first / last row. They never open a file
l h
on Files: open a directory or a file / close a directory or go up to its parent, then to the parent page. Elsewhere: into the side panel (on a merge request, its files) / back to the content; there j k move between its controls
g g G
first / last row
/
filter the list; on Files, find a file anywhere in the repository (esc clears, enter opens the best match)
b
switch branch or tag
g s g f g c g b g m g i g r g a
tabs: summary, files, commits, branches & tags, merge requests, issues, releases, actions (when available)
g h
home
w
wide mode: use the whole width of the screen, or not (remembered)
y
copy a permalink pinned to the commit
d u x
diff: split / unified / collapse or expand all
e E
diff: the whole file in view / every file, with the lines the hunks hide
n
merge request: next note in the diff
esc
close a dialog, leave a field

Branches 1

Tags 477

↑↓ moveenter openesc close