test(subagents): remove queue timeout race

commit: 38f58a780d54cc69aebe5d3e28c629b6b6346fb5
author: brice · 2mo ago · 2026-08-18 10:00 UTC
parent: 59535ff
signature: GPG VerifiedCD88F9E564E0102646FB6077A1A07C7C7C3E349D · arch-gpg Verified for the committer email

1 file · +5 -4

M packages/agent/subagents/resident_manager_test.go +5 -4


@@ -792,10 +792,8 @@ func TestResidentManagerAppliesPositiveQueueTimeoutDurably(t *testing.T) {
792	792		}, nil
793	793		})
794	794		defer manager.Close(context.Background())
795		-	for _, id := range []string{"first", "second"} {
796		-	if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: id, SessionID: id, Provider: "openai", Model: "gpt-5"}, id); err != nil {
797		-	t.Fatalf("Spawn(%s): %v", id, err)
798		-	}
	795	+	if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: "first", SessionID: "first", Provider: "openai", Model: "gpt-5"}, "first"); err != nil {
	796	+	t.Fatalf("Spawn(first): %v", err)
799	797		}
800	798		select {
801	799		case got := <-started:

@@ -805,6 +803,9 @@ func TestResidentManagerAppliesPositiveQueueTimeoutDurably(t *testing.T) {
805	803		case <-time.After(time.Second):
806	804		t.Fatal("first runner did not start")
807	805		}
	806	+	if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: "second", SessionID: "second", Provider: "openai", Model: "gpt-5"}, "second"); err != nil {
	807	+	t.Fatalf("Spawn(second): %v", err)
	808	+	}
808	809		deadline := time.Now().Add(time.Second)
809	810		for {
810	811		result, err := manager.Result("second")

 		}, nil
 	})
 	defer manager.Close(context.Background())
-	for _, id := range []string{"first", "second"} {
+	if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: "first", SessionID: "first", Provider: "openai", Model: "gpt-5"}, "first"); err != nil {
-		if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: id, SessionID: id, Provider: "openai", Model: "gpt-5"}, id); err != nil {
+		t.Fatalf("Spawn(first): %v", err)
-			t.Fatalf("Spawn(%s): %v", id, err)
-		}
 	}
 	select {
 	case got := <-started:
 	case <-time.After(time.Second):
 		t.Fatal("first runner did not start")
 	}
+	if _, err := manager.Spawn(context.Background(), ResidentChildSpec{ID: "second", SessionID: "second", Provider: "openai", Model: "gpt-5"}, "second"); err != nil {
+		t.Fatalf("Spawn(second): %v", err)
+	}
 	deadline := time.Now().Add(time.Second)
 	for {
 		result, err := manager.Result("second")